Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2020-06-13T15:51:39Zhttps://gitlab.torproject.org/legacy/trac/-/issues/33398Remove documentation for `--dump-config non-builtin` and deprecate it2020-06-13T15:51:39ZNick MathewsonRemove documentation for `--dump-config non-builtin` and deprecate itAs teor finds in #32467, it is apparently just the same as "short".
I should confirm that, and act accordingly.As teor finds in #32467, it is apparently just the same as "short".
I should confirm that, and act accordingly.Tor: unspecifiedNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/legacy/trac/-/issues/33339Add script to check ordering of options in manpage2020-06-13T15:51:26ZTaylor YuAdd script to check ordering of options in manpageAdd a script to check the ordering of option names within a manpage section.
This will be an initial version that doesn't restrict section names and doesn't recognize pragma comments that mark intentionally out-of-order option names.
#...Add a script to check the ordering of option names within a manpage section.
This will be an initial version that doesn't restrict section names and doesn't recognize pragma comments that mark intentionally out-of-order option names.
#32621 will contain a more fully-functional script suitable for automation.Tor: 0.4.3.x-finalTaylor YuTaylor Yuhttps://gitlab.torproject.org/legacy/trac/-/issues/33275Tor Manual: Alphabetize Remaining Tor Manual2020-06-13T15:51:18ZTracTor Manual: Alphabetize Remaining Tor ManualAlphabetically sort the options in the following sections:
- DENIAL OF SERVICE MITIGATION OPTIONS
- DIRECTORY AUTHORITY SERVER OPTIONS
- HIDDEN SERVICE OPTIONS
- TESTING NETWORK OPTIONS
**Trac**:
**Username**: swatiAlphabetically sort the options in the following sections:
- DENIAL OF SERVICE MITIGATION OPTIONS
- DIRECTORY AUTHORITY SERVER OPTIONS
- HIDDEN SERVICE OPTIONS
- TESTING NETWORK OPTIONS
**Trac**:
**Username**: swatiTor: 0.4.4.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/33213remove obsolete mirroring job from .gitlab-ci.yml2020-06-13T15:50:50ZTaylor Yuremove obsolete mirroring job from .gitlab-ci.ymlThis is just to incorporate the deletion of the mirroring job suggested in #32193.This is just to incorporate the deletion of the mirroring job suggested in #32193.Tor: 0.4.3.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/33203Fix typo in makedesc.py2020-06-13T15:50:48ZteorFix typo in makedesc.pySee this commit:
https://github.com/torproject/tor/pull/1686/commits/16561514782498009335205b08b2c0c123c6ab9bSee this commit:
https://github.com/torproject/tor/pull/1686/commits/16561514782498009335205b08b2c0c123c6ab9bTor: 0.4.3.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/33188Tor Manual: Alphabetize Server and Directory Server Options2020-06-13T15:50:43ZTracTor Manual: Alphabetize Server and Directory Server OptionsAlphabetize options in the Server Options and Directory Server Options
**Trac**:
**Username**: swatiAlphabetize options in the Server Options and Directory Server Options
**Trac**:
**Username**: swatihttps://gitlab.torproject.org/legacy/trac/-/issues/32971Document OwningControllerProcess time interval2020-06-13T15:50:00ZteorDocument OwningControllerProcess time intervalTor checks for its owning controller process every 15 seconds:
https://github.com/torproject/tor/blob/4f02812242d1fd90d859eb98ac3fb1ed182f18cf/src/lib/evloop/procmon.c#L168
We should document this interval in the man page.Tor checks for its owning controller process every 15 seconds:
https://github.com/torproject/tor/blob/4f02812242d1fd90d859eb98ac3fb1ed182f18cf/src/lib/evloop/procmon.c#L168
We should document this interval in the man page.Tor: 0.4.3.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/32929Tor Manual: Split Node options into their own subsection2020-06-13T15:49:54ZteorTor Manual: Split Node options into their own subsectionLet's put the client *Node* and GeoIPExcludeUnknown options in their own manpage section.
For context, see:
https://trac.torproject.org/projects/tor/ticket/32846#comment:11Let's put the client *Node* and GeoIPExcludeUnknown options in their own manpage section.
For context, see:
https://trac.torproject.org/projects/tor/ticket/32846#comment:11Tor: 0.4.3.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/32928Tor Manual: Split Circuit Timeout options into their own subsection2020-06-13T15:49:53ZteorTor Manual: Split Circuit Timeout options into their own subsectionLet's put the *Circuit*Timeout options in their own manpage section.
For context, see:
https://trac.torproject.org/projects/tor/ticket/32846#comment:11Let's put the *Circuit*Timeout options in their own manpage section.
For context, see:
https://trac.torproject.org/projects/tor/ticket/32846#comment:11Tor: 0.4.3.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/32921Code and script changes to run clang-format without breaking checkSpaces or c...2020-06-13T15:51:46ZNick MathewsonCode and script changes to run clang-format without breaking checkSpaces or coccinelleI've been working to make changes to our code and our scripts to improve our clang-format output. I think they are mature enough that we can merge them now.
I also think it may be time to merge a .clang-format file and a script to run ...I've been working to make changes to our code and our scripts to improve our clang-format output. I think they are mature enough that we can merge them now.
I also think it may be time to merge a .clang-format file and a script to run it. We'll want to tweak it a bunch before we actually run it on our code, but getting it into our version control will help us refine our way towards a reasonable target.
**Edited to clarify**: Neither the .clang-format file, the script, or the post-processing tool are meant to be a final version. This branch does not mean that our style choices are final. The goal here is just to land initial versions that we can start experimenting with.Tor: 0.4.3.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/legacy/trac/-/issues/32871Static linking issue with OpenSSL2020-06-13T15:52:15ZTracStatic linking issue with OpenSSLThere is a static linking issue with OpenSSL, link order of libz must be adjusted to solve bug with static linking and host paths must be removed when looking for openssl.
The patch is available at https://git.buildroot.net/buildroot/tr...There is a static linking issue with OpenSSL, link order of libz must be adjusted to solve bug with static linking and host paths must be removed when looking for openssl.
The patch is available at https://git.buildroot.net/buildroot/tree/package/tor/0001-Fix-static-linking-with-OpenSSL.patch
**Trac**:
**Username**: ffontaineTor: 0.4.4.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/32868crash: Assertion node->rs->is_possible_guard failed in compute_weighted_band...2020-06-13T15:49:41Ztoralfcrash: Assertion node->rs->is_possible_guard failed in compute_weighted_bandwidths atWith https://github.com/toralf/torutils/blob/f307866d2149bcd3c95df5269b3b48d051f871e9/info.py I monitor the status of my 2 Tor relays. A day before I commented out this section in torrc:
```
#FetchDirInfoEarly 1
#FetchDirInfoExtraEarly 1...With https://github.com/toralf/torutils/blob/f307866d2149bcd3c95df5269b3b48d051f871e9/info.py I monitor the status of my 2 Tor relays. A day before I commented out this section in torrc:
```
#FetchDirInfoEarly 1
#FetchDirInfoExtraEarly 1
#FetchUselessDescriptors 1
#UseMicrodescriptors 0
#DownloadExtraInfo 1
```
Now it took 7 minutes to finish (when those config values were set it was much faster).
But more interesting I realized today I crash of one of both Tor relays:
```
Jan 01 11:12:38.000 [warn] compute_weighted_bandwidths(): Bug: Consensus is missing some bandwidths. Using a naive router selection algorithm (on Tor 0.4.2.5 )
Jan 01 11:12:38.000 [err] tor_assertion_failed_(): Bug: src/feature/nodelist/node_select.c:723: compute_weighted_bandwidths: Assertion node->rs->is_possible_guard failed; aborting. (on Tor 0.4.2.5 )
Jan 01 11:12:38.000 [err] Bug: Tor 0.4.2.5: Assertion node->rs->is_possible_guard failed in compute_weighted_bandwidths at src/feature/nodelist/node_select.c:723: . Stack trace: (on Tor 0.4.2.5 )
Jan 01 11:12:38.000 [err] Bug: /usr/bin/tor(log_backtrace_impl+0x59) [0x55850995e1a9] (on Tor 0.4.2.5 )
Jan 01 11:12:38.000 [err] Bug: /usr/bin/tor(tor_assertion_failed_+0x150) [0x5585099593e0] (on Tor 0.4.2.5 )
Jan 01 11:12:38.000 [err] Bug: /usr/bin/tor(+0x12c474) [0x558509896474] (on Tor 0.4.2.5 )
Jan 01 11:12:38.000 [err] Bug: /usr/bin/tor(frac_nodes_with_descriptors+0x73) [0x558509897373] (on Tor 0.4.2.5 )
Jan 01 11:12:38.000 [err] Bug: /usr/bin/tor(+0x12afb2) [0x558509894fb2] (on Tor 0.4.2.5 )
Jan 01 11:12:38.000 [err] Bug: /usr/bin/tor(count_loading_descriptors_progress+0x6c) [0x558509895b2c] (on Tor 0.4.2.5 )
Jan 01 11:12:38.000 [err] Bug: /usr/bin/tor(connection_dir_reached_eof+0x20e0) [0x558509856f30] (on Tor 0.4.2.5 )
Jan 01 11:12:38.000 [err] Bug: /usr/bin/tor(connection_handle_read+0x980) [0x5585097d2760] (on Tor 0.4.2.5 )
Jan 01 11:12:38.000 [err] Bug: /usr/bin/tor(+0x6d97c) [0x5585097d797c] (on Tor 0.4.2.5 )
Jan 01 11:12:38.000 [err] Bug: /usr/lib64/libevent-2.1.so.6(+0x219ca) [0x7ffbba3cb9ca] (on Tor 0.4.2.5 )
Jan 01 11:12:38.000 [err] Bug: /usr/lib64/libevent-2.1.so.6(event_base_loop+0x4ef) [0x7ffbba3cc54f] (on Tor 0.4.2.5 )
Jan 01 11:12:38.000 [err] Bug: /usr/bin/tor(do_main_loop+0xdd) [0x5585097d8b2d] (on Tor 0.4.2.5 )
Jan 01 11:12:38.000 [err] Bug: /usr/bin/tor(tor_run_main+0x10c5) [0x5585097c6855] (on Tor 0.4.2.5 )
Jan 01 11:12:38.000 [err] Bug: /usr/bin/tor(tor_main+0x46) [0x5585097c4076] (on Tor 0.4.2.5 )
Jan 01 11:12:38.000 [err] Bug: /usr/bin/tor(main+0x19) [0x5585097c3c49] (on Tor 0.4.2.5 )
Jan 01 11:12:38.000 [err] Bug: /lib64/libc.so.6(__libc_start_main+0xeb) [0x7ffbb9d19eab] (on Tor 0.4.2.5 )
Jan 01 11:12:38.000 [err] Bug: /usr/bin/tor(_start+0x2a) [0x5585097c3c9a] (on Tor 0.4.2.5 )
```
System is a hardened Gentoo Linux running 2 relays. The second is not affected.Tor: 0.4.4.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/legacy/trac/-/issues/32859Tor man docs missing DoS log example2020-06-13T15:49:39ZTracTor man docs missing DoS log exampleIn "DENIAL OF SERVICE MITIGATION OPTIONS" man section, there is:
"If any of the DoS mitigations are enabled, a heartbeat message will appear in your log at NOTICE level which looks like:
DoS mitigation since startup: 429042 circuits re...In "DENIAL OF SERVICE MITIGATION OPTIONS" man section, there is:
"If any of the DoS mitigations are enabled, a heartbeat message will appear in your log at NOTICE level which looks like:
DoS mitigation since startup: 429042 circuits rejected, 17 marked addresses.
2238 connections closed. 8052 single hop clients refused.
The following options are useful only for a public relay. They control the Denial of Service mitigation subsystem described above."
However, Tor daemon actually logs:
"DoS mitigation since startup: **__x circuits killed with too many cells__**. y circuits rejected, z marked addresses. m connections closed. n single hop clients refused."
I propose:
1. adding log examples for each of the 3 log mitigation options, in their sections.
This perhaps will make more clear what "too many cells" means, as there seem to be no other documentation sources regarding this.
2. adding the **"x circuits killed with too many cells" **in the final log example.
**Trac**:
**Username**: JoeBeeezTor: unspecifiedDamian JohnsonDamian Johnsonhttps://gitlab.torproject.org/legacy/trac/-/issues/32817Run sandbox tests on Xenial and Bionic2020-06-13T15:49:28ZteorRun sandbox tests on Xenial and BionicWe currently run a Tor Travis CI chutney job on Bionic with the sandbox disabled.
The chutney Travis CI runs on Bionic and Xenial (for pypy), also with the Sandbox disabled.
Once #32722 is fixed, we should run some sandbox unit tests, ...We currently run a Tor Travis CI chutney job on Bionic with the sandbox disabled.
The chutney Travis CI runs on Bionic and Xenial (for pypy), also with the Sandbox disabled.
Once #32722 is fixed, we should run some sandbox unit tests, Tor binary tests, or chutney on both Xenial and Bionic, and newer Ubuntu versions as Travis creates images for them.Tor: unspecifiedhttps://gitlab.torproject.org/legacy/trac/-/issues/32806Move "easy" dirauth-only options to dirauth module2020-06-13T15:49:23ZNick MathewsonMove "easy" dirauth-only options to dirauth moduleFor this ticket, I'll be moving all of the easy, simple dirauth configuration options to the appropriate module.
I'm defining options as "easy" if they aren't currently used anywhere outside the dirauth module, the config module, and th...For this ticket, I'll be moving all of the easy, simple dirauth configuration options to the appropriate module.
I'm defining options as "easy" if they aren't currently used anywhere outside the dirauth module, the config module, and the tests.
For other dirauth-only options, I'll want to do some refactoring first.Tor: 0.4.3.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/legacy/trac/-/issues/32722Make the seccomp sandbox work with Ubuntu Xenial and Bionic2020-06-13T15:49:05ZteorMake the seccomp sandbox work with Ubuntu Xenial and BionicTor's Linux seccomp sandbox fails on Ubuntu Xenial and Bionic, when running tor via chutney.
A --disable-seccomp build succeeds:
https://travis-ci.org/teor2345/tor/jobs/622543371?utm_medium=notification&utm_source=github_status
But a ...Tor's Linux seccomp sandbox fails on Ubuntu Xenial and Bionic, when running tor via chutney.
A --disable-seccomp build succeeds:
https://travis-ci.org/teor2345/tor/jobs/622543371?utm_medium=notification&utm_source=github_status
But a build with CHUTNEY_NET_DIR=/tmp fails:
https://travis-ci.org/teor2345/tor/jobs/622543706
We should modify tor to work with those glibc versions.Tor: unspecifiedhttps://gitlab.torproject.org/legacy/trac/-/issues/32691Image broken in 'src-ref' documentation2020-06-13T15:48:55ZoparaImage broken in 'src-ref' documentationFor example if you visit https://src-ref.docs.torproject.org/tor/dataflow.html, the "structure hierarchy for connection types" image is missing (the img tag has a 404). There are possibly other missing images as well, but I can't find th...For example if you visit https://src-ref.docs.torproject.org/tor/dataflow.html, the "structure hierarchy for connection types" image is missing (the img tag has a 404). There are possibly other missing images as well, but I can't find the markdown files to check (there were the original versions, then they were moved to the tor git repo and edited iirc, but now they're gone).
There's also another image missing on the same page, but has no <img> tag (compare the top of the https://people.torproject.org/~nickm/tor-auto/internal/02-dataflow.html and https://src-ref.docs.torproject.org/tor/dataflow.html pages). But it may have been removed on purpose.Tor: unspecifiedNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/legacy/trac/-/issues/32627deploy torspec as HTML to GitLab Pages2020-06-13T15:48:42Zeighthavedeploy torspec as HTML to GitLab Pageshttps://github.com/torproject/torspec/pull/96 will deploy torspec in HTML to any GitLab fork setup with CI and Pages (default on gitlab.com). it only adds one file: _.gitlab-ci.yml_
Once merged, the site will show up automatically on ht...https://github.com/torproject/torspec/pull/96 will deploy torspec in HTML to any GitLab fork setup with CI and Pages (default on gitlab.com). it only adds one file: _.gitlab-ci.yml_
Once merged, the site will show up automatically on https://torproject.gitlab.io/torspec, and it'll sync every commit from the canonical repo and automatically rebuild the HTML.
The sed regexps in _.gitlab-ci.yml_ could be used as the beginnings of a conversion to Markdown format, as needed.Tor: 0.4.3.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/32621Add automated checks to make sure man page options stay in alphabetical order2020-06-13T15:51:26ZteorAdd automated checks to make sure man page options stay in alphabetical orderWe should add automated checks or automated tooling that makes sure that the man page options are in alphabetical order (within sections).
These tools will help us not regress #4310.We should add automated checks or automated tooling that makes sure that the man page options are in alphabetical order (within sections).
These tools will help us not regress #4310.Tor: unspecifiedhttps://gitlab.torproject.org/legacy/trac/-/issues/32620Put man page options in smaller sections2020-06-13T15:48:39ZteorPut man page options in smaller sectionsAfter we sort alphabetically in #4310, some related options won't be near each other. We can fix this issue by having smaller man page sections.After we sort alphabetically in #4310, some related options won't be near each other. We can fix this issue by having smaller man page sections.Tor: 0.4.3.x-final