Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2020-06-15T23:22:58Zhttps://gitlab.torproject.org/legacy/trac/-/issues/14122add environment variable to hide TBB's logo2020-06-15T23:22:58Zproperadd environment variable to hide TBB's logoSpeaking as a user of Tails and a maintainer of Whonix, I want to point out, that showing the [Tor Browser Bundle](https://gitweb.torproject.org/tor-launcher.git/blob/HEAD:/src/chrome/skin/tbb-logo.png) Logo when using tor-launcher only...Speaking as a user of Tails and a maintainer of Whonix, I want to point out, that showing the [Tor Browser Bundle](https://gitweb.torproject.org/tor-launcher.git/blob/HEAD:/src/chrome/skin/tbb-logo.png) Logo when using tor-launcher only for configuring Tor without TBB is inappropriate and confusing. It should not be shown in that mode.
Could you please add an environment variable such as `TOR_HIDE_LOGO`?
That would also be useful to avoid [trademark issues](https://www.torproject.org/docs/trademark-faq.html.en) when redistributing original, unmodified TBB in (linux) distributions.
Related:
* #14121
* #12451https://gitlab.torproject.org/legacy/trac/-/issues/14100Toggle NetworkSettings menuitem visibility based on an environment variable2020-06-15T23:22:56ZTracToggle NetworkSettings menuitem visibility based on an environment variableThis is a feature requested by some linux distros, where the "Open Network Settings..." menuitem in TorButton is unneeded. A patch is to be made so this menuitem becomes hidden if a certain environment variable is set.
**Trac**:
**Use...This is a feature requested by some linux distros, where the "Open Network Settings..." menuitem in TorButton is unneeded. A patch is to be made so this menuitem becomes hidden if a certain environment variable is set.
**Trac**:
**Username**: linostarMark SmithMark Smithhttps://gitlab.torproject.org/legacy/trac/-/issues/13079environment variable to skip TorButton control port verification2020-06-15T23:20:19Zproperenvironment variable to skip TorButton control port verificationTor Button now does its own Tor ControlPort verification.
Source [#6546 comment:33 mikeperry](https://trac.torproject.org/projects/tor/ticket/6546#comment:33):
> TBB now performs its own control port verification. We simply check that t...Tor Button now does its own Tor ControlPort verification.
Source [#6546 comment:33 mikeperry](https://trac.torproject.org/projects/tor/ticket/6546#comment:33):
> TBB now performs its own control port verification. We simply check that the socks port Tor says its on is the one Firefox is configured to use.
If that test fails, the default homepage `about:tor` will show:
```
Something Went Wrong!
Tor is not working in this browser.
```
This is problematic in transparent / isolating proxy environments, that do not wish to allow ControlPort access for security reasons (getinfo address and other dangerous ControlPort commands).
The test is implemented in `torbrowser.js`, in `function torbutton_local_tor_check()`.
```
[...]
const kCmdArg = "net/listeners/socks";
[...]
let resp = torbutton_send_ctrl_cmd("GETINFO " + kCmdArg + "\r\n");
[...]
```
(The environment variable `TOR_SKIP_LAUNCH=1` does not prevent this. [No such variable in Tor Button's source code.])
It would be nice if there was an environment variable such as `TOR_SKIP_CONTROLPORTTEST` (or so), that would skip this test.https://gitlab.torproject.org/legacy/trac/-/issues/13015Update gitian signing+sig check+upload scripts to use tag/branch2020-06-15T23:23:10ZMike PerryUpdate gitian signing+sig check+upload scripts to use tag/branchWe should standardize the directory location of candidate builds, to make it clearer what a build directory corresponds to.
basename `git describe --all` is probably what we want to use as the target dir for a build.We should standardize the directory location of candidate builds, to make it clearer what a build directory corresponds to.
basename `git describe --all` is probably what we want to use as the target dir for a build.Erinn ClarkErinn Clark