Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2013-12-02T09:48:39Zhttps://gitlab.torproject.org/legacy/trac/-/issues/10235Packaging (JavaScript) resources into omni.ja files is non-deterministic in E...2013-12-02T09:48:39ZGeorg KoppenPackaging (JavaScript) resources into omni.ja files is non-deterministic in ESR24Comparing 3.5pre builds made by ln5 showed that at least packaging JavaScript resources into omni.ja files, as it is currently done by Mozilla, can lead to a non-deterministic bundle.Comparing 3.5pre builds made by ln5 showed that at least packaging JavaScript resources into omni.ja files, as it is currently done by Mozilla, can lead to a non-deterministic bundle.Erinn ClarkErinn Clarkhttps://gitlab.torproject.org/legacy/trac/-/issues/10159omni.ja differs in ESR24 Gitian builds2020-06-13T03:20:46ZGeorg Koppenomni.ja differs in ESR24 Gitian buildsTesting two builds with the new OS X cross-compiler showed that browser/omni.ja differed. More exactly, only the contents of chrome.manifest showed some reordering.Testing two builds with the new OS X cross-compiler showed that browser/omni.ja differed. More exactly, only the contents of chrome.manifest showed some reordering.Erinn ClarkErinn Clarkhttps://gitlab.torproject.org/legacy/trac/-/issues/10139--enable-strip is broken in ESR24 builds for Mac OS X2020-06-13T03:20:46ZGeorg Koppen--enable-strip is broken in ESR24 builds for Mac OS Xhttps://bugzilla.mozilla.org/show_bug.cgi?id=809803 breaks our --enable-strip option. According to froydnj this is a real bug. It is "tracked" in https://bugzilla.mozilla.org/show_bug.cgi?id=841373.https://bugzilla.mozilla.org/show_bug.cgi?id=809803 breaks our --enable-strip option. According to froydnj this is a real bug. It is "tracked" in https://bugzilla.mozilla.org/show_bug.cgi?id=841373.Erinn ClarkErinn Clarkhttps://gitlab.torproject.org/legacy/trac/-/issues/10102New random bytes in TBB3 windows builds2020-06-13T07:44:30ZMike PerryNew random bytes in TBB3 windows buildsThere appear to be new occasional random bytes appearing in the TBB windows builds, similar to #10026 but potentially due to a different underlying cause.
We should get to the bottom of this before the stable.There appear to be new occasional random bytes appearing in the TBB windows builds, similar to #10026 but potentially due to a different underlying cause.
We should get to the bottom of this before the stable.Erinn ClarkErinn Clarkhttps://gitlab.torproject.org/legacy/trac/-/issues/10078Make sure torbutton_do_new_identity() is still working properly in ESR242013-12-11T11:43:52ZGeorg KoppenMake sure torbutton_do_new_identity() is still working properly in ESR24We should make sure that all mechanisms to clear state between to sessions are still doing their job. E.g. clearing the SSL session Id should not work anymore with the current code as logout() is gone in Fx 21 (https://bugzilla.mozilla.o...We should make sure that all mechanisms to clear state between to sessions are still doing their job. E.g. clearing the SSL session Id should not work anymore with the current code as logout() is gone in Fx 21 (https://bugzilla.mozilla.org/show_bug.cgi?id=683262) and "security.enable_ssl2" is gone long ago (even "security.enable_ssl3" is gone, in Fx 23).https://gitlab.torproject.org/legacy/trac/-/issues/10049TBB 32bit/64bit Linux detection only works from CLI2013-11-14T23:31:23ZMoritz BartlTBB 32bit/64bit Linux detection only works from CLII just noticed that my patch for #3841 (detecting 32bit vs 64bit) only works if the TBB directory is already the working directory. The proposed fix moves the detection towards the end of the script, where the working directory has alrea...I just noticed that my patch for #3841 (detecting 32bit vs 64bit) only works if the TBB directory is already the working directory. The proposed fix moves the detection towards the end of the script, where the working directory has already been changed.Mike PerryMike Perryhttps://gitlab.torproject.org/legacy/trac/-/issues/9837make package is broken for TBB 3.0 based on Firefox 24 ESR2020-06-13T04:58:20ZGeorg Koppenmake package is broken for TBB 3.0 based on Firefox 24 ESRThe output is:
```
+ make -C obj-mingw package INNER_MAKE_PACKAGE=true
make: Entering directory `/home/ubuntu/build/tor-browser/obj-mingw'
make[1]: Entering directory `/home/ubuntu/build/tor-browser/obj-mingw/browser/installer'
make expo...The output is:
```
+ make -C obj-mingw package INNER_MAKE_PACKAGE=true
make: Entering directory `/home/ubuntu/build/tor-browser/obj-mingw'
make[1]: Entering directory `/home/ubuntu/build/tor-browser/obj-mingw/browser/installer'
make export
make[2]: Entering directory `/home/ubuntu/build/tor-browser/obj-mingw/browser/installer'
make[2]: Nothing to be done for `export'.
make[2]: Leaving directory `/home/ubuntu/build/tor-browser/obj-mingw/browser/installer'
make libs
make[2]: Entering directory `/home/ubuntu/build/tor-browser/obj-mingw/browser/installer'
make make-package-internal
make[3]: Entering directory `/home/ubuntu/build/tor-browser/obj-mingw/browser/installer'
/home/ubuntu/build/tor-browser/obj-mingw/_virtualenv/bin/python /home/ubuntu/build/tor-browser/config/Preprocessor.py -DNO_NSPR_10_SUPPORT -DAB_CD=en-US -DMOZ_APP_NAME=firefox -DPREF_DIR=defaults/preferences -DJAREXT= -DMOZ_CHILD_PROCESS_NAME=plugin-container.exe -DMOZ_SHARED_MOZGLUE=1 -DMOZ_JSDEBUGGER -DNECKO_WIFI -DDLL_PREFIX= -DDLL_SUFFIX=.dll -DBIN_SUFFIX=.exe -DBINPATH=bin -DCROSS_COMPILE=1 -DWINVER=0x502 -D_WIN32_WINNT=0x502 -D_WIN32_IE=0x0603 -DMOZ_WINSDK_TARGETVER=0x06010000 -DMOZ_NTDDI_WIN7=0x06010000 -DMOZ_WINSDK_MAXVER=0x06020000 -DX_DISPLAY_MISSING=1 -DJSGC_INCREMENTAL=1 -DMOZ_ENABLE_PROFILER_SPS=1 -DMOZILLA_VERSION=\"24.0\" -DMOZILLA_VERSION_U=24.0 -DMOZILLA_UAVERSION=\"24.0\" -DHAVE_SNPRINTF=1 -D_WINDOWS=1 -DWIN32=1 -DXP_WIN=1 -DXP_WIN32=1 -DHW_THREADS=1 -DSTDC_HEADERS=1 -DWIN32_LEAN_AND_MEAN=1 -DNO_X11=1 -D_X86_=1 -DD_INO=d_ino -DSTDC_HEADERS=1 -DHAVE_STDCALL=1 -DHAVE_SSIZE_T=1 -DHAVE_DIRENT_H=1 -DHAVE_GETOPT_H=1 -DHAVE_MEMORY_H=1 -DHAVE_UNISTD_H=1 -DHAVE_MALLOC_H=1 -DHAVE_IO_H=1 -DHAVE_CPUID_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_CDEFS_H=1 -DNO_X11=1 -DHAVE_STRERROR=1 -DHAVE_SNPRINTF=1 -DHAVE_MEMMOVE=1 -DHAVE_RINT=1 -DHAVE_TRUNCATE64=1 -DHAVE_SETBUF=1 -DHAVE_ISATTY=1 -DHAVE_THREAD_TLS_KEYWORD=1 -DMALLOC_H=\<malloc.h\> -DHAVE_LOCALECONV=1 -DNS_ATTR_MALLOC=__attribute__\(\(malloc\)\) -DNS_WARN_UNUSED_RESULT=__attribute__\(\(warn_unused_result\)\) -DRELEASE_BUILD=1 -DNS_ENABLE_TSF=1 -DMOZ_UPDATE_CHANNEL=default -DMOZ_GOOGLE_API_KEY=no-google-api-key -DEARLY_BETA_OR_EARLIER=1 -DMOZ_PHOENIX=1 -DMOZ_BUILD_APP=browser -DMOZ_PDF_PRINTING=1 -DMOZ_INSTRUMENT_EVENT_LOOP=1 -DMOZ_OFFICIAL_BRANDING=1 -DMOZ_DISTRIBUTION_ID=\"org.mozilla\" -DIBMBIDI=1 -DNS_PRINTING=1 -DNS_PRINT_PREVIEW=1 -DMOZ_SAMPLE_TYPE_FLOAT32=1 -DMOZ_WEBSPEECH=1 -DMOZ_OGG=1 -DATTRIBUTE_ALIGNED_MAX=64 -DMOZ_WEBM=1 -DMOZ_WMF=1 -DMOZ_MEDIA_NAVIGATOR=1 -DMOZ_VP8=1 -DVPX_X86_ASM=1 -DMOZ_WAVE=1 -DMOZ_SPEEX_RESAMPLER=1 -DMOZ_SOUNDTOUCH=1 -DMOZ_CUBEB=1 -DMOZ_VORBIS=1 -DMOZ_OPUS=1 -DENABLE_SYSTEM_EXTENSION_DIRS=1 -DMOZ_GAMEPAD=1 -DBREAKPAD_CUSTOM_STDINT_H=\"mozilla/StandardInteger.h\" -DMOZ_CRASHREPORTER_ENABLE_PERCENT=100 -DLIBJPEG_TURBO_X86_ASM=1 -DMOZ_VERIFY_MAR_SIGNATURE=1 -DMOZ_FEEDS=1 -DMOZ_SAFE_BROWSING=1 -DMOZ_URL_CLASSIFIER=1 -DGL_PROVIDER_=1 -DMOZ_DEBUG_SYMBOLS=1 -DMOZ_LOGGING=1 -DJSGC_INCREMENTAL=1 -DHAVE___CXA_DEMANGLE=1 -DHAVE__UNWIND_BACKTRACE=1 -DJS_DEFAULT_JITREPORT_GRANULARITY=3 -DMOZ_OMNIJAR=1 -DMOZ_USER_DIR=\"Mozilla\" -DMOZ_TREE_PIXMAN=1 -DHAVE_STDINT_H=1 -DHAVE_INTTYPES_H=1 -DMOZ_TREE_CAIRO=1 -DHAVE_UINT64_T=1 -DMOZ_ENABLE_SKIA=1 -DUSE_SKIA=1 -DSKIA_DLL=1 -DGR_DLL=1 -DUSE_SKIA_GPU=1 -DMOZ_XUL=1 -DMOZ_PROFILELOCKING=1 -DBUILD_CTYPES=1 -DMOZ_PLACES=1 -DMOZ_SOCIAL=1 -DMOZ_SERVICES_COMMON=1 -DMOZ_SERVICES_CRYPTO=1 -DMOZ_SERVICES_HEALTHREPORT=1 -DMOZ_SERVICES_METRICS=1 -DMOZ_SERVICES_SYNC=1 -DMOZ_MACBUNDLE_ID=org.mozilla.torbrowser -DMOZ_B2G_VERSION=\"1.0.0\" -DMOZ_B2G_OS_NAME=\"\" -DMOZ_APP_UA_NAME=\"\" -DMOZ_APP_UA_VERSION=\"24.0\" -DFIREFOX_VERSION=24.0 -DMOZ_UA_BUILDID=\"20100101\" -DMOZ_TELEMETRY_DISPLAY_REV=2 -DMOZ_DATA_REPORTING=1 -DMOZ_DLL_SUFFIX=\".dll\" /home/ubuntu/build/tor-browser/browser/installer/package-manifest.in > package-manifest
OMNIJAR_NAME=omni.ja \
/home/ubuntu/build/tor-browser/obj-mingw/_virtualenv/bin/python /home/ubuntu/build/tor-browser/toolkit/mozapps/installer/packager.py -DNO_NSPR_10_SUPPORT -DAB_CD=en-US -DMOZ_APP_NAME=firefox -DPREF_DIR=defaults/preferences -DJAREXT= -DMOZ_CHILD_PROCESS_NAME=plugin-container.exe -DMOZ_SHARED_MOZGLUE=1 -DMOZ_JSDEBUGGER -DNECKO_WIFI -DDLL_PREFIX= -DDLL_SUFFIX=.dll -DBIN_SUFFIX=.exe -DBINPATH=bin \
--format omni \
--removals /home/ubuntu/build/tor-browser/browser/installer/removed-files.in \
\
\
\
--optimizejars \
\
package-manifest ../../dist ../../dist/firefox \
Error: /home/ubuntu/build/tor-browser/obj-mingw/browser/installer/package-manifest:35: Missing file(s): bin/uninstall/helper.exe
Error: /home/ubuntu/build/tor-browser/obj-mingw/browser/installer/package-manifest:397: Missing file(s): bin/defaults/preferences/000-tor-browser.js
Traceback (most recent call last):
File "/home/ubuntu/build/tor-browser/toolkit/mozapps/installer/packager.py", line 375, in <module>
main()
File "/home/ubuntu/build/tor-browser/toolkit/mozapps/installer/packager.py", line 328, in main
copier.add(mozpack.path.join(binpath, 'removed-files'), removals)
File "/usr/lib/python2.7/contextlib.py", line 24, in __exit__
self.gen.next()
File "/home/ubuntu/build/tor-browser/python/mozbuild/mozpack/errors.py", line 129, in accumulate
raise AccumulatedErrors()
mozpack.errors.AccumulatedErrors
make[3]: *** [stage-package] Error 1
make[3]: Leaving directory `/home/ubuntu/build/tor-browser/obj-mingw/browser/installer'
make[2]: *** [make-package] Error 2
make[2]: Leaving directory `/home/ubuntu/build/tor-browser/obj-mingw/browser/installer'
make[1]: *** [default] Error 2
make[1]: Leaving directory `/home/ubuntu/build/tor-browser/obj-mingw/browser/installer'
make: *** [package] Error 2
make: Leaving directory `/home/ubuntu/build/tor-browser/obj-mingw'
```Erinn ClarkErinn Clarkhttps://gitlab.torproject.org/legacy/trac/-/issues/9830mingw-w64 compilation of Firefox 24 ESR is broken2020-06-13T03:40:56ZGeorg Koppenmingw-w64 compilation of Firefox 24 ESR is brokenmingw-w64 compilation of Firefox 24 ESR with the current rev (5830) is broken.mingw-w64 compilation of Firefox 24 ESR with the current rev (5830) is broken.Erinn ClarkErinn Clarkhttps://gitlab.torproject.org/legacy/trac/-/issues/9828Firefox 24 ESR needs at least Python 2.7 and libgstreamer dev packages on the...2020-06-13T02:39:22ZGeorg KoppenFirefox 24 ESR needs at least Python 2.7 and libgstreamer dev packages on the 10.04 VMUbuntu 10.04, which we use to build the TBB3.0 for Linux, does not ship with Python 2.7, yet Firefox ESR 24 needs it in order to get built.Ubuntu 10.04, which we use to build the TBB3.0 for Linux, does not ship with Python 2.7, yet Firefox ESR 24 needs it in order to get built.Erinn ClarkErinn Clarkhttps://gitlab.torproject.org/legacy/trac/-/issues/9563TBB architecture check depends on working directory2020-06-13T02:56:44ZcypherpunksTBB architecture check depends on working directoryVersion: tor-browser-linux32-3.0-alpha-3_en-US
When start-tor-browser is run from a location other than within its directory (eg, it is not invoked as ./start-tor-browser), the architecture check introduced for #3841 looks for tor at th...Version: tor-browser-linux32-3.0-alpha-3_en-US
When start-tor-browser is run from a location other than within its directory (eg, it is not invoked as ./start-tor-browser), the architecture check introduced for #3841 looks for tor at the wrong path and fails with a message like this:
```
./Downloads/tor-browser_en-US/start-tor-browser: 123: [: -ne: argument expected
```
The check fails open, though, so after that error is printed everything still works (assuming the architecture is correct).
Replacing this:
```
TORARCHITECTURE=$(expr "$(file App/tor)" : '.*ELF \([[:digit:]]*\)')
```
With this:
```
TORARCHITECTURE=$(expr "$(file $(dirname $0)/App/tor)" : '.*ELF \([[:digit:]]*\)')
```
should fix the problem.Mike PerryMike Perryhttps://gitlab.torproject.org/legacy/trac/-/issues/9454The nsIPluginTag Interface was changed, Torbutton is broken for next Firefox ESR2013-12-03T23:28:12ZcypherpunksThe nsIPluginTag Interface was changed, Torbutton is broken for next Firefox ESRTorbrowser loads system-wide installed flash plugin, disables it during init but plugin was loaded to browser's address space already.
Unless user changed security settings, browser shouldn't load anything.Torbrowser loads system-wide installed flash plugin, disables it during init but plugin was loaded to browser's address space already.
Unless user changed security settings, browser shouldn't load anything.Mike PerryMike Perryhttps://gitlab.torproject.org/legacy/trac/-/issues/9173Relocate RelativeLink functionality to Firefox patch2022-05-27T16:01:31ZMike PerryRelocate RelativeLink functionality to Firefox patchWe need to hardcode our home and profile settings from RelativeLink into a Firefox patch so that users still get expected behavior on Mac and Windows if they dock Firefox instead of the RelativeLink exe/containing app.
This will also pr...We need to hardcode our home and profile settings from RelativeLink into a Firefox patch so that users still get expected behavior on Mac and Windows if they dock Firefox instead of the RelativeLink exe/containing app.
This will also prevent situations where TBB ends up set as the default browser or link handler, and gets launched to handle a url without RelativeLink.
This is a pretty bad usability bug, because Firefox will end up using the wrong profile if you launch it without RelativeLink right now.
In most cases, this will cause it to fail closed (because the socks proxy won't be listening), but not if the user already has proxy settings overrides for their default profile.Mark SmithMark Smith