Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2022-09-01T23:00:13Zhttps://gitlab.torproject.org/legacy/trac/-/issues/32027Bump version of Go to 1.13+2022-09-01T23:00:13ZCecylia BocovichBump version of Go to 1.13+We're going to need it eventually for newer versions of pion/webrtc, and there's a nice feature in to log package that allows us to pass the log output writer to libraries.We're going to need it eventually for newer versions of pion/webrtc, and there's a nice feature in to log package that allows us to pass the log output writer to libraries.boklmboklmhttps://gitlab.torproject.org/legacy/trac/-/issues/31918Rebase and squash mobile and desktop patches2020-06-16T19:16:33ZMatthew FinkelRebase and squash mobile and desktop patchesThe patches for `mobile/android` are separate from the patches for desktop. Some of these patches are similar, such as adding a mozconfig and overriding prefs. Now that Android is a first-class supported platform, we can squash some of t...The patches for `mobile/android` are separate from the patches for desktop. Some of these patches are similar, such as adding a mozconfig and overriding prefs. Now that Android is a first-class supported platform, we can squash some of these patches so we reduce the number of patches we need carry on top of Firefox.Alex CatarineuAlex Catarineuhttps://gitlab.torproject.org/legacy/trac/-/issues/34108Write script to keep track of toolchain changes2020-06-16T01:26:23ZGeorg KoppenWrite script to keep track of toolchain changesWe have a lot of different requirements for our toolchain (see: #33557) due to a number of different projects involved in building Fenix. We should write a script that we run periodically to keep track of necessary toolchain changes ahea...We have a lot of different requirements for our toolchain (see: #33557) due to a number of different projects involved in building Fenix. We should write a script that we run periodically to keep track of necessary toolchain changes ahead of time.Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/legacy/trac/-/issues/20254Update marsigning-check.sh to cope with signed OS X MAR files2020-06-16T01:25:57ZGeorg KoppenUpdate marsigning-check.sh to cope with signed OS X MAR filesNow that the fix for #19410 landed our `marsigning-check.sh` script can't check the correctness of our MAR file signatures easily anymore as we use the SHA256 sums of the unsigned MAR files currently. We should adapt the script.Now that the fix for #19410 landed our `marsigning-check.sh` script can't check the correctness of our MAR file signatures easily anymore as we use the SHA256 sums of the unsigned MAR files currently. We should adapt the script.https://gitlab.torproject.org/legacy/trac/-/issues/31992Remove apktool workaround in #315642020-06-16T01:25:47ZGeorg KoppenRemove apktool workaround in #31564We found a reproducibility issue on Android with the switch to Firefox 68 ESR and the respective toolchain and fixed it by using an `apktool` downloaded from the Internet. We should remove that workaronud and replace it with a better one...We found a reproducibility issue on Android with the switch to Firefox 68 ESR and the respective toolchain and fixed it by using an `apktool` downloaded from the Internet. We should remove that workaronud and replace it with a better one (e.g. by switching our compile environment to Debian Buster and using the means the distro provides us with).Shane IsbellShane Isbellhttps://gitlab.torproject.org/legacy/trac/-/issues/27105Fix Tor Browser testsuite2020-06-16T01:13:09ZboklmFix Tor Browser testsuiteWe need to fix the Tor Browser testsuite to work with esr78 based Tor Browser.We need to fix the Tor Browser testsuite to work with esr78 based Tor Browser.Alex CatarineuAlex Catarineuhttps://gitlab.torproject.org/legacy/trac/-/issues/34145Investigate fallout from transitioning to 77.0b12020-06-16T01:12:56ZGeorg KoppenInvestigate fallout from transitioning to 77.0b1Compilation is busted with our patches based on 77.0b1. This is the bug to investigate this.Compilation is busted with our patches based on 77.0b1. This is the bug to investigate this.https://gitlab.torproject.org/legacy/trac/-/issues/34005./mach configure --disable-compile-environment breaks for Tor Browser2020-06-16T01:12:47ZGeorg Koppen./mach configure --disable-compile-environment breaks for Tor BrowserSometimes it is useful to use Mozilla's build environment without checking whether all the compilers and necessary tools are available (see for instance #33973). Mozilla has the `--disable-compile-environment` option for that. It succeed...Sometimes it is useful to use Mozilla's build environment without checking whether all the compilers and necessary tools are available (see for instance #33973). Mozilla has the `--disable-compile-environment` option for that. It succeeds with a clean Mozilla esr68 branch but fails for us for three reasons if we delete the respective `.mozconfig` file:
1) `--disable-tor-launcher` needs to be set even though we don't want to compile anything
2) `--with-tor-browser-version` needs to be specified even though we don't want to compile anything
3) `--enable-official-branding` needs to be specified because otherwise `default512.png` in the unofficial branding is missing (or `default256.png` for the esr68-based branches)https://gitlab.torproject.org/legacy/trac/-/issues/33998stop using XUL <grid> soon2020-06-16T01:12:46ZMark Smithstop using XUL <grid> soonMozilla is removing support for XUL <grid>, probably in Firefox 78. References:
https://bugzilla.mozilla.org/show_bug.cgi?id=1525737
https://groups.google.com/forum/#!topic/mozilla.dev.platform/yDiT7nEWe2c
Our Tor Browser patches use it...Mozilla is removing support for XUL <grid>, probably in Firefox 78. References:
https://bugzilla.mozilla.org/show_bug.cgi?id=1525737
https://groups.google.com/forum/#!topic/mozilla.dev.platform/yDiT7nEWe2c
Our Tor Browser patches use it here:
https://gitweb.torproject.org/tor-browser.git/tree/browser/components/torpreferences/content/torPane.xul?h=tor-browser-68.7.0esr-9.5-1#n77
Tor Launcher uses it here:
https://gitweb.torproject.org/tor-launcher.git/tree/src/chrome/content/network-settings-shared.js#n15Mark SmithMark Smithhttps://gitlab.torproject.org/legacy/trac/-/issues/33965Uplift 27604: Fix addon issues when moving TB directory2020-06-16T01:12:42ZAlex CatarineuUplift 27604: Fix addon issues when moving TB directoryThis is https://bugzilla.mozilla.org/show_bug.cgi?id=1429838, which did not get much attention by mozilla. But we can try attaching our patch and see if there's some progress.This is https://bugzilla.mozilla.org/show_bug.cgi?id=1429838, which did not get much attention by mozilla. But we can try attaching our patch and see if there's some progress.Alex CatarineuAlex Catarineuhttps://gitlab.torproject.org/legacy/trac/-/issues/33964Consider uplifting 21537: Mark .onion cookies as secure2020-06-16T01:12:41ZAlex CatarineuConsider uplifting 21537: Mark .onion cookies as secureAssuming that adapting the patch for newer Firefox versions was done correctly in #33533, now the patch is just a single [line](https://github.com/acatarineu/tor-browser/commit/53dad612587427817197d6bc2559285cc65ae238), which might be ea...Assuming that adapting the patch for newer Firefox versions was done correctly in #33533, now the patch is just a single [line](https://github.com/acatarineu/tor-browser/commit/53dad612587427817197d6bc2559285cc65ae238), which might be easy to uplift.https://gitlab.torproject.org/legacy/trac/-/issues/33963Uplift test for 21321 (Add test for .onion whitelisting)2020-06-16T01:12:41ZAlex CatarineuUplift test for 21321 (Add test for .onion whitelisting)It's just making sure that `dom.securecontext.whitelist_onions` is set to `false`, which should not affect Firefox.It's just making sure that `dom.securecontext.whitelist_onions` is set to `false`, which should not affect Firefox.Alex CatarineuAlex Catarineuhttps://gitlab.torproject.org/legacy/trac/-/issues/33962Uplift patch for 5741 (dns leak protection)2020-06-16T01:12:41ZAlex CatarineuUplift patch for 5741 (dns leak protection)This should probably be under the `--enable-proxy-bypass-protection` flag.This should probably be under the `--enable-proxy-bypass-protection` flag.Alex CatarineuAlex Catarineuhttps://gitlab.torproject.org/legacy/trac/-/issues/33961Uplift patch for "21830: Copying large text from web console leaks to /tmp"2020-06-16T01:12:40ZAlex CatarineuUplift patch for "21830: Copying large text from web console leaks to /tmp"Bugzilla is https://bugzilla.mozilla.org/show_bug.cgi?id=1433030. We can somehow try to make progress on that.Bugzilla is https://bugzilla.mozilla.org/show_bug.cgi?id=1433030. We can somehow try to make progress on that.https://gitlab.torproject.org/legacy/trac/-/issues/33960Uplift patch for "32414: Make Services.search.addEngine obey FPI"2020-06-16T01:12:40ZAlex CatarineuUplift patch for "32414: Make Services.search.addEngine obey FPI"Alex CatarineuAlex Catarineuhttps://gitlab.torproject.org/legacy/trac/-/issues/33954Consider different approach for "2176: Rebrand Firefox to TorBrowser "2020-06-16T01:12:39ZAlex CatarineuConsider different approach for "2176: Rebrand Firefox to TorBrowser "The current patch replaces all occurrences of `branding/brand.ftl` with `branding/tor-browser-brand.ftl`. This means that many files are touched by the patch (increasing chances of rebase conflict), and whenever Firefox adds new instance...The current patch replaces all occurrences of `branding/brand.ftl` with `branding/tor-browser-brand.ftl`. This means that many files are touched by the patch (increasing chances of rebase conflict), and whenever Firefox adds new instances of `branding/brand.ftl` we need to modify the patch to also cover those.
I think we should try a different approach to keep all instances of `branding/brand.ftl` untouched, and do the `branding/brand.ftl` -> `branding/tor-browser-brand.ftl` remapping somewhere else, and just in a single place.
One way would be to force the Fluent `FileSource` that we register in torbutton to take precedence over any other source and rename `tor-browser-brand.ftl` to `brand.ftl`, to override Firefox one (including langpacks).
We probably would need to do this in [L10nRegistry.js](https://searchfox.org/mozilla-central/rev/3446310d6cc5c85cde16a82eccf560e9b71a3d44/intl/l10n/L10nRegistry.jsm#141), but I would need to investigate a bit more.https://gitlab.torproject.org/legacy/trac/-/issues/32881Make script to optimize upload and download of Tor Browser releases2020-06-16T01:10:33ZboklmMake script to optimize upload and download of Tor Browser releasesGiven that bundles for each platform are 95% the same, except for the localization part, it might be possible to write a script that optimize the upload/download of a Tor Browser release, doing the following steps:
- upload/download the ...Given that bundles for each platform are 95% the same, except for the localization part, it might be possible to write a script that optimize the upload/download of a Tor Browser release, doing the following steps:
- upload/download the `en-US` bundles for all platforms
- copy the `en-US` bundle to the filenames of all the other locales
- use rsync to upload/download the part of the files that differ
If we find that such a script can improve upload/download time significantly, we should add it somewhere in the `tools/` directory.https://gitlab.torproject.org/legacy/trac/-/issues/31130Use Debian 10 for our Android container images2020-06-16T01:10:21ZGeorg KoppenUse Debian 10 for our Android container imagesWe should switch to Debian 10 for our Android builds.We should switch to Debian 10 for our Android builds.Shane IsbellShane Isbellhttps://gitlab.torproject.org/legacy/trac/-/issues/32119onboarding for "Goodbye Onion Button" could be better2020-06-16T01:08:31ZTaylor Yuonboarding for "Goodbye Onion Button" could be betterI recently upgraded to 9.0a8 and tried to follow the onboarding screens.
The "How to Request a New Identity" button seems to register the click and release, but not do anything obvious. Only after a while did I notice that the "broom" i...I recently upgraded to 9.0a8 and tried to follow the onboarding screens.
The "How to Request a New Identity" button seems to register the click and release, but not do anything obvious. Only after a while did I notice that the "broom" icon seemed to be outlined in pale turquoise and pulsing. (on macOS 10.12.6; on Linux it seems to be a slightly more visible pale turquoise with a non-pulsating but more visible turquoise border)
I think this is because the location of the "How to Request a New Identity" button is too far away from the actual browser toolbar, so maybe some more obvious animation or a doorhanger should be used?
Also the graphic on the right hand side of that onboarding screen seems to be missing a few elements from the toolbar, such as the bookmark star, the Security Level shield, and the search box. It's also not obvious to me what the onion icon in the yellow circle is supposed to represent.
For some reason, on Linux but not macOS, clicking on text in the onboarding screen activates a blinking vertical bar text insertion cursor (but doesn't allow editing text).Kathleen BradeKathleen Bradehttps://gitlab.torproject.org/legacy/trac/-/issues/31915Uplift libvpx/libaom patch for cpu-features.c2020-06-16T01:07:54ZMatthew FinkelUplift libvpx/libaom patch for cpu-features.c`cpu-features.c` from the Android NDK is included twice when webrtc is disabled.
https://searchfox.org/mozilla-central/source/media/libaom/moz.build#92
https://searchfox.org/mozilla-central/source/media/libvpx/moz.build#102
This result...`cpu-features.c` from the Android NDK is included twice when webrtc is disabled.
https://searchfox.org/mozilla-central/source/media/libaom/moz.build#92
https://searchfox.org/mozilla-central/source/media/libvpx/moz.build#102
This results in a build failure due to `multiple definitions`.
```
36:05.43 /home/android/.mozbuild/android-ndk-r15c/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: error: /home/andr
oid/tor-browser/obj-arm-linux-androideabi/toolkit/library/../../media/libaom/cpu-features.o: multiple definition of 'android_getCpuCount'
36:05.43 /home/android/.mozbuild/android-ndk-r15c/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: /home/android/tor
-browser/obj-arm-linux-androideabi/toolkit/library/../../media/libvpx/cpu-features.o: previous definition here
36:05.43 /home/android/.mozbuild/android-ndk-r15c/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: error: /home/and$
oid/tor-browser/obj-arm-linux-androideabi/toolkit/library/../../media/libaom/cpu-features.o: multiple definition of 'android_getCpuFamily'
36:05.43 /home/android/.mozbuild/android-ndk-r15c/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: /home/android/tor
-browser/obj-arm-linux-androideabi/toolkit/library/../../media/libvpx/cpu-features.o: previous definition here
36:05.43 /home/android/.mozbuild/android-ndk-r15c/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: error: /home/andr
oid/tor-browser/obj-arm-linux-androideabi/toolkit/library/../../media/libaom/cpu-features.o: multiple definition of 'android_getCpuFeatures'
36:05.44 /home/android/.mozbuild/android-ndk-r15c/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: /home/android/tor
-browser/obj-arm-linux-androideabi/toolkit/library/../../media/libvpx/cpu-features.o: previous definition here
```Matthew FinkelMatthew Finkel