Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2020-06-15T23:41:50Zhttps://gitlab.torproject.org/legacy/trac/-/issues/21755Restrict third party cookies and other tracking data is unchecked in ESR52 ba...2020-06-15T23:41:50ZGeorg KoppenRestrict third party cookies and other tracking data is unchecked in ESR52 based Tor BrowserOur first party isolation patches are activated right now (ESR 45 based Tor Browser) if the checkbox "Restrict third party cookies and other tracking data" is checked. But that's not the case anymore with an ESR 52 base. We should fix th...Our first party isolation patches are activated right now (ESR 45 based Tor Browser) if the checkbox "Restrict third party cookies and other tracking data" is checked. But that's not the case anymore with an ESR 52 base. We should fix that or remove that checkbox altogether.
It might be a sign, though, that some of our first-party isolation code is not working. We should doublecheck that that's not the casehttps://gitlab.torproject.org/legacy/trac/-/issues/21655Adding a script to clean old built components2020-06-15T23:41:28ZboklmAdding a script to clean old built componentsWe should have a script to clean old build files from the `out/` directory, while keeping the ones that are still used in the current builds.
We can take the `tools/clean-old` script from tor-messenger-build, and adapt it.
Having an op...We should have a script to clean old build files from the `out/` directory, while keeping the ones that are still used in the current builds.
We can take the `tools/clean-old` script from tor-messenger-build, and adapt it.
Having an option to keep the build files used by different git branches (for instance the stable and alpha branches) and not just the current branch would also be useful.boklmboklmhttps://gitlab.torproject.org/legacy/trac/-/issues/21201Adapt torbutton to TBB/FF52ESR2020-06-15T23:40:26ZArthur EdelsteinAdapt torbutton to TBB/FF52ESRVarious changes to torbutton will need to be made to work properly with the Firefox 52 ESR-based Tor Browser.Various changes to torbutton will need to be made to work properly with the Firefox 52 ESR-based Tor Browser.https://gitlab.torproject.org/legacy/trac/-/issues/20949In some cases, the testsuite is not run automatically on new versions after t...2020-06-13T17:40:54ZboklmIn some cases, the testsuite is not run automatically on new versions after they are uploaded to people.tpoWhen one Tor Browser builder uploaded a new Tor Browser version to people.tpo, but an other uploaded the sha256sums files for this version without the binaries or with an invalid signature, the testsuite is not run.When one Tor Browser builder uploaded a new Tor Browser version to people.tpo, but an other uploaded the sha256sums files for this version without the binaries or with an invalid signature, the testsuite is not run.boklmboklmhttps://gitlab.torproject.org/legacy/trac/-/issues/17662Have a test to check that Tor Browser updater is working2020-06-13T17:40:44ZboklmHave a test to check that Tor Browser updater is workingWe should have a test to check that the Tor Browser updater is not broken and will be able to update the browser to futur releases when they are available. This test would help when making updater changes such as #17442.
Mozilla has som...We should have a test to check that the Tor Browser updater is not broken and will be able to update the browser to futur releases when they are available. This test would help when making updater changes such as #17442.
Mozilla has some marionette tests that we can use for that:
https://github.com/mozilla/firefox-ui-tests/blob/mozilla-central/firefox_ui_tests/update/direct/test_direct_update.py
https://github.com/mozilla/firefox-ui-tests/blob/mozilla-central/firefox_ui_tests/update/fallback/test_fallback_update.py
Those tests take as arguments a channel name, a target version (the expected version after the update is installed), a target buildid.
Mozilla QA team is posting on their wiki the config file they use when testing each new release:
https://wiki.mozilla.org/QA/Desktop_Firefox/Releases/Configs/Fx42RC2
Using this config they are testing that previous releases can be updated to the new release, but I could not find tests to check if the new release has a working updater that will be able to update to a futur release.
To be able to check that the updater can update to an other release, I think we could create a "test-updater" channel, which provides a signed mar file with a large version number, so that the updater always accept this update. However the problem would be that an adversary can use this mar file to update users to an old browser. Maybe we can include a non-working browser in the mar file to avoid this, but this is still not very good.
An alternative could be to have a "test-updater" channel which provides an old version, and patch our updater to have a preference that allows downgrades. We can then set this preference when testing the updater on this channel.