Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2020-06-13T16:58:35Zhttps://gitlab.torproject.org/legacy/trac/-/issues/31350test the locales for Android with a githook after updating from transifex2020-06-13T16:58:35Zemmapeeltest the locales for Android with a githook after updating from transifexWe need to test the correct escaping of the files at https://git.torproject.org/translation.git on the branch tba-torbrowserstringsdtd (only on that branch!)
The files on that branch are used to localize the Android client of the Tor Br...We need to test the correct escaping of the files at https://git.torproject.org/translation.git on the branch tba-torbrowserstringsdtd (only on that branch!)
The files on that branch are used to localize the Android client of the Tor Browser and don't comply with the standards for dtd files. Thus, we need to check on them after updates come from transifex, and before we attempt to build.
Ideally we can produce a list of the corrections, so we can update it on the transifex platform and slowly weed out the errors.
We could reuse this githook for other components eventually, so it would be nice to have some sort of reusable parts:
* import last translations from transifex
* run something
* upload results to transifex?
* mail or submit results somehow
The script that we can use as a base is at https://trac.torproject.org/projects/tor/ticket/30054#comment:9
the rules at https://developer.android.com/guide/topics/resources/string-resource#FormattingAndStyling may not be all needed, as for example it can be that ' does not break the build.https://gitlab.torproject.org/legacy/trac/-/issues/30341tbb-testsuite: fix the screenshots test2020-06-13T17:41:24Zboklmtbb-testsuite: fix the screenshots testThe screenshots test is currently failing with the error:
```
Traceback (most recent call last):
File "/home/tbb-testsuite/tbb-testsuite/virtualenv-marionette-4.3.0/local/lib/python2.7/site-packages/marionette_harness-4.3.0-py2.7.egg/mar...The screenshots test is currently failing with the error:
```
Traceback (most recent call last):
File "/home/tbb-testsuite/tbb-testsuite/virtualenv-marionette-4.3.0/local/lib/python2.7/site-packages/marionette_harness-4.3.0-py2.7.egg/marionette_harness/marionette_test/testcases.py", line 156, in run
testMethod()
File "/home/tbb-testsuite/tbb-testsuite/marionette/tor_browser_tests/test_screenshots.py", line 27, in test_check_tpo
marionette.navigate(url)
File "/home/tbb-testsuite/tbb-testsuite/virtualenv-marionette-4.3.0/local/lib/python2.7/site-packages/marionette_driver-2.5.0-py2.7.egg/marionette_driver/marionette.py", line 1632, in navigate
self._send_message("get", {"url": url})
File "/home/tbb-testsuite/tbb-testsuite/virtualenv-marionette-4.3.0/local/lib/python2.7/site-packages/marionette_driver-2.5.0-py2.7.egg/marionette_driver/decorators.py", line 23, in _
return func(*args, **kwargs)
File "/home/tbb-testsuite/tbb-testsuite/virtualenv-marionette-4.3.0/local/lib/python2.7/site-packages/marionette_driver-2.5.0-py2.7.egg/marionette_driver/marionette.py", line 740, in _send_message
self._handle_error(err)
File "/home/tbb-testsuite/tbb-testsuite/virtualenv-marionette-4.3.0/local/lib/python2.7/site-packages/marionette_driver-2.5.0-py2.7.egg/marionette_driver/marionette.py", line 764, in _handle_error
raise errors.lookup(error)(message, stacktrace=stacktrace)
UnknownException: Reached error page: about:neterror?e=fileNotFound&u=chrome%3A//torbutton/content/preferences.xul&c=UTF-8&f=regular&d=Die%20Dateien%20unter%20chrome%3A//torbutton/content/preferences.xul%20konnten%20nicht%20gefunden%20werden.
stacktrace:
WebDriverError@chrome://marionette/content/error.js:178:5
UnknownError@chrome://marionette/content/error.js:529:5
handleReadyState@chrome://marionette/content/listener.js:277:21
handleEvent@chrome://marionette/content/listener.js:245:9
```cypherpunkscypherpunkshttps://gitlab.torproject.org/legacy/trac/-/issues/30340tbb-testsuite: fix the searchengines test2020-06-13T17:41:23Zboklmtbb-testsuite: fix the searchengines testThe searchengines test is currently failing with the error:
```
Traceback (most recent call last):
File "/home/tbb-testsuite/tbb-testsuite/virtualenv-marionette-4.3.0/local/lib/python2.7/site-packages/marionette_harness-4.3.0-py2.7.egg/m...The searchengines test is currently failing with the error:
```
Traceback (most recent call last):
File "/home/tbb-testsuite/tbb-testsuite/virtualenv-marionette-4.3.0/local/lib/python2.7/site-packages/marionette_harness-4.3.0-py2.7.egg/marionette_harness/marionette_test/testcases.py", line 156, in run
testMethod()
File "/home/tbb-testsuite/tbb-testsuite/marionette/tor_browser_tests/test_searchengines.py", line 25, in test_searchengines
self.marionette.navigate('about:')
File "/home/tbb-testsuite/tbb-testsuite/virtualenv-marionette-4.3.0/local/lib/python2.7/site-packages/marionette_driver-2.5.0-py2.7.egg/marionette_driver/marionette.py", line 1632, in navigate
self._send_message("get", {"url": url})
File "/home/tbb-testsuite/tbb-testsuite/virtualenv-marionette-4.3.0/local/lib/python2.7/site-packages/marionette_driver-2.5.0-py2.7.egg/marionette_driver/decorators.py", line 23, in _
return func(*args, **kwargs)
File "/home/tbb-testsuite/tbb-testsuite/virtualenv-marionette-4.3.0/local/lib/python2.7/site-packages/marionette_driver-2.5.0-py2.7.egg/marionette_driver/marionette.py", line 740, in _send_message
self._handle_error(err)
File "/home/tbb-testsuite/tbb-testsuite/virtualenv-marionette-4.3.0/local/lib/python2.7/site-packages/marionette_driver-2.5.0-py2.7.egg/marionette_driver/marionette.py", line 764, in _handle_error
raise errors.lookup(error)(message, stacktrace=stacktrace)
UnknownException: [Exception... "The URI is malformed" nsresult: "0x804b000a (NS_ERROR_MALFORMED_URI)" location: "JS frame :: chrome://marionette/content/listener.js :: get/< :: line 1053" data: no]
stacktrace:
get/<@chrome://marionette/content/listener.js:1053:7
navigate/<@chrome://marionette/content/listener.js:415:13
navigate@chrome://marionette/content/listener.js:414:13
get@chrome://marionette/content/listener.js:1052:5
```https://gitlab.torproject.org/legacy/trac/-/issues/30339tbb-testsuite: fix the play_videos test2020-06-13T17:41:23Zboklmtbb-testsuite: fix the play_videos testThe play_videos test currently fails with:
```
Traceback (most recent call last):
File "/home/tbb-testsuite/tbb-testsuite/virtualenv-marionette-4.3.0/local/lib/python2.7/site-packages/marionette_harness-4.3.0-py2.7.egg/marionette_harness...The play_videos test currently fails with:
```
Traceback (most recent call last):
File "/home/tbb-testsuite/tbb-testsuite/virtualenv-marionette-4.3.0/local/lib/python2.7/site-packages/marionette_harness-4.3.0-py2.7.egg/marionette_harness/marionette_test/testcases.py", line 156, in run
testMethod()
File "/home/tbb-testsuite/tbb-testsuite/marionette/tor_browser_tests/test_page.py", line 32, in test_page
elt = self.marionette.find_element('id', 'test_result');
File "/home/tbb-testsuite/tbb-testsuite/virtualenv-marionette-4.3.0/local/lib/python2.7/site-packages/marionette_driver-2.5.0-py2.7.egg/marionette_driver/marionette.py", line 1852, in find_element
return self._send_message("findElement", body, key="value")
File "/home/tbb-testsuite/tbb-testsuite/virtualenv-marionette-4.3.0/local/lib/python2.7/site-packages/marionette_driver-2.5.0-py2.7.egg/marionette_driver/decorators.py", line 23, in _
return func(*args, **kwargs)
File "/home/tbb-testsuite/tbb-testsuite/virtualenv-marionette-4.3.0/local/lib/python2.7/site-packages/marionette_driver-2.5.0-py2.7.egg/marionette_driver/marionette.py", line 740, in _send_message
self._handle_error(err)
File "/home/tbb-testsuite/tbb-testsuite/virtualenv-marionette-4.3.0/local/lib/python2.7/site-packages/marionette_driver-2.5.0-py2.7.egg/marionette_driver/marionette.py", line 764, in _handle_error
raise errors.lookup(error)(message, stacktrace=stacktrace)
NoSuchElementException: Unable to locate element: test_result
stacktrace:
WebDriverError@chrome://marionette/content/error.js:178:5
NoSuchElementError@chrome://marionette/content/error.js:434:5
element.find/</<@chrome://marionette/content/element.js:341:16
```https://gitlab.torproject.org/legacy/trac/-/issues/30338Create a tor-onion-proxy-library repository2020-06-13T16:57:35ZGeorg KoppenCreate a tor-onion-proxy-library repositoryPlease create a /tor-onion-proxy-library repository. Read access for everyone, write access for sisbell, sysrqb, and gk.
Description: Library to embed Tor into Java/Android programs.Please create a /tor-onion-proxy-library repository. Read access for everyone, write access for sisbell, sysrqb, and gk.
Description: Library to embed Tor into Java/Android programs.https://gitlab.torproject.org/legacy/trac/-/issues/30337Create a tor-android-service repository2020-06-13T16:57:35ZGeorg KoppenCreate a tor-android-service repositoryPlease create a /tor-android-service repository. Read access for everyone, oush access for sisbell, sysrqb, gk.
Description: "Android Service For Installing and Running Tor"Please create a /tor-android-service repository. Read access for everyone, oush access for sisbell, sysrqb, gk.
Description: "Android Service For Installing and Running Tor"https://gitlab.torproject.org/legacy/trac/-/issues/30333tbb-testsuite: fix the download_pdf test2020-06-13T17:41:22Zboklmtbb-testsuite: fix the download_pdf testThe `download_pdf` test currently fails with the error:
```
Traceback (most recent call last):
File "/home/tbb-testsuite/tbb-testsuite/virtualenv-marionette-4.3.0/local/lib/python2.7/site-packages/marionette_harness-4.3.0-py2.7.egg/mario...The `download_pdf` test currently fails with the error:
```
Traceback (most recent call last):
File "/home/tbb-testsuite/tbb-testsuite/virtualenv-marionette-4.3.0/local/lib/python2.7/site-packages/marionette_harness-4.3.0-py2.7.egg/marionette_harness/marionette_test/testcases.py", line 156, in run
testMethod()
File "/home/tbb-testsuite/tbb-testsuite/marionette/tor_browser_tests/test_download_pdf.py", line 24, in test_download_pdf
m.set_window_size(1024, 300)
File "/home/tbb-testsuite/tbb-testsuite/virtualenv-marionette-4.3.0/local/lib/python2.7/site-packages/marionette_driver-2.5.0-py2.7.egg/marionette_driver/marionette.py", line 2063, in set_window_size
return self._send_message("setWindowSize", body)
File "/home/tbb-testsuite/tbb-testsuite/virtualenv-marionette-4.3.0/local/lib/python2.7/site-packages/marionette_driver-2.5.0-py2.7.egg/marionette_driver/decorators.py", line 23, in _
return func(*args, **kwargs)
File "/home/tbb-testsuite/tbb-testsuite/virtualenv-marionette-4.3.0/local/lib/python2.7/site-packages/marionette_driver-2.5.0-py2.7.egg/marionette_driver/marionette.py", line 740, in _send_message
self._handle_error(err)
File "/home/tbb-testsuite/tbb-testsuite/virtualenv-marionette-4.3.0/local/lib/python2.7/site-packages/marionette_driver-2.5.0-py2.7.egg/marionette_driver/marionette.py", line 764, in _handle_error
raise errors.lookup(error)(message, stacktrace=stacktrace)
UnknownCommandException: setWindowSize
stacktrace:
WebDriverError@chrome://marionette/content/error.js:178:5
UnknownCommandError@chrome://marionette/content/error.js:518:5
despatch@chrome://marionette/content/server.js:286:13
execute@chrome://marionette/content/server.js:267:11
onPacket/<@chrome://marionette/content/server.js:242:15
onPacket@chrome://marionette/content/server.js:241:8
_onJSONObjectReady/<@chrome://marionette/content/transport.js:500:9
```cypherpunkscypherpunkshttps://gitlab.torproject.org/legacy/trac/-/issues/30326Remove yasm from the list of dependencies for the firefox android build2020-06-16T01:03:02ZboklmRemove yasm from the list of dependencies for the firefox android buildWhile testing the changes from #29981, gk found that yasm is not needed to build firefox for android. We should remove it from the list of dependencies we need to build firefox on all platforms, and only install it for the linux, windows...While testing the changes from #29981, gk found that yasm is not needed to build firefox for android. We should remove it from the list of dependencies we need to build firefox on all platforms, and only install it for the linux, windows and osx builds.https://gitlab.torproject.org/legacy/trac/-/issues/30270Use Ndk.abiFilters to include native dependencies2020-06-16T01:02:47ZShane IsbellUse Ndk.abiFilters to include native dependenciesndk.abiFilters should be used to manage what dependencies are included in the apk. This would be added to the gradle build file of firefox.ndk.abiFilters should be used to manage what dependencies are included in the apk. This would be added to the gradle build file of firefox.https://gitlab.torproject.org/legacy/trac/-/issues/30132Tor Browser on Android start-up breaks due to NullPointerException2020-06-16T01:02:29ZGeorg KoppenTor Browser on Android start-up breaks due to NullPointerExceptionWhile luckily not easily triggerable, there is a way that start-up bootstrapping is broken due to a `NullPointerException` that gets thrown. For steps to repro see comment:61:ticket:28329.While luckily not easily triggerable, there is a way that start-up bootstrapping is broken due to a `NullPointerException` that gets thrown. For steps to repro see comment:61:ticket:28329.https://gitlab.torproject.org/legacy/trac/-/issues/30131Disabling/enabling bridge-switch is jumping/not correctly behaving2020-06-16T01:02:29ZGeorg KoppenDisabling/enabling bridge-switch is jumping/not correctly behavingIf one wants to enable/disable bridges (after tapping the gear icon) one can see the switch jumping (probably due to the text changes). It should stay the same in height and width, though, and just the text should change if needed. I see...If one wants to enable/disable bridges (after tapping the gear icon) one can see the switch jumping (probably due to the text changes). It should stay the same in height and width, though, and just the text should change if needed. I seems to only happening before one once selected a bridge. Very strange
Moreover, if one is not tapping the switch but dragging it, then just the switch gets on the "on" position but nothing happens.https://gitlab.torproject.org/legacy/trac/-/issues/30129Add a spinning onion as animation during bootstrap2020-06-16T01:02:28ZGeorg KoppenAdd a spinning onion as animation during bootstrapWe tried hard to add a spinning onion as bootstrap animation in #28329 but failed there. Still, it would be neat to have it as eye candy for 8.5.We tried hard to add a spinning onion as bootstrap animation in #28329 but failed there. Still, it would be neat to have it as eye candy for 8.5.https://gitlab.torproject.org/legacy/trac/-/issues/30118var/build_id should be stable accross build machines2020-06-16T01:25:32Zboklmvar/build_id should be stable accross build machinesThe `var/build_id` value, which is included in filenames, is a hash of all the inputs used to create a build.
In theory this hash should be the same on different build machines. However it seems it is not always the case, at least for t...The `var/build_id` value, which is included in filenames, is a hash of all the inputs used to create a build.
In theory this hash should be the same on different build machines. However it seems it is not always the case, at least for the android build, and we should find why.
This command can be used to see the filename of Tor Browser alpha for android-armv7:
```
./rbm/rbm showconf tor-browser filename --target alpha --target torbrowser-android-armv7
```https://gitlab.torproject.org/legacy/trac/-/issues/30086Tor Browser for Android: Sync Sign-In Button crashes2020-06-16T01:02:17ZcypherpunksTor Browser for Android: Sync Sign-In Button crashesSteps to reproduce:
1. goto browsing history: Press "synced devices 0 devices"
2. Press Sync Sign-In Button and it crashes Tor Browser instantly.Steps to reproduce:
1. goto browsing history: Press "synced devices 0 devices"
2. Press Sync Sign-In Button and it crashes Tor Browser instantly.https://gitlab.torproject.org/legacy/trac/-/issues/30054Special characters are not escaped in translations and break the build2021-02-24T15:09:53ZGeorg KoppenSpecial characters are not escaped in translations and break the buildAs said in comment:14:ticket:27125 there are special characters (like the `'`) that need to get escaped in strings, otherwise the build breaks. While we did that in `en-US` that does not happen in translations (yet).As said in comment:14:ticket:27125 there are special characters (like the `'`) that need to get escaped in strings, otherwise the build breaks. While we did that in `en-US` that does not happen in translations (yet).emmapeelemmapeelhttps://gitlab.torproject.org/legacy/trac/-/issues/29973Remove remaining stopOpenSecuritySettingsObserver() pieces2020-06-16T01:02:01ZGeorg KoppenRemove remaining stopOpenSecuritySettingsObserver() pieces`stopOpenSecuritySettingsObserver()` is not needed anymore with the changes in #25658. However, there are some pieces left of it that result in a browser console error. Noted on our blog: https://blog.torproject.org/comment/280343#commen...`stopOpenSecuritySettingsObserver()` is not needed anymore with the changes in #25658. However, there are some pieces left of it that result in a browser console error. Noted on our blog: https://blog.torproject.org/comment/280343#comment-280343https://gitlab.torproject.org/legacy/trac/-/issues/29906Tor for Android stops working immediately on app start2020-06-16T01:01:52ZTracTor for Android stops working immediately on app startOn brand new Android KitKat (2017 update) with Orfox also running (cannot close orfox yet for tabs I still need to read).
Steps:
Have Orfox running with 3 or 4 tabs.
Install Tor Browser for Android (Alpha) (release from 4 days ago) via ...On brand new Android KitKat (2017 update) with Orfox also running (cannot close orfox yet for tabs I still need to read).
Steps:
Have Orfox running with 3 or 4 tabs.
Install Tor Browser for Android (Alpha) (release from 4 days ago) via F-Droid.
Click the icon to load the app, then
White screen for one second then black screen for a tenth of a second, then Error dialog message pops up: " Unfortunately Tor Browser for Android (Alpha) has stopped working"
Note: Orfox still works fine.
Ideally I'd be able to run both TB and Orfox at the same time? One would be a different identity to the other?
**Trac**:
**Username**: torloveMatthew FinkelMatthew Finkelhttps://gitlab.torproject.org/legacy/trac/-/issues/29858Tor Browser for Android 8.5a9 does not show onboarding anymore on first start2020-06-16T01:01:45ZGeorg KoppenTor Browser for Android 8.5a9 does not show onboarding anymore on first startIf you take a clean, new 8.5a9 on your Android phone you'll be greeted with the `about:tor` page after bootstrapping but not the onboarding anymore. I'll assume this happened due to our work on #28329. Marking this ticket therefore as a ...If you take a clean, new 8.5a9 on your Android phone you'll be greeted with the `about:tor` page after bootstrapping but not the onboarding anymore. I'll assume this happened due to our work on #28329. Marking this ticket therefore as a blocker for that bug.https://gitlab.torproject.org/legacy/trac/-/issues/29759Add --enable-proxy-bypass-protection to mozconfig2020-06-16T01:01:32ZboklmAdd --enable-proxy-bypass-protection to mozconfighttps://bugzilla.mozilla.org/show_bug.cgi?id=1433357 added the `--enable-proxy-bypass-protection` configure flag.
However it seems we don't set it in our mozconfig files.https://bugzilla.mozilla.org/show_bug.cgi?id=1433357 added the `--enable-proxy-bypass-protection` configure flag.
However it seems we don't set it in our mozconfig files.https://gitlab.torproject.org/legacy/trac/-/issues/29246WebGL is sometimes blocked outright instead of put behind a click-to-play pla...2020-06-16T01:00:38ZGeorg KoppenWebGL is sometimes blocked outright instead of put behind a click-to-play placeholderIn #21805 we put WebGL behind a placeholder with the help of NoScript. This works well e.g. for http://webglsamples.org/aquarium/aquarium.html. However other sites report just that WebGL is not supported and it therefore gets blocked out...In #21805 we put WebGL behind a placeholder with the help of NoScript. This works well e.g. for http://webglsamples.org/aquarium/aquarium.html. However other sites report just that WebGL is not supported and it therefore gets blocked outright:
https://demo.marpi.pl/biomes/
Giorgio, you mentioned in comment:5:ticket:21805 that this worked correctly with NoScript 10.1.8.2. Is that a regression on NoScript's side or an issue with WebGL detection on the website?