Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2020-06-16T01:06:50Zhttps://gitlab.torproject.org/legacy/trac/-/issues/31547Back out or modify patches for Mozilla's bug 15749802020-06-16T01:06:50ZGeorg KoppenBack out or modify patches for Mozilla's bug 1574980The patches for bug 1574980 fix a security flaw in dealing with the maintenance service on Windows. We don't use that one, so we should be not affected. However, the way the fix was written is that it drags maintenance service related co...The patches for bug 1574980 fix a security flaw in dealing with the maintenance service on Windows. We don't use that one, so we should be not affected. However, the way the fix was written is that it drags maintenance service related code into the general updater code: we build that now, too, which was not the case before. We don't want and need that and should either back out the whole patches (both for esr60 and esr68) or come up with a better solution.
I guess due to time constraints we follow the former idea and try to write better patches later on (and get those upstreamed).https://gitlab.torproject.org/legacy/trac/-/issues/31389Update Android Firefox to Build with Clang2020-06-16T01:06:27ZShane IsbellUpdate Android Firefox to Build with Clanghttps://gitlab.torproject.org/legacy/trac/-/issues/31388Update Rust Project for Android2020-06-16T01:06:26ZShane IsbellUpdate Rust Project for AndroidUpdate Rust Project for Android config optionsUpdate Rust Project for Android config optionshttps://gitlab.torproject.org/legacy/trac/-/issues/30490Add cbindgen project for building Firefox 68 ESR2020-06-16T01:25:41ZGeorg KoppenAdd cbindgen project for building Firefox 68 ESRWe need to provide `cbindgen` for compiling Firefox. Right now it looks like we want to use 0.8.6, but actually whatever makes it into ESR 68.We need to provide `cbindgen` for compiling Firefox. Right now it looks like we want to use 0.8.6, but actually whatever makes it into ESR 68.https://gitlab.torproject.org/legacy/trac/-/issues/30323Adapt macOS toolchain for Firefox 68 ESR2020-06-16T01:25:38ZGeorg KoppenAdapt macOS toolchain for Firefox 68 ESRThis is the (parent) ticket for adapting our toolchain for macOS bundles
built from Firefox 68 ESR.This is the (parent) ticket for adapting our toolchain for macOS bundles
built from Firefox 68 ESR.https://gitlab.torproject.org/legacy/trac/-/issues/29818adapt #13379 patch for 68esr2020-06-16T01:01:41ZMark Smithadapt #13379 patch for 68esrIn https://bugzilla.mozilla.org/show_bug.cgi?id=1434033, Mozilla removed the use of LD_LIBRARY_PATH (which is used in non-macOS and non-Windows Firefox to ensure that the updater can locate NSS related shared libraries). Instead, the Fir...In https://bugzilla.mozilla.org/show_bug.cgi?id=1434033, Mozilla removed the use of LD_LIBRARY_PATH (which is used in non-macOS and non-Windows Firefox to ensure that the updater can locate NSS related shared libraries). Instead, the Firefox build now adds `-rpath=$ORIGIN` in `LDFLAGS`.
For Tor Browser, we need a similar solution for Windows and macOS because we define MAR_NSS on all platforms (we define MAR_NSS so that we use NSS for MAR-related crypto on all platforms rather than relying on OS-provided libraries). Therefore, we will need to adapt our #13379 patch to account for Mozilla's change.
Current (Tor Browser 8.5a9) patch:
https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-browser-60.6.0esr-8.5-1&id=c17b8a3fbcd19230706f295a00ce955c1bcf90b9
Related Firefox bugs:
https://bugzilla.mozilla.org/show_bug.cgi?id=1434033
https://bugzilla.mozilla.org/show_bug.cgi?id=1434666https://gitlab.torproject.org/legacy/trac/-/issues/29757TBA: Delete Orbot Providers2020-06-16T01:04:01ZMatthew FinkelTBA: Delete Orbot ProvidersOrbot (and OrbotService specifically) implement three Android app Providers:
- HSContentProvider
- FileProvider
- CookieContentProvider
These are used by Orbot's onion service subsystem where the user can run a service from their ...Orbot (and OrbotService specifically) implement three Android app Providers:
- HSContentProvider
- FileProvider
- CookieContentProvider
These are used by Orbot's onion service subsystem where the user can run a service from their device or store an auth cookie associated with an onion service.
We do not need these at this moment and we don't have plans for exposing a UI for these, and the existance of these prevents installing multiple versions of TBA (using different package names) because the Provider names collide. We can safely delete these from the service's manifest and TorService class.https://gitlab.torproject.org/legacy/trac/-/issues/28753Use Gradle with --offline when building the browser part2020-06-16T00:59:14ZGeorg KoppenUse Gradle with --offline when building the browser partboklm noticed in comment:23:ticket:27977 that we are using Gradle's `--offline` mode for building Orbot which fails hard if the dependencies are not available (at least it seems so; I have not checked). Furthermore, he suggested we use t...boklm noticed in comment:23:ticket:27977 that we are using Gradle's `--offline` mode for building Orbot which fails hard if the dependencies are not available (at least it seems so; I have not checked). Furthermore, he suggested we use that mode as well for the Firefox build part. This seems like a good defense in depth given bugs like #28752.https://gitlab.torproject.org/legacy/trac/-/issues/28561Migrate custom 'About Tor Browser' dialog from torbutton to tor-browser branding2020-06-16T00:53:05ZrichardMigrate custom 'About Tor Browser' dialog from torbutton to tor-browser brandingAs part of branding update change in #25702, the Tor Browser icon referenced in the About Tor Browser XUL dialog was changed to one packaged in tor-browser (since torbutton does not know whether it's stable, alpha or nightly).
The entir...As part of branding update change in #25702, the Tor Browser icon referenced in the About Tor Browser XUL dialog was changed to one packaged in tor-browser (since torbutton does not know whether it's stable, alpha or nightly).
The entire dialog should be moved to tor-browser rather than having cross-referenced content. As part of this, also change the 'Tor Browser' text from an image to just text.richardrichardhttps://gitlab.torproject.org/legacy/trac/-/issues/26782TBA: Translation/Localization Support2020-06-16T00:48:24ZMatthew FinkelTBA: Translation/Localization SupportWe need a method for supporting translations in TBA. I don't have a good answer for this, so we should investigate our options and compare/contrast the usefulness of each.
Emma pointed me at [[https://fastlane.tools/|Fastlane]] which se...We need a method for supporting translations in TBA. I don't have a good answer for this, so we should investigate our options and compare/contrast the usefulness of each.
Emma pointed me at [[https://fastlane.tools/|Fastlane]] which seems like a nice option and it will handle integrating translations and taking screenshots using them - but is seems like translations isn't a core feature of that project. Maybe it's good enough?https://gitlab.torproject.org/legacy/trac/-/issues/25856Remove XUL overlays from Torbutton2020-06-16T00:45:41ZcypherpunksRemove XUL overlays from TorbuttonXUL overlays (and XUL itself, actually) have been discouraged for years, and are already being removed outright from Firefox:
https://bugzilla.mozilla.org/show_bug.cgi?id=1426763
https://bugzilla.mozilla.org/show_bug.cgi?id=1448162
http...XUL overlays (and XUL itself, actually) have been discouraged for years, and are already being removed outright from Firefox:
https://bugzilla.mozilla.org/show_bug.cgi?id=1426763
https://bugzilla.mozilla.org/show_bug.cgi?id=1448162
https://bugzilla.mozilla.org/show_bug.cgi?id=1449791
https://bugzilla.mozilla.org/show_bug.cgi?id=1450753https://gitlab.torproject.org/legacy/trac/-/issues/21404Run the Tor Browser testsuite on rbm based nightly builds2020-06-13T17:40:56ZboklmRun the Tor Browser testsuite on rbm based nightly buildsIn #21286 some nightly builds have been added. We should run the testsuite on those nightly builds.In #21286 some nightly builds have been added. We should run the testsuite on those nightly builds.https://gitlab.torproject.org/legacy/trac/-/issues/12968Specify HEASLR (High Entropy Address Space Layout Randomization) in MinGW-w642020-06-16T01:24:37ZMike PerrySpecify HEASLR (High Entropy Address Space Layout Randomization) in MinGW-w64Mozilla patched mingw-w64 to allow the specification of "high-entropy" ASLR, which is an extra hardened ASLR option on Windows. Not sure if this flag only applies to 64bit builds. I think it might.
Here's their ticket:
https://github.co...Mozilla patched mingw-w64 to allow the specification of "high-entropy" ASLR, which is an extra hardened ASLR option on Windows. Not sure if this flag only applies to 64bit builds. I think it might.
Here's their ticket:
https://github.com/rust-lang/rust/issues/16593
and the patch:
https://sourceware.org/ml/binutils/2014-08/msg00167.html
and it's approval by the Binutils team:
https://sourceware.org/ml/binutils/2014-08/msg00177.html