Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2020-06-16T01:25:43Zhttps://gitlab.torproject.org/legacy/trac/-/issues/31584Clean up mingw-w64 project2020-06-16T01:25:43ZGeorg KoppenClean up mingw-w64 projectWe switched to `mingw-w64-clang` for the Firefox project and should now clean up the mingw-w64 as it still contains cruft related to our spec hack etc.We switched to `mingw-w64-clang` for the Firefox project and should now clean up the mingw-w64 as it still contains cruft related to our spec hack etc.https://gitlab.torproject.org/legacy/trac/-/issues/31457disable per-installation profiles2020-06-16T01:12:06ZMark Smithdisable per-installation profilesFirefox ESR68 includes installation-specific profiles. See: https://bugzilla.mozilla.org/show_bug.cgi?id=1474285
With our current nightly builds, this causes an extra profile directory to be created and used (and probably our bundled br...Firefox ESR68 includes installation-specific profiles. See: https://bugzilla.mozilla.org/show_bug.cgi?id=1474285
With our current nightly builds, this causes an extra profile directory to be created and used (and probably our bundled browser profile is not be used on Linux and Windows).
We should figure out how to disable this feature or modify it to be compatible with the way we crate and use browser profiles).https://gitlab.torproject.org/legacy/trac/-/issues/26345Disable tracking protection UI in FF67-esr2020-06-16T01:09:11ZcypherpunksDisable tracking protection UI in FF67-esrSome of its parts are already live and well in Nightly (such as the Tracking Protection switch in the hamburger menu). This makes it particularly devastating since more users may be tempted to enable it thereby harming their fingerprinti...Some of its parts are already live and well in Nightly (such as the Tracking Protection switch in the hamburger menu). This makes it particularly devastating since more users may be tempted to enable it thereby harming their fingerprinting.
https://bugzilla.mozilla.org/show_bug.cgi?id=1461743
https://www.ghacks.net/2018/06/10/mozilla-plans-to-push-tracking-protection-in-firefox/https://gitlab.torproject.org/legacy/trac/-/issues/31575Firefox is phoning home during start-up in Tor Browser based on ESR 682020-06-16T01:08:07ZGeorg KoppenFirefox is phoning home during start-up in Tor Browser based on ESR 68Starting up one can see a bunch of requests going to Mozilla owned domains:
```
https://firefox.settings.services.mozilla.com/v1/buckets/monitor/collections/changes/records?collection=cfr-fxa&bucket=main
https://firefox.settings.services...Starting up one can see a bunch of requests going to Mozilla owned domains:
```
https://firefox.settings.services.mozilla.com/v1/buckets/monitor/collections/changes/records?collection=cfr-fxa&bucket=main
https://firefox.settings.services.mozilla.com/v1/buckets/main/collections/cfr-fxa?_expected=1562598365297
https://firefox.settings.services.mozilla.com/v1/buckets/main/collections/cfr-fxa/records?_expected=1562598365297&_sort=-last_modified
https://content-signature-2.cdn.mozilla.net/chains/remote-settings.content-signature.mozilla.org-2019-10-02-18-15-08.chain
https://snippets.cdn.mozilla.net/us-west/bundles/bundle_8afc759e26e7da7a6283552f250fdf0a5602f4f3.json
```
We should figure out what we should do with those requests/underlying functionality.https://gitlab.torproject.org/legacy/trac/-/issues/31880Disabling EME per configure option does not work on mobile anymore2020-06-16T01:07:47ZGeorg KoppenDisabling EME per configure option does not work on mobile anymoreWhile updating the mozconfig files for Android it turns out that `ac_add_option --disable-eme` does not work anymore.
We should investigate whether there is a suitable replacement and what the EME situation on Android is to make sure we...While updating the mozconfig files for Android it turns out that `ac_add_option --disable-eme` does not work anymore.
We should investigate whether there is a suitable replacement and what the EME situation on Android is to make sure we still provide a DRM-free mobile experience.https://gitlab.torproject.org/legacy/trac/-/issues/31844OpenSSL 1.1.1d fails to compile for some platforms/architectures2020-06-16T01:07:43ZGeorg KoppenOpenSSL 1.1.1d fails to compile for some platforms/architecturesAccording to our nightly builds only linux32 and macOS compilations for OpenSSL 1.1.1d succeeded, which is weird. Here is the error for linux 64bit:
```
${LDCMD:-gcc} -pthread -Wa,--noexecstack -Wall -O3 -L. \
-o apps/o...According to our nightly builds only linux32 and macOS compilations for OpenSSL 1.1.1d succeeded, which is weird. Here is the error for linux 64bit:
```
${LDCMD:-gcc} -pthread -Wa,--noexecstack -Wall -O3 -L. \
-o apps/openssl apps/asn1pars.o apps/ca.o apps/ciphers.o apps/cms.o apps/crl.o apps/crl2p7.o apps/dgst.o apps/dhparam.o apps/dsa.o apps/dsaparam.o apps/ec.o apps/ecparam.o apps/enc.o apps/engine.o apps/errstr.o apps/gendsa.o apps/genpkey.o apps/genrsa.o apps/nseq.o apps/ocsp.o apps/openssl.o apps/passwd.o apps/pkcs12.o apps/pkcs7.o apps/pkcs8.o apps/pkey.o apps/pkeyparam.o apps/pkeyutl.o apps/prime.o apps/rand.o apps/rehash.o apps/req.o apps/rsa.o apps/rsautl.o apps/s_client.o apps/s_server.o apps/s_time.o apps/sess_id.o apps/smime.o apps/speed.o apps/spkac.o apps/srp.o apps/storeutl.o apps/ts.o apps/verify.o apps/version.o apps/x509.o \
apps/libapps.a -lssl -lcrypto -ldl -pthread
./libcrypto.so: undefined reference to `aesni_ccm64_decrypt_blocks'
./libcrypto.so: undefined reference to `aesni_xts_encrypt'
./libcrypto.so: undefined reference to `aesni_ctr32_encrypt_blocks'
./libcrypto.so: undefined reference to `aesni_ccm64_encrypt_blocks'
./libcrypto.so: undefined reference to `aesni_cbc_encrypt'
./libcrypto.so: undefined reference to `aesni_ecb_encrypt'
./libcrypto.so: undefined reference to `aesni_gcm_decrypt'
./libcrypto.so: undefined reference to `aesni_gcm_encrypt'
./libcrypto.so: undefined reference to `aesni_ocb_decrypt'
./libcrypto.so: undefined reference to `gcm_ghash_avx'
./libcrypto.so: undefined reference to `aesni_ocb_encrypt'
./libcrypto.so: undefined reference to `aesni_encrypt'
./libcrypto.so: undefined reference to `aesni_decrypt'
./libcrypto.so: undefined reference to `aesni_set_encrypt_key'
./libcrypto.so: undefined reference to `aesni_set_decrypt_key'
./libcrypto.so: undefined reference to `aesni_xts_decrypt'
collect2: error: ld returned 1 exit status
```https://gitlab.torproject.org/legacy/trac/-/issues/31813Add enable-proxy-bypass-protection on Android2020-06-16T01:07:41ZMatthew FinkelAdd enable-proxy-bypass-protection on AndroidThe Android mozconfigs do not contain `ac_add_options --enable-proxy-bypass-protection`.The Android mozconfigs do not contain `ac_add_options --enable-proxy-bypass-protection`.https://gitlab.torproject.org/legacy/trac/-/issues/31732Windows nightly build failure2020-06-16T01:07:29ZboklmWindows nightly build failureThe Windows nightly builds currently fail while building firefox with:
```
31:36.72 /var/tmp/dist/mingw-w64-clang/bin/x86_64-w64-mingw32-clang++ -mwindows -shared -Wl,--out-implib -Wl,libclearkey.a -Wl,-pdb,clearkey.pdb -o clearkey.dll @...The Windows nightly builds currently fail while building firefox with:
```
31:36.72 /var/tmp/dist/mingw-w64-clang/bin/x86_64-w64-mingw32-clang++ -mwindows -shared -Wl,--out-implib -Wl,libclearkey.a -Wl,-pdb,clearkey.pdb -o clearkey.dll @/var/tmp/build/firefox-e489c5048b76/obj-mingw/media/gmp-clearkey/0.1/clearkey_dll.list ./module.res -Wl,--no-insert-timestamp -Wl,--dynamicbase -Wl,--icf=safe -luuid -lusp10 -lgdi32 -lwinmm -lwsock32 -luserenv -lsecur32 -lmfuuid
31:36.77 lld-link: error: undefined symbol: __strcat_chk
31:36.77 >>> referenced by /var/tmp/build/firefox-e489c5048b76/media/gmp-clearkey/0.1/openaes/oaes_lib.c:459
31:36.77 >>> oaes_lib.o:(oaes_sprintf)
31:36.77 clang-8: error: linker command failed with exit code 1 (use -v to see invocation)
31:36.77 /var/tmp/build/firefox-e489c5048b76/config/rules.mk:680: recipe for target 'clearkey.dll' failed
31:36.77 make[4]: *** [clearkey.dll] Error 1
```https://gitlab.torproject.org/legacy/trac/-/issues/31725Macedonian 9.0a6 bundles are missing localized strings2020-06-16T01:07:27ZGeorg KoppenMacedonian 9.0a6 bundles are missing localized stringsIt turns out that for some reason Macedonian is not properly localized on 9.0a6. Other locales don't suffer from this problem, though.It turns out that for some reason Macedonian is not properly localized on 9.0a6. Other locales don't suffer from this problem, though.https://gitlab.torproject.org/legacy/trac/-/issues/31720Address bar auto-complete is broken on Android2020-06-16T01:07:26ZMatthew FinkelAddress bar auto-complete is broken on AndroidWhen text is typed into the address bar, none of the auto-complete options are shown.When text is typed into the address bar, none of the auto-complete options are shown.https://gitlab.torproject.org/legacy/trac/-/issues/31702Backport patch for bug 1578075 for macOS Catalina2020-06-16T01:07:25ZGeorg KoppenBackport patch for bug 1578075 for macOS CatalinaWe are almost ready to ship macOS bundles compatible with Catalina. However, we need to backport at least the patch for https://bugzilla.mozilla.org/show_bug.cgi?id=1578075 as Mozilla does not seem to be making another esr60 release.We are almost ready to ship macOS bundles compatible with Catalina. However, we need to backport at least the patch for https://bugzilla.mozilla.org/show_bug.cgi?id=1578075 as Mozilla does not seem to be making another esr60 release.https://gitlab.torproject.org/legacy/trac/-/issues/28822re-implement desktop onboarding for ESR 682020-06-16T01:07:19ZMark Smithre-implement desktop onboarding for ESR 68As of Firefox 64, the onboarding extension which we used to implement Tor Browser onboarding has been removed. See:
https://bugzilla.mozilla.org/show_bug.cgi?id=1462415
https://bugzilla.mozilla.org/show_bug.cgi?id=1457565
More research ...As of Firefox 64, the onboarding extension which we used to implement Tor Browser onboarding has been removed. See:
https://bugzilla.mozilla.org/show_bug.cgi?id=1462415
https://bugzilla.mozilla.org/show_bug.cgi?id=1457565
More research is required, but it looks like Firefox's new onboarding experience is integrated into their "activity stream" interface (aka new tab page).https://gitlab.torproject.org/legacy/trac/-/issues/31646Update abicheck to require newer libstdc++.so.62020-06-16T01:07:16ZboklmUpdate abicheck to require newer libstdc++.so.6We should update `projects/firefox/abicheck.cc` to use features only provided by more recent versions of `libstdc++.so.6`.
Currently it only requires `GLIBCXX_3.4.22`:
```
$ strings tor-browser_en-US/Browser/abicheck | grep GLIBCXX_
GLI...We should update `projects/firefox/abicheck.cc` to use features only provided by more recent versions of `libstdc++.so.6`.
Currently it only requires `GLIBCXX_3.4.22`:
```
$ strings tor-browser_en-US/Browser/abicheck | grep GLIBCXX_
GLIBCXX_3.4
GLIBCXX_3.4.22
GLIBCXX_3.4.21
```
https://gcc.gnu.org/onlinedocs/libstdc++/manual/abi.htmlhttps://gitlab.torproject.org/legacy/trac/-/issues/31621Fix node bug that makes large writes to stdout fail2020-06-16T01:07:15ZGeorg KoppenFix node bug that makes large writes to stdout failWe wallpapered around a `node` bug that breaks compilation in case large writes are made to stdout (see: comment:7:ticket:30321 for context). This is biting us in cases where we actually *do* need those large write to debug problems like...We wallpapered around a `node` bug that breaks compilation in case large writes are made to stdout (see: comment:7:ticket:30321 for context). This is biting us in cases where we actually *do* need those large write to debug problems like in #31538.
We should provide a better fix/workaround.https://gitlab.torproject.org/legacy/trac/-/issues/31616Tor Browser on Android based on 60.9.0 is crashing on every launch2020-06-16T01:07:13ZGeorg KoppenTor Browser on Android based on 60.9.0 is crashing on every launchIt might be related to the issue tackled in #31140 or just another issue that the previous one hid. At any rate users are reporting app crashes on every launch even though the fix for #31140 shipped.It might be related to the issue tackled in #31140 or just another issue that the previous one hid. At any rate users are reporting app crashes on every launch even though the fix for #31140 shipped.https://gitlab.torproject.org/legacy/trac/-/issues/31606Update website update instructions in Tor Browser release process2020-06-16T01:07:09ZboklmUpdate website update instructions in Tor Browser release processhttps://gitlab.torproject.org/legacy/trac/-/issues/31601Don't let Mozilla recommend extensions again2020-06-16T01:07:08ZGeorg KoppenDon't let Mozilla recommend extensions againIt seems we need to ramp up our defense against the threat in #22899 again with ESR 68 as our users are getting shown recommended extensions again.It seems we need to ramp up our defense against the threat in #22899 again with ESR 68 as our users are getting shown recommended extensions again.https://gitlab.torproject.org/legacy/trac/-/issues/31598Properly enable letterboxing (again)2020-06-16T01:07:07ZGeorg KoppenProperly enable letterboxing (again)It seems while rebasing in #30429 we did not realize that the letterboxing patches made it into ESR 68 yet the pref to enabled the functionality needs still to get set.It seems while rebasing in #30429 we did not realize that the letterboxing patches made it into ESR 68 yet the pref to enabled the functionality needs still to get set.https://gitlab.torproject.org/legacy/trac/-/issues/31596Bump mingw-w64 version to pick up fix for #315672020-06-16T01:07:06ZGeorg KoppenBump mingw-w64 version to pick up fix for #31567Martin's patches landed. We should pick them up by bumping the mingw-w64 version.Martin's patches landed. We should pick them up by bumping the mingw-w64 version.https://gitlab.torproject.org/legacy/trac/-/issues/31574TypeError: addon is null with Tor Browser based on ESR 682020-06-16T01:07:00ZGeorg KoppenTypeError: addon is null with Tor Browser based on ESR 68During start-up I can see:
```
JavaScript error: re[//modules/BrowserGlue.jsm,](//modules/BrowserGlue.jsm,) line 1851: TypeError: addon is null
```During start-up I can see:
```
JavaScript error: re[//modules/BrowserGlue.jsm,](//modules/BrowserGlue.jsm,) line 1851: TypeError: addon is null
```