Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2020-06-16T01:04:49Zhttps://gitlab.torproject.org/legacy/trac/-/issues/30787Ship Lithuanian Tor Browser in alpha series2020-06-16T01:04:49ZemmapeelShip Lithuanian Tor Browser in alpha seriesYes! Lithuanian is already translated too.yay!Yes! Lithuanian is already translated too.yay!Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/legacy/trac/-/issues/30786Ship Thai Tor Browser in alpha series2020-06-16T01:04:48ZemmapeelShip Thai Tor Browser in alpha seriesAfter the localization lab sprint, the Tor Browser locale files have been translated to Thai.
please add them for testing to alpha!After the localization lab sprint, the Tor Browser locale files have been translated to Thai.
please add them for testing to alpha!Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/legacy/trac/-/issues/30683Properties in dom/locales/$lang/chrome/ allow detecting user locale2020-06-16T01:04:34ZGeorg KoppenProperties in dom/locales/$lang/chrome/ allow detecting user localez3t reported a bunch of issues on HackerOne regarding detection of user locale with the help of `dom/locales/$lang/chrome/` properties. PoCs done by z3t:
`dom/dom.properties`: https://people.torproject.org/~gk/tests/tor_form_locale_leak...z3t reported a bunch of issues on HackerOne regarding detection of user locale with the help of `dom/locales/$lang/chrome/` properties. PoCs done by z3t:
`dom/dom.properties`: https://people.torproject.org/~gk/tests/tor_form_locale_leak.html
`layout/xmlparser.properties`: https://people.torproject.org/~gk/tests/tor_domparser_locale_leak.html
`layout/MediaDocument.properties`: https://people.torproject.org/~gk/tests/tor_image_locale_leak.htmlhttps://gitlab.torproject.org/legacy/trac/-/issues/30548Clean up keyring files2020-06-16T01:03:59ZboklmClean up keyring filesIn `keyring/*.gpg`, some of the keyring files include some old keys or subkeys that we don't need anymore. We should remove all the keys and subkeys that we don't need (including expired keys).In `keyring/*.gpg`, some of the keyring files include some old keys or subkeys that we don't need anymore. We should remove all the keys and subkeys that we don't need (including expired keys).https://gitlab.torproject.org/legacy/trac/-/issues/30429Rebase Tor Browser patches for Firefox ESR 682020-06-16T01:12:05ZGeorg KoppenRebase Tor Browser patches for Firefox ESR 68We need to start rebasing our patches against Firefox 68. This is the ticket that tracks the whole effort.
It's helpful how we did it the last time: comment:6:ticket:25543. As mentioned there https://torpat.ch/ is a very valuable resour...We need to start rebasing our patches against Firefox 68. This is the ticket that tracks the whole effort.
It's helpful how we did it the last time: comment:6:ticket:25543. As mentioned there https://torpat.ch/ is a very valuable resource. It might need updating, though (which we should do while we are at it, or point Arthur to the things that need to get fixed).https://gitlab.torproject.org/legacy/trac/-/issues/28803Integrate building pluggable transports for Android into tor-browser-build2020-06-16T01:25:56ZGeorg KoppenIntegrate building pluggable transports for Android into tor-browser-buildWe want to support Pluggable Transports in Tor Browser for Android. We should integrate those we support into our tor-browser-build process.We want to support Pluggable Transports in Tor Browser for Android. We should integrate those we support into our tor-browser-build process.https://gitlab.torproject.org/legacy/trac/-/issues/28746Remove torbutton_update_isolation_prefs() and torbutton_update_fingerprinting...2020-06-16T01:04:54ZGeorg KoppenRemove torbutton_update_isolation_prefs() and torbutton_update_fingerprinting_prefs()We should not mirror the isolation and fingerprinting prefs in Torbutton. Just set them in the browser and that's it. Those options are not exposed in the browser UI anymore and if a user wants to mess with them they should be on their own.We should not mirror the isolation and fingerprinting prefs in Torbutton. Just set them in the browser and that's it. Those options are not exposed in the browser UI anymore and if a user wants to mess with them they should be on their own.https://gitlab.torproject.org/legacy/trac/-/issues/27265In some cases, rbm will download files in the wrong project directory2020-06-13T17:39:28ZboklmIn some cases, rbm will download files in the wrong project directoryThe patch for #27045 is causing an error when starting the build with an empty `out/` directory:
https://trac.torproject.org/projects/tor/ticket/27045#comment:11
We can see in the logs that binutils is being downloaded in the `out/firef...The patch for #27045 is causing an error when starting the build with an empty `out/` directory:
https://trac.torproject.org/projects/tor/ticket/27045#comment:11
We can see in the logs that binutils is being downloaded in the `out/firefox` directory instead of `out/binutils`:
```
Saving to: '/media/ssd/Code/Tor/tor-browser-build/out/firefox/binutils-2.26.1.tar.bz2'
```
The reason is that we override `output_dir` when calling `build_pkg` in `input_files`:
```
} elsif ($input_file->{project} && $t->('project')) {
my $p = $t->('project');
print "Building project $p - $name\n";
my $run_save = $config->{run};
$config->{run} = { target => $input_file->{target} };
$config->{run}{target} //= $run_save->{target};
build_pkg($p, {%$options, origin_project => $project, %$input_file,
output_dir => $proj_out_dir});
$config->{run} = $run_save;
print "Finished build of project $p - $name\n";
} else {
```
The reason why we don't see this error in normal builds and only see it with #27045 is that in #27045 we are changing the `tor-browser` filename to remove `c("var/build_id")` from it, removing the need to download dependencies to compute the filename. In normal builds the binutils tarball is already downloaded (in the correct directory) when we start the firefox build, so we are not hitting this issue.boklmboklmhttps://gitlab.torproject.org/legacy/trac/-/issues/25099Update nightly version number2020-06-16T01:10:25ZboklmUpdate nightly version numberIn order to be able to update Tor Browser nightly builds each day, we need each build to have a different version number.
Currently the version for nightly builds is set to `tbb-nightly`. I think we could change it to the current day wi...In order to be able to update Tor Browser nightly builds each day, we need each build to have a different version number.
Currently the version for nightly builds is set to `tbb-nightly`. I think we could change it to the current day with something like `2018.01.31`.boklmboklm