Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2020-06-16T01:12:41Zhttps://gitlab.torproject.org/legacy/trac/-/issues/33962Uplift patch for 5741 (dns leak protection)2020-06-16T01:12:41ZAlex CatarineuUplift patch for 5741 (dns leak protection)This should probably be under the `--enable-proxy-bypass-protection` flag.This should probably be under the `--enable-proxy-bypass-protection` flag.Alex CatarineuAlex Catarineuhttps://gitlab.torproject.org/legacy/trac/-/issues/33932Improve steps for creating gradle dependencies lists for projects2020-06-16T01:26:14ZGeorg KoppenImprove steps for creating gradle dependencies lists for projectsThe steps we have for creating lists of gradle dependencies are still not bullet proof. I stumbled across a case where a download got attempted but then a redirect happened which included a different URL and which finally failed. Our cur...The steps we have for creating lists of gradle dependencies are still not bullet proof. I stumbled across a case where a download got attempted but then a redirect happened which included a different URL and which finally failed. Our current instructions don't cope with that case (and probably other corner cases neither).
I've thinking about that and feel we can do better if we mimmick gradle's behavior more:
1) We keep the first step we currently have (extracting all the attempted downloads)
2) We actually try to download all those resources ourselves and compute their sha256 sum.
3) Download failures are easily removable (no sha256 sum is created in that case) and we just remove the successful duplicates.Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/legacy/trac/-/issues/33906Fix Tor-Launcher issues for Firefox 752020-06-13T17:44:26ZAlex CatarineuFix Tor-Launcher issues for Firefox 75Apart from #32174, #33862 and #33890, there seems to be some issues that need to be addressed.
By testing, I found that the "Back" button in the wizard does not have a label and the window used for displaying the bridge captcha and erro...Apart from #32174, #33862 and #33890, there seems to be some issues that need to be addressed.
By testing, I found that the "Back" button in the wizard does not have a label and the window used for displaying the bridge captcha and errors is not shown.
By looking at the code and console errors I also found that `getAnonymousElementByAttribute` is used, but this was removed in https://bugzilla.mozilla.org/show_bug.cgi?id=1591145. Besides, it seems now the `<wizard>` should not be the root element anymore: https://bugzilla.mozilla.org/show_bug.cgi?id=1584283. The same with `<dialog>` https://bugzilla.mozilla.org/show_bug.cgi?id=1585482.
I did not look in-depth, but these are some issues I found testing a bit after fixing (in principle) #32174, #33862 and #33890.Kathleen BradeKathleen Bradehttps://gitlab.torproject.org/legacy/trac/-/issues/33892Add brandProductName to torbutton brand localization files2020-06-16T01:28:34ZAlex CatarineuAdd brandProductName to torbutton brand localization files`brandProductName` was already present in ESR68, but we did not update torbutton `brand.dtd` or `brand.properties` files. For 68, this does not break the browser, since `brandProductName` is not used as an xml entity (DTD), and the `.pro...`brandProductName` was already present in ESR68, but we did not update torbutton `brand.dtd` or `brand.properties` files. For 68, this does not break the browser, since `brandProductName` is not used as an xml entity (DTD), and the `.properties` usage is in a path we probably do not [hit](https://searchfox.org/mozilla-esr68/rev/c6e395f8a8512bec0dea4d3526831a3dbbae90e4/toolkit/profile/content/profileSelection.js#86).
Currently, this is string is used in several additional places, and starting Firefox 70 it's used as a [DTD entity](https://searchfox.org/mozilla-central/rev/b7f3977978922d44c7d92ae01c0d4cc2baca7bc2/browser/locales/en-US/chrome/browser/browser.dtd#68), which prevents the browser from starting if it's not defined.https://gitlab.torproject.org/legacy/trac/-/issues/33890Rename .xul to .xhtml2020-06-16T01:12:33ZAlex CatarineuRename .xul to .xhtmlFirefox did a mass rename of all .xul files to .xhtml in https://bugzilla.mozilla.org/show_bug.cgi?id=1579952. We need to do the same in torbutton and tor-launcher, as well as in several Tor Browser patches that involve UI.Firefox did a mass rename of all .xul files to .xhtml in https://bugzilla.mozilla.org/show_bug.cgi?id=1579952. We need to do the same in torbutton and tor-launcher, as well as in several Tor Browser patches that involve UI.https://gitlab.torproject.org/legacy/trac/-/issues/33864Nightly Tor Browser updates are broken since at least 4/6/20202020-06-16T01:12:27ZGeorg KoppenNightly Tor Browser updates are broken since at least 4/6/2020I tried to update my Tor Browser nightly on 04/06/2020 that is still using the version from 04/02/2020. It said my Tor Browser is up-to-date. However, newer nightly binaries were available, e.g. from 04/06/2020.I tried to update my Tor Browser nightly on 04/06/2020 that is still using the version from 04/02/2020. It said my Tor Browser is up-to-date. However, newer nightly binaries were available, e.g. from 04/06/2020.https://gitlab.torproject.org/legacy/trac/-/issues/33862Fix usages of createTransport API2020-06-16T01:12:27ZAlex CatarineuFix usages of createTransport APIThere was a nsISocketTransportService breaking change in https://bugzilla.mozilla.org/show_bug.cgi?id=1558726. We have to fix those in torbutton and tor-launcher.There was a nsISocketTransportService breaking change in https://bugzilla.mozilla.org/show_bug.cgi?id=1558726. We have to fix those in torbutton and tor-launcher.https://gitlab.torproject.org/legacy/trac/-/issues/33856Set browser.privatebrowsing.forceMediaMemoryCache=true2020-06-24T11:43:52ZrichardSet browser.privatebrowsing.forceMediaMemoryCache=trueNew pref added to disable disk caching of video in private browsing mode.
Relevant ticket:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1532486New pref added to disable disk caching of video in private browsing mode.
Relevant ticket:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1532486Mark SmithMark Smithhttps://gitlab.torproject.org/legacy/trac/-/issues/33851Patch out Parental Controls detection and logging2020-06-16T01:12:23ZrichardPatch out Parental Controls detection and loggingWe should remove the per-OS implementations of nsIParentalControlsService in `/toolkit/components/parentalcontrols` and always use the stubbed-out `nsParentalControlsServiceDefault.cpp` implementation.
When an implementation is present,...We should remove the per-OS implementations of nsIParentalControlsService in `/toolkit/components/parentalcontrols` and always use the stubbed-out `nsParentalControlsServiceDefault.cpp` implementation.
When an implementation is present, URIs are sent to an `isAllowed(...` function that parental control software presumably can hook in the OS to filter content, and a `log(...)` method also takes in URIs.Mark SmithMark Smithhttps://gitlab.torproject.org/legacy/trac/-/issues/33848Disable Enhanced Tracking Protection (assuming we want it disabled)2020-06-16T01:12:22ZrichardDisable Enhanced Tracking Protection (assuming we want it disabled)There doesn't seem to be a single pref that disables everything, here's the prefs we need to set to disable the functionality:
- network.cookie.cookieBehavior = 0
- privacy.trackingprotection.enabled = false
- privacy.trackingprotect...There doesn't seem to be a single pref that disables everything, here's the prefs we need to set to disable the functionality:
- network.cookie.cookieBehavior = 0
- privacy.trackingprotection.enabled = false
- privacy.trackingprotection.pbmode.enabled = false
- privacy.trackingprotection.socialtracking.enabled = false
- privacy.trackingprotection.cryptomining.enabled = false
- privacy.trackingprotection.fingerprinting.enabled = false
We would need to some code to remove the ETP UI from about:preferences, the urlbar, etc.Mark SmithMark Smithhttps://gitlab.torproject.org/legacy/trac/-/issues/33833Upgrade Rust To Use Android NDK 202020-06-16T01:26:12ZShane IsbellUpgrade Rust To Use Android NDK 20Upgrade rust to use latest toolchainUpgrade rust to use latest toolchainGeorg KoppenGeorg Koppenhttps://gitlab.torproject.org/legacy/trac/-/issues/33801Upgrade Go Project to use new Android Toolchain2020-06-16T01:26:11ZShane IsbellUpgrade Go Project to use new Android ToolchainGo needs to use new NDK pathGo needs to use new NDK pathhttps://gitlab.torproject.org/legacy/trac/-/issues/33760Update rbm.conf to match NDK 202020-06-16T01:26:11ZShane IsbellUpdate rbm.conf to match NDK 20the configure_host field no longer matches the correct clang in the lasted NDK. The new NDK requires that we also update the platform version number.the configure_host field no longer matches the correct clang in the lasted NDK. The new NDK requires that we also update the platform version number.Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/legacy/trac/-/issues/33626Add TBB project for GeckoView2020-10-02T06:25:04ZShane IsbellAdd TBB project for GeckoViewFenix and android-components have dependencies on GeckoView. Need to setup environment to build this for production, beta and nightly. Involves rust and clang setup.Fenix and android-components have dependencies on GeckoView. Need to setup environment to build this for production, beta and nightly. Involves rust and clang setup.Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/legacy/trac/-/issues/33564Upgrade ZSTD to use Android NDK 202020-06-16T01:26:09ZShane IsbellUpgrade ZSTD to use Android NDK 20This is based of the current work done in branch for android support. We need to upgrade to build with NDK 21.
Make standalone toolchain is not longer supported in NDK 21 so need to configure to use new locationsThis is based of the current work done in branch for android support. We need to upgrade to build with NDK 21.
Make standalone toolchain is not longer supported in NDK 21 so need to configure to use new locationshttps://gitlab.torproject.org/legacy/trac/-/issues/33563Upgrade Tor To Use Android NDK 202020-06-16T01:26:08ZShane IsbellUpgrade Tor To Use Android NDK 20This is based of the current work done in branch for android support. We need to upgrade to build with NDK 21.
Make standalone toolchain is not longer supported in NDK 21 so need to configure to use new locationsThis is based of the current work done in branch for android support. We need to upgrade to build with NDK 21.
Make standalone toolchain is not longer supported in NDK 21 so need to configure to use new locationsGeorg KoppenGeorg Koppenhttps://gitlab.torproject.org/legacy/trac/-/issues/33561Upgrade openssl to use Android NDK 202020-06-16T01:26:07ZShane IsbellUpgrade openssl to use Android NDK 20This is based of the current work done in branch for android support. We need to upgrade to build with NDK 21.
Make standalone toolchain is not longer supported in NDK 21 so need to configure to use new locations.This is based of the current work done in branch for android support. We need to upgrade to build with NDK 21.
Make standalone toolchain is not longer supported in NDK 21 so need to configure to use new locations.Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/legacy/trac/-/issues/33559Update tor-android-service To Use Updated Android Toolchain2020-06-16T01:26:06ZShane IsbellUpdate tor-android-service To Use Updated Android ToolchainWe need to upgrade android toolchain to support fenix. This requires update to tor-android-service.We need to upgrade android toolchain to support fenix. This requires update to tor-android-service.Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/legacy/trac/-/issues/33558Update TOPL To Use Updated Android Toolchain2020-06-16T01:26:05ZShane IsbellUpdate TOPL To Use Updated Android ToolchainWe need to upgrade android toolchain to support fenix. This requires update to TOPL build as well.We need to upgrade android toolchain to support fenix. This requires update to TOPL build as well.Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/legacy/trac/-/issues/33557Update Android Toolchain for Fenix2020-06-16T01:26:05ZShane IsbellUpdate Android Toolchain for FenixFenix uses an updated Android SDK and NDK.Fenix uses an updated Android SDK and NDK.Georg KoppenGeorg Koppen