Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2020-06-16T19:13:45Zhttps://gitlab.torproject.org/legacy/trac/-/issues/33533Rebase Tor Browser esr68 patches on top of mozilla-central2020-06-16T19:13:45ZAlex CatarineuRebase Tor Browser esr68 patches on top of mozilla-centralAlex CatarineuAlex Catarineuhttps://gitlab.torproject.org/legacy/trac/-/issues/32895Improve marsigning_check.sh script to deal better with non-reproducible, sign...2020-06-16T01:25:57ZGeorg KoppenImprove marsigning_check.sh script to deal better with non-reproducible, signed macOS mar filesOur current mar-signing check script does two things:
1) It checks whether the SHA-256 sum from the signed .mar file is the same one as from the unsigned one and returns an error if so.
2) It strips the signature and compares the SHA-2...Our current mar-signing check script does two things:
1) It checks whether the SHA-256 sum from the signed .mar file is the same one as from the unsigned one and returns an error if so.
2) It strips the signature and compares the SHA-256 sum of the resulting .mar file with the unsigned one.
Step 2) essentially tries to do 2 checks in one: a) that there is a proper signature that can get stripped and b) that the resulting .mar file is the same as the unsigned one. That's cool in theory as we want to have both checks but it has a number of issues in practice. The most important ones are:
i) The script fails the mar-signing check for macOS as stripping the signatures from those files does not give us the unsigned .mar yet due to the content signing. (see: #20254)
ii) It's not clear we signed actually with the right key (although that is in practice not much of an issue) or whether the signature verifies later on (which is actually what we want to know).Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/legacy/trac/-/issues/32537Update marionette version used in tor browser testsuite, for ESR782020-06-13T17:41:29ZboklmUpdate marionette version used in tor browser testsuite, for ESR78The version of marionette that is used by the tor browser testsuite needs to be updated in order to support esr68 versions of Tor Browser.
The package versions used are for current mozilla-central (78).The version of marionette that is used by the tor browser testsuite needs to be updated in order to support esr68 versions of Tor Browser.
The package versions used are for current mozilla-central (78).https://gitlab.torproject.org/legacy/trac/-/issues/32355Tor Browser for Linux/ARMv7 (x86_64 build arch)2020-06-16T01:25:51ZJeremyRandTor Browser for Linux/ARMv7 (x86_64 build arch)The Tor Project should provide a Tor Browser compatible with the ARMv7 processor. This would provide a safe way of using Tor for users of the Samsung ARM Chromebook, the Samsung Chromebook 2, the Raspberry Pi, the Novena Open Laptop, and...The Tor Project should provide a Tor Browser compatible with the ARMv7 processor. This would provide a safe way of using Tor for users of the Samsung ARM Chromebook, the Samsung Chromebook 2, the Raspberry Pi, the Novena Open Laptop, and probably other platforms too.
This ticket is specifically for building Tor Browser for ARMv7 targets with the x86_64 build arch.https://gitlab.torproject.org/legacy/trac/-/issues/32174replace XUL <textbox> with <html:input>2020-06-13T17:44:23ZMark Smithreplace XUL <textbox> with <html:input>Mozilla has removed XUL <textbox>, although only partially in the ESR68 timeframe (see #32154 where we had to replace a multiline usage with <html:textarea>). We need to finish the job and replace our remaining uses of <textbox> with <ht...Mozilla has removed XUL <textbox>, although only partially in the ESR68 timeframe (see #32154 where we had to replace a multiline usage with <html:textarea>). We need to finish the job and replace our remaining uses of <textbox> with <html:input>.
While we are at it, we should double check that we do not use <textbox> outside of Tor Launcher, either in the Torbutton code or in a Firefox patch.Kathleen BradeKathleen Bradehttps://gitlab.torproject.org/legacy/trac/-/issues/30832Fix tor-browser tbb-tests2020-06-16T01:04:56ZAlex CatarineuFix tor-browser tbb-testsWith current rebased tor-browser ESR68 branch I can only run tbb-tests (with `run-tbb-tests` script) when `pref("network.file.path_blacklist", "/net")` is removed and `pref("extensions.torbutton.use_nontor_proxy", true);` is set, apart f...With current rebased tor-browser ESR68 branch I can only run tbb-tests (with `run-tbb-tests` script) when `pref("network.file.path_blacklist", "/net")` is removed and `pref("extensions.torbutton.use_nontor_proxy", true);` is set, apart from disabling tor-launcher. The second pref disables the domain isolator, which makes sense since it expects SOCKS5 proxies, but mochitests override that. For the other pref, not sure why `network.file.path_blacklist` needs to be unset (at least for Linux).
We could put these prefs in `testing/marionette/prefs/marionette.js` so that tests can be run (unless there is a simpler way to get the tests tor run that I'm missing).Alex CatarineuAlex Catarineuhttps://gitlab.torproject.org/legacy/trac/-/issues/28745THE Torbutton clean-up2020-06-16T01:28:24ZGeorg KoppenTHE Torbutton clean-upThat is the parent ticket for all things Torbutton clean-up, now that we included it into `tor-browser`. It's not clear yet how we'll be restructuring it but it's clear that a lot of old cruft has to go. This will be done in child tickets.That is the parent ticket for all things Torbutton clean-up, now that we included it into `tor-browser`. It's not clear yet how we'll be restructuring it but it's clear that a lot of old cruft has to go. This will be done in child tickets.Alex CatarineuAlex Catarineuhttps://gitlab.torproject.org/legacy/trac/-/issues/28396Temporary gpg signature verification scripts are not removed2020-06-13T17:39:29ZboklmTemporary gpg signature verification scripts are not removedIn order to verify gpg signature of git tags and commits, rbm is creating temporary scripts in the `tmp` directory, but those scripts are not removed.In order to verify gpg signature of git tags and commits, rbm is creating temporary scripts in the `tmp` directory, but those scripts are not removed.https://gitlab.torproject.org/legacy/trac/-/issues/27105Fix Tor Browser testsuite2020-06-16T01:13:09ZboklmFix Tor Browser testsuiteWe need to fix the Tor Browser testsuite to work with esr78 based Tor Browser.We need to fix the Tor Browser testsuite to work with esr78 based Tor Browser.Alex CatarineuAlex Catarineuhttps://gitlab.torproject.org/legacy/trac/-/issues/10394Torbrowser's updater updates HTTPS-everywhere2020-06-15T23:17:27ZTom LowenthalTorbrowser's updater updates HTTPS-everywhereLet's think about shipping HTTPS-Everywhere solely via our updater, disabling update pings for that extension as well.Let's think about shipping HTTPS-Everywhere solely via our updater, disabling update pings for that extension as well.