Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2020-06-13T15:53:37Zhttps://gitlab.torproject.org/legacy/trac/-/issues/34246Add a link to the formatted architecture docs in src/mainpage.md2020-06-13T15:53:37ZteorAdd a link to the formatted architecture docs in src/mainpage.mdWhen I open up src/mainpage.md. it's obviously meant to be formatted by a markdown parser. (And GitHub's markdown doesn't seem to handle "@" directives.)
Can you add a link to the formatted output at the top of mainpage.md ?When I open up src/mainpage.md. it's obviously meant to be formatted by a markdown parser. (And GitHub's markdown doesn't seem to handle "@" directives.)
Can you add a link to the formatted output at the top of mainpage.md ?Tor: 0.4.4.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/34233Fix use of == in configure.ac2020-06-13T15:53:35ZNick MathewsonFix use of == in configure.acA user points out that we're now using == in configure.ac, which isn't portable.
We'll need to backport a fix everywhere that we backported our #34078 fix.A user points out that we're now using == in configure.ac, which isn't portable.
We'll need to backport a fix everywhere that we backported our #34078 fix.Tor: 0.4.3.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/legacy/trac/-/issues/34220Return to stem master once stem issue 63 is resolved.2020-06-13T15:53:34ZNick MathewsonReturn to stem master once stem issue 63 is resolved.When stem fixes https://github.com/torproject/stem/issues/63 , we should revert the travis.yml change of #34204.When stem fixes https://github.com/torproject/stem/issues/63 , we should revert the travis.yml change of #34204.Tor: 0.4.4.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/legacy/trac/-/issues/33805While building tbb-9.0.8-build3 the build of openssl for Windows fails2020-06-16T01:12:16ZboklmWhile building tbb-9.0.8-build3 the build of openssl for Windows failsThe build of openssl fails with the following error:
```
*** Installing runtime libraries
install libcrypto-1_1.dll -> /var/tmp/dist/openssl/Program\ Files\ \(x86\)/OpenSSL/bin/libcrypto-1_1.dll
cp: cannot create regular file '/var/tmp/d...The build of openssl fails with the following error:
```
*** Installing runtime libraries
install libcrypto-1_1.dll -> /var/tmp/dist/openssl/Program\ Files\ \(x86\)/OpenSSL/bin/libcrypto-1_1.dll
cp: cannot create regular file '/var/tmp/dist/openssl/Program\ Files\ \(x86\)/OpenSSL/bin/libcrypto-1_1.dll.new': No such file or directory
make: *** [install_runtime_libs] Error 1
Makefile:456: recipe for target 'install_runtime_libs' failed
```https://gitlab.torproject.org/legacy/trac/-/issues/33801Upgrade Go Project to use new Android Toolchain2020-06-16T01:26:11ZShane IsbellUpgrade Go Project to use new Android ToolchainGo needs to use new NDK pathGo needs to use new NDK pathhttps://gitlab.torproject.org/legacy/trac/-/issues/33668--disable-module-relay yields to a Bug:2020-06-13T15:52:24Ztoralf--disable-module-relay yields to a Bug:At a hardened Gentoo Linux the configure option yields to a
```
# tor --verify-config
Mar 19 19:44:35.839 [notice] Tor 0.4.3.3-alpha running on Linux with Libevent 2.1.8-stable, OpenSSL LibreSSL 3.0.2, Zlib 1.2.11, Liblzma 5.2.4, and L...At a hardened Gentoo Linux the configure option yields to a
```
# tor --verify-config
Mar 19 19:44:35.839 [notice] Tor 0.4.3.3-alpha running on Linux with Libevent 2.1.8-stable, OpenSSL LibreSSL 3.0.2, Zlib 1.2.11, Liblzma 5.2.4, and Libzstd N/A.
Mar 19 19:44:35.840 [notice] Tor can't help you if you use it wrong! Learn how to be safe at https://www.torproject.org/download/download#warning
Mar 19 19:44:35.840 [notice] This version is not a stable Tor release. Expect more bugs than usual.
Mar 19 19:44:35.840 [notice] Read configuration file "/etc/tor/torrc".
Mar 19 19:44:35.843 [err] tor_assertion_failed_(): Bug: src/app/config/config.c:1473: options_switch_id: Assertion have_low_ports != -1 failed; aborting. (on Tor 0.4.3.3-alpha )
Mar 19 19:44:35.844 [err] Bug: Tor 0.4.3.3-alpha: Assertion have_low_ports != -1 failed in options_switch_id at src/app/config/config.c:1473: . Stack trace: (on Tor 0.4.3.3-alpha )
Mar 19 19:44:35.845 [err] Bug: tor(log_backtrace_impl+0x59) [0x5564677d3ab9] (on Tor 0.4.3.3-alpha )
Mar 19 19:44:35.845 [err] Bug: tor(tor_assertion_failed_+0x150) [0x5564677cecb0] (on Tor 0.4.3.3-alpha )
Mar 19 19:44:35.845 [err] Bug: tor(set_options+0x404) [0x5564677535d4] (on Tor 0.4.3.3-alpha )
Mar 19 19:44:35.845 [err] Bug: tor(+0x1648a0) [0x5564677548a0] (on Tor 0.4.3.3-alpha )
Mar 19 19:44:35.845 [err] Bug: tor(options_init_from_string+0x119) [0x556467754af9] (on Tor 0.4.3.3-alpha )
Mar 19 19:44:35.845 [err] Bug: tor(options_init_from_torrc+0x359) [0x5564677550f9] (on Tor 0.4.3.3-alpha )
Mar 19 19:44:35.845 [err] Bug: tor(tor_init+0x1c7) [0x55646764ade7] (on Tor 0.4.3.3-alpha )
Mar 19 19:44:35.846 [err] Bug: tor(tor_run_main+0x71) [0x55646764b4e1] (on Tor 0.4.3.3-alpha )
Mar 19 19:44:35.846 [err] Bug: tor(tor_main+0x46) [0x55646764a006] (on Tor 0.4.3.3-alpha )
Mar 19 19:44:35.846 [err] Bug: tor(main+0x19) [0x556467649bd9] (on Tor 0.4.3.3-alpha )
Mar 19 19:44:35.846 [err] Bug: /lib64/libc.so.6(__libc_start_main+0xeb) [0x7ff9817b8f1b] (on Tor 0.4.3.3-alpha )
Mar 19 19:44:35.846 [err] Bug: tor(_start+0x2a) [0x556467649c2a] (on Tor 0.4.3.3-alpha )
Aborted
```
The same tarball at the same system works fine with that option being enabled.
The config is
```
cat /etc/tor/torrc
User tor
PIDFile /var/run/tor/tor.pid
Log notice file /tmp/notice.log
DataDirectory /var/lib/tor/data
CookieAuthentication 1
ControlPort 9051
SocksPort 9050
SandBox 1
```Tor: 0.4.3.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/legacy/trac/-/issues/33565Upgrade LZMA to use Android NDK 202020-06-16T01:11:43ZShane IsbellUpgrade LZMA to use Android NDK 20This is based of the current work done in branch for android support. We need to upgrade to build with NDK 20.
Make standalone toolchain is not longer supported in NDK 20 so need to configure to use new locationsThis is based of the current work done in branch for android support. We need to upgrade to build with NDK 20.
Make standalone toolchain is not longer supported in NDK 20 so need to configure to use new locationshttps://gitlab.torproject.org/legacy/trac/-/issues/33564Upgrade ZSTD to use Android NDK 202020-06-16T01:26:09ZShane IsbellUpgrade ZSTD to use Android NDK 20This is based of the current work done in branch for android support. We need to upgrade to build with NDK 21.
Make standalone toolchain is not longer supported in NDK 21 so need to configure to use new locationsThis is based of the current work done in branch for android support. We need to upgrade to build with NDK 21.
Make standalone toolchain is not longer supported in NDK 21 so need to configure to use new locationshttps://gitlab.torproject.org/legacy/trac/-/issues/33523release process: Rename the update responses directory to .old to make it eas...2020-06-16T01:11:29Zboklmrelease process: Rename the update responses directory to .old to make it easier to revert in case of problemIn order to make it easier to quickly disable an update in case of issue, I think it is useful to keep a copy of the previous update responses directory available.
I think we can do that by renaming `{alpha,release}` to `{alpha,release}...In order to make it easier to quickly disable an update in case of issue, I think it is useful to keep a copy of the previous update responses directory available.
I think we can do that by renaming `{alpha,release}` to `{alpha,release}.old` instead of just removing it.https://gitlab.torproject.org/legacy/trac/-/issues/33460confmgt: include variable name in all complaints.2020-06-13T15:51:52ZNick Mathewsonconfmgt: include variable name in all complaints.When we give a msg about failing to parse a variable, we should say what the variable was, and ideally what was wrong with it.
Compare the results for running `./src/app/tor UseBridges 99` in 0.3.5 and in master. With 0.3.5 you got: `B...When we give a msg about failing to parse a variable, we should say what the variable was, and ideally what was wrong with it.
Compare the results for running `./src/app/tor UseBridges 99` in 0.3.5 and in master. With 0.3.5 you got: `Boolean 'UseBridges 99' expects 0 or 1.` but now you get `Unrecognized value 99.`
Let's make that better.Tor: 0.4.3.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/legacy/trac/-/issues/33451Write a script to install git tools and hooks2022-02-17T11:05:53ZNick MathewsonWrite a script to install git tools and hooksWe shouldn't run this automatically because of security issues, but it would be nice to have an automatic install tool.We shouldn't run this automatically because of security issues, but it would be nice to have an automatic install tool.Tor: 0.4.4.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/legacy/trac/-/issues/33403Add nightly mar key to tor-browser2020-06-16T01:11:19ZboklmAdd nightly mar key to tor-browserIn #31988 I created a mar signing key for nightly builds. We should add it to tor-browser nightly builds.
It seems the path used by nightly build is `toolkit/mozapps/update/updater/nightly_aurora_level3_primary.der` (and `nightly_aurora...In #31988 I created a mar signing key for nightly builds. We should add it to tor-browser nightly builds.
It seems the path used by nightly build is `toolkit/mozapps/update/updater/nightly_aurora_level3_primary.der` (and `nightly_aurora_level3_secondary.der`).boklmboklmhttps://gitlab.torproject.org/legacy/trac/-/issues/33402Set app.update.url for nightly builds2020-06-16T01:11:19ZboklmSet app.update.url for nightly buildsWe won't use the same `app.update.url` for releases and nightly builds. So we need to change this pref in the nightly builds.
https://nightlies.tbb.torproject.org/nightly-updates/updates/ is where the updates xml for nightly builds are ...We won't use the same `app.update.url` for releases and nightly builds. So we need to change this pref in the nightly builds.
https://nightlies.tbb.torproject.org/nightly-updates/updates/ is where the updates xml for nightly builds are located.boklmboklmhttps://gitlab.torproject.org/legacy/trac/-/issues/33380Add build-infos.json to sha256sums-unsigned-build.txt2020-06-16T01:11:18ZboklmAdd build-infos.json to sha256sums-unsigned-build.txtIn #32768 we added a `build-infos-$os.json` file. To make download of this file easier/safer, I think we should add it to `sha256sums-unsigned-build.txt`.In #32768 we added a `build-infos-$os.json` file. To make download of this file easier/safer, I think we should add it to `sha256sums-unsigned-build.txt`.boklmboklmhttps://gitlab.torproject.org/legacy/trac/-/issues/33370Don't build selftest.c when relay mode is disabled2020-06-13T15:51:34ZNick MathewsonDon't build selftest.c when relay mode is disabledTor: 0.4.4.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/legacy/trac/-/issues/33368Don't compile ext_orport.c when relay mode is disabled.2020-06-13T15:51:33ZNick MathewsonDon't compile ext_orport.c when relay mode is disabled.Tor: 0.4.4.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/legacy/trac/-/issues/33346Seccomp soft fail (no write) in 0.4.2.62020-06-13T15:51:28ZTracSeccomp soft fail (no write) in 0.4.2.6I've upgraded to 0.4.2.6 (as a good software user, but also because I noticed the seccomp changes).
Tor successfully starts with seccomp, but 'soft fails' because it can't write to its data directory (here: /var/lib/tor/data). Tor has p...I've upgraded to 0.4.2.6 (as a good software user, but also because I noticed the seccomp changes).
Tor successfully starts with seccomp, but 'soft fails' because it can't write to its data directory (here: /var/lib/tor/data). Tor has permissions to write to this directory - fine with Sandbox 0.
Log:
```
# cat /var/log/tor/log
Feb 16 00:46:56.000 [notice] Tor 0.4.2.6 opening new log file.
Feb 16 00:46:56.000 [notice] Parsing GEOIP IPv4 file /usr/share/tor/geoip.
Feb 16 00:46:57.000 [notice] Parsing GEOIP IPv6 file /usr/share/tor/geoip6.
Feb 16 00:46:57.000 [notice] Bootstrapped 0% (starting): Starting
Feb 16 00:46:57.000 [warn] Could not open "/var/lib/tor/data/cached-certs": Operation not permitted
Feb 16 00:46:57.000 [warn] Could not open "/var/lib/tor/data/cached-consensus" for mmap(): Operation not permitted
Feb 16 00:46:57.000 [warn] Could not open "/var/lib/tor/data/unverified-consensus" for mmap(): Operation not permitted
Feb 16 00:46:57.000 [warn] Could not open "/var/lib/tor/data/cached-microdesc-consensus" for mmap(): Operation not permitted
Feb 16 00:46:57.000 [warn] Could not open "/var/lib/tor/data/unverified-microdesc-consensus" for mmap(): Operation not permitted
Feb 16 00:46:57.000 [warn] Could not open "/var/lib/tor/data/cached-microdescs" for mmap(): Operation not permitted
Feb 16 00:46:57.000 [warn] Could not open "/var/lib/tor/data/cached-microdescs.new": Operation not permitted
Feb 16 00:46:57.000 [warn] Could not open "/var/lib/tor/data/cached-descriptors" for mmap(): Operation not permitted
Feb 16 00:46:57.000 [warn] Could not open "/var/lib/tor/data/cached-extrainfo" for mmap(): Operation not permitted
Feb 16 00:46:57.000 [notice] Starting with guard context "default"
Feb 16 00:46:58.000 [warn] Couldn't open "/var/lib/tor/data/state.tmp" (/var/lib/tor/data/state) for writing: Operation not permitted
Feb 16 00:46:58.000 [warn] Unable to write state to file "/var/lib/tor/data/state"; will try again later
Feb 16 00:46:58.000 [notice] Bootstrapped 5% (conn): Connecting to a relay
Feb 16 00:46:58.000 [notice] Bootstrapped 10% (conn_done): Connected to a relay
Feb 16 00:46:58.000 [notice] Bootstrapped 14% (handshake): Handshaking with a relay
Feb 16 00:46:58.000 [notice] Bootstrapped 15% (handshake_done): Handshake with a relay done
Feb 16 00:46:58.000 [notice] Bootstrapped 20% (onehop_create): Establishing an encrypted directory connection
Feb 16 00:46:58.000 [notice] Bootstrapped 25% (requesting_status): Asking for networkstatus consensus
Feb 16 00:46:58.000 [notice] Bootstrapped 30% (loading_status): Loading networkstatus consensus
Feb 16 00:46:59.000 [warn] Couldn't open "/var/lib/tor/data/unverified-microdesc-consensus.tmp" (/var/lib/tor/data/unverified-microdesc-consensus) for writing: Operation not permitted
Feb 16 00:46:59.000 [notice] I learned some more directory information, but not enough to build a circuit: We have no usable consensus.
Feb 16 00:46:59.000 [notice] Bootstrapped 40% (loading_keys): Loading authority key certs
Feb 16 00:46:59.000 [warn] Couldn't open "/var/lib/tor/data/cached-certs.tmp" (/var/lib/tor/data/cached-certs) for writing: Operation not permitted
Feb 16 00:46:59.000 [warn] Error writing certificates to disk.
Feb 16 00:46:59.000 [warn] Could not open "/var/lib/tor/data/unverified-microdesc-consensus" for mmap(): Operation not permitted
Feb 16 00:46:59.000 [notice] I learned some more directory information, but not enough to build a circuit: We have no usable consensus.
```
#### Appendix
##### Environment
```
Tor: 0.4.2.6
OS: Gentoo arm64
Hardware: Raspberry Pi 4
Kernel: 4.19.102-v8+ (RPi base)
```
##### Other info
When running 0.4.2.5, I experienced a crash with seccomp (possibly related to #27315)?
```
# tor
Feb 16 00:37:42.963 [notice] Tor 0.4.2.5 running on Linux with Libevent 2.1.8-stable, OpenSSL 1.1.1d, Zlib 1.2.11, Liblzma N/A, and Libzstd N/A.
Feb 16 00:37:42.963 [notice] Tor can't help you if you use it wrong! Learn how to be safe at https://www.torproject.org/download/download#warning
Feb 16 00:37:42.963 [notice] Read configuration file "/etc/tor/torrc".
Feb 16 00:37:42.966 [notice] Opening Socks listener on 127.0.0.1:9050
Feb 16 00:37:42.966 [notice] Opened Socks listener on 127.0.0.1:9050
============================================================ T= 1581813463
(Sandbox) Caught a bad syscall attempt (syscall unlinkat)
tor(+0x1cd714)[0x5571820714]
linux-vdso.so.1(__kernel_rt_sigreturn+0x0)[0x7f8bde0658]
/lib64/libc.so.6(unlink+0x30)[0x7f8b8058d8]
tor(run_tor_main_loop+0x74)[0x55716ae874]
tor(tor_run_main+0x11c)[0x55716aead4]
tor(tor_main+0x50)[0x55716ad458]
tor(main+0x24)[0x55716acf74]
/lib64/libc.so.6(__libc_start_main+0xe4)[0x7f8b758cac]
tor(+0x59fd0)[0x55716acfd0]
```
**Trac**:
**Username**: subjectfrostingTor: 0.4.4.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/legacy/trac/-/issues/33290Add diagnostics for confusing corruption issue #32564 in ewma2020-06-13T15:51:22ZNick MathewsonAdd diagnostics for confusing corruption issue #32564 in ewmaI haven't been able to figure out why we might be hitting #32564, so the logical solution is to try to make the diagnosis better if it happens.I haven't been able to figure out why we might be hitting #32564, so the logical solution is to try to make the diagnosis better if it happens.Tor: 0.4.2.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/legacy/trac/-/issues/33217Update scripts to add 0.4.3 and remove 0.4.02020-06-13T15:50:52ZNick MathewsonUpdate scripts to add 0.4.3 and remove 0.4.0Tor: 0.4.3.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/legacy/trac/-/issues/33104Minor issues when handling ACTIVE control signal2020-06-13T15:50:34ZGeorge KadianakisMinor issues when handling ACTIVE control signalThe ACTIVE control signal is not handled in `control_event_signal()` which results in:
`control_event_signal(): Bug: Unrecognized signal 132 in control_event_signal` messages when it appears.
There is also a mistype in the following co...The ACTIVE control signal is not handled in `control_event_signal()` which results in:
`control_event_signal(): Bug: Unrecognized signal 132 in control_event_signal` messages when it appears.
There is also a mistype in the following comment `/* "SIGACTIVE" counts as ersatz user activity. *`Tor: 0.4.2.x-finalNick MathewsonNick Mathewson