Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2020-06-13T15:45:35Zhttps://gitlab.torproject.org/legacy/trac/-/issues/31734Add accessor functions for cb_buf, which enforce locking and unlocking2020-06-13T15:45:35ZteorAdd accessor functions for cb_buf, which enforce locking and unlockingPart of #31614Part of #31614Tor: 0.4.2.x-finalteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/31692Upgrade obfs4 Docker image to Debian buster2020-06-13T18:33:12ZPhilipp Winterphw@torproject.orgUpgrade obfs4 Docker image to Debian busterVersion 0.1 of [our obfs4 Docker image](https://dip.torproject.org/torproject/anti-censorship/docker-obfs4-bridge) is using stretch, which is Debian's old stable. Let's upgrade it to Debian buster.Version 0.1 of [our obfs4 Docker image](https://dip.torproject.org/torproject/anti-censorship/docker-obfs4-bridge) is using stretch, which is Debian's old stable. Let's upgrade it to Debian buster.Philipp Winterphw@torproject.orgPhilipp Winterphw@torproject.orghttps://gitlab.torproject.org/legacy/trac/-/issues/31601Don't let Mozilla recommend extensions again2020-06-16T01:07:08ZGeorg KoppenDon't let Mozilla recommend extensions againIt seems we need to ramp up our defense against the threat in #22899 again with ESR 68 as our users are getting shown recommended extensions again.It seems we need to ramp up our defense against the threat in #22899 again with ESR 68 as our users are getting shown recommended extensions again.https://gitlab.torproject.org/legacy/trac/-/issues/31598Properly enable letterboxing (again)2020-06-16T01:07:07ZGeorg KoppenProperly enable letterboxing (again)It seems while rebasing in #30429 we did not realize that the letterboxing patches made it into ESR 68 yet the pref to enabled the functionality needs still to get set.It seems while rebasing in #30429 we did not realize that the letterboxing patches made it into ESR 68 yet the pref to enabled the functionality needs still to get set.https://gitlab.torproject.org/legacy/trac/-/issues/31554Restrict "make test-stem" to tests that actually use tor2020-06-13T15:44:51ZteorRestrict "make test-stem" to tests that actually use torIn #30694, we restricted the travis stem job to tests that actually use tor.
But we should lower that change to "make test-stem".
Gaba, this is sponsor 27 can, because it makes refactoring easier to test.In #30694, we restricted the travis stem job to tests that actually use tor.
But we should lower that change to "make test-stem".
Gaba, this is sponsor 27 can, because it makes refactoring easier to test.Tor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/31548hs-v3: Service can pick more than HiddenServiceNumIntroductionPoints intro po...2020-06-13T15:46:40ZDavid Gouletdgoulet@torproject.orghs-v3: Service can pick more than HiddenServiceNumIntroductionPoints intro pointsDuring my testing of #30200, I ended up with service descriptor with 4 intro points even though `HiddenServiceNumIntroductionPoints` is set to 3 (default).
Further investigation confirmed this by adding a log in the `decode_intro_points...During my testing of #30200, I ended up with service descriptor with 4 intro points even though `HiddenServiceNumIntroductionPoints` is set to 3 (default).
Further investigation confirmed this by adding a log in the `decode_intro_points()` function which showed me 4 intro points.
I haven't found out why but one feature of HS is that we launch `HiddenServiceNumIntroductionPoints` + 2 intro circuits in parallel and the first one to finish are picked.
It appears that more than the defined value can finish at the same time and will be picked.Tor: 0.3.5.x-finalDavid Gouletdgoulet@torproject.orgDavid Gouletdgoulet@torproject.orghttps://gitlab.torproject.org/legacy/trac/-/issues/31462Remove duplicate call to practracker in pre-commit hook2020-06-13T15:44:22ZteorRemove duplicate call to practracker in pre-commit hook#30051 added practracker to the pre-push and pre-commit hooks, but the pre-push hook already calls the pre-commit hook.
I'm just opening this ticket for the bug number, the fix PR is in #30979.
gaba, I think tooling can be part of spon...#30051 added practracker to the pre-push and pre-commit hooks, but the pre-push hook already calls the pre-commit hook.
I'm just opening this ticket for the bug number, the fix PR is in #30979.
gaba, I think tooling can be part of sponsor 31?Tor: 0.4.2.x-finalteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/31461Fix some typos in the 0.4.1 ReleaseNotes and ChangeLog2020-06-13T15:44:21ZteorFix some typos in the 0.4.1 ReleaseNotes and ChangeLogTor: 0.4.2.x-finalteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/31427Update BridgeDB's documentation2020-06-13T18:29:43ZPhilipp Winterphw@torproject.orgUpdate BridgeDB's documentationParts of BridgeDB's documentation is out-of-date. We should:
* Update the AUTHORS file.
* Update HACKING.md.
* Update contact info and the trac URL to file bugs.
I'll push a patch set in a minute.Parts of BridgeDB's documentation is out-of-date. We should:
* Update the AUTHORS file.
* Update HACKING.md.
* Update contact info and the trac URL to file bugs.
I'll push a patch set in a minute.Philipp Winterphw@torproject.orgPhilipp Winterphw@torproject.orghttps://gitlab.torproject.org/legacy/trac/-/issues/31406new ip-address for tor.dizum.com (auth-dir)2020-06-13T15:44:16ZAlex de Joodenew ip-address for tor.dizum.com (auth-dir)```
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Guys,
tor.dizum.com has changed it's IP address. As tor.dizum.com is a directory server, it's ip address is hardcoded in the source code.
Please update the ip.
OLD: 194.109.206.212...```
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Guys,
tor.dizum.com has changed it's IP address. As tor.dizum.com is a directory server, it's ip address is hardcoded in the source code.
Please update the ip.
OLD: 194.109.206.212
NEW: 45.66.33.45
You can verify and validate this change by either
1) retrieving the ip for tor.dizum.com.
2) contact alex, by email or by phone or on irc to verify this change.
3) you could read the announcement at the dir-auth list.
-----BEGIN PGP SIGNATURE-----
Version: BCPG v1.47
iGYEARECACYFAl1RuckfHEFsZXggZGUgSm9vZGUgPGFsZXhAaWRnYXJhLm5sPgAK
CRB4AD5zEX0r0DQsAJwN+/zRHTRgIiiXps8Lw0NieQgFpACgoz/YHdlt/X2YMQQL
bpY/OwGavRE=
=SFAn
-----END PGP SIGNATURE-----
```Tor: 0.2.9.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/31089Consider using data-URI to embed how_tor_works_thumb.png image into tor-exit-...2020-06-13T15:43:25Zrl1987Consider using data-URI to embed how_tor_works_thumb.png image into tor-exit-notice.htmlWe can only serve a single HTML file with `DirPortFrontPage` configuration option. Currently we provide an exit notice file in tor-exit-notice.html, which embeds an image with basic Tor network schematics from Tor website. We may want to...We can only serve a single HTML file with `DirPortFrontPage` configuration option. Currently we provide an exit notice file in tor-exit-notice.html, which embeds an image with basic Tor network schematics from Tor website. We may want to use data-URI format (as described in RFC 2397) to hardcode this image into HTML and avoid loading it from external webserver.Tor: 0.2.9.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/30967Make shellcheck ignore user-created directories, and run it during pre-commit2020-06-13T15:42:56ZteorMake shellcheck ignore user-created directories, and run it during pre-commitAt the moment, we shellcheck all the directories inside the tor directory, even user directories like .git, user-specified build directories, and directories that are added during tests.
This change will conflict with #30963, so it shou...At the moment, we shellcheck all the directories inside the tor directory, even user directories like .git, user-specified build directories, and directories that are added during tests.
This change will conflict with #30963, so it should be based on that branch.Tor: 0.4.2.x-finalteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/30958Stop removing the ed25519 signature when the extra-info file is too big2020-06-13T15:42:54ZteorStop removing the ed25519 signature when the extra-info file is too bigIn #30956, I discovered that the ed25519 signature extra-info line is
split across two chunks.
If the extra-info file gets too big, tor removes one chunk at a time. So each chunk needs to be a complete line.
Edit: but in this case, we ...In #30956, I discovered that the ed25519 signature extra-info line is
split across two chunks.
If the extra-info file gets too big, tor removes one chunk at a time. So each chunk needs to be a complete line.
Edit: but in this case, we should just stop removing the signatureTor: 0.4.2.x-finalteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/30951Follow up broken relays from fallback opt-ins2020-06-13T16:06:45ZteorFollow up broken relays from fallback opt-insThese relays couldn't be added to the fallback whitelist:
```
## Relays that need follow up ##
# https://lists.torproject.org/pipermail/tor-relays/2019-May/017325.html
# 2206C72ECC0D55593BC7B698F982533F1E141DD2 not found in recent descr...These relays couldn't be added to the fallback whitelist:
```
## Relays that need follow up ##
# https://lists.torproject.org/pipermail/tor-relays/2019-May/017325.html
# 2206C72ECC0D55593BC7B698F982533F1E141DD2 not found in recent descriptors
# Email sent directly to gus
# AFD1E28D6BFDFF03E715AF06259167ADA0E0CB1D not found in recent descriptors
# https://lists.torproject.org/pipermail/tor-relays/2019-June/017393.html
# A85FF376759C994A8A1168D8D8219C8C43F6C5E1 not found in recent descriptors
# https://lists.torproject.org/pipermail/tor-relays/2019-June/017394.html
# A850B6A31ED83FB92B34FB3AE0513902D053A1C8 needs a DirPort
# https://lists.torproject.org/pipermail/tor-relays/2019-June/017395.html
# E8D114B3C78D8E6E7FEB1004650DD632C2143C9E needs a DirPort
# https://lists.torproject.org/pipermail/tor-relays/2019-June/017398.html
# C6B656BA6BC16E31115A1B2D56396A53165F3408 needs a DirPort
```teorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/30920Detect uint64 overflow in config_parse_units()2020-06-13T15:42:44ZNick MathewsonDetect uint64 overflow in config_parse_units()The config_parse_units function uses 64-bit arithmetic, but does not detect 64-bit overflow. This means that values like "20000000 TB", which should be rejected, are instead mis-parsed.
Since this function is only used for configuratio...The config_parse_units function uses 64-bit arithmetic, but does not detect 64-bit overflow. This means that values like "20000000 TB", which should be rejected, are instead mis-parsed.
Since this function is only used for configuration parsing, it's not a huge issue, but it should be simple enough to resolve this.
Found while working on 30893.Tor: 0.4.3.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/30909sbws consensus timestamp updates incorrectly use the current time2020-06-13T16:16:17Zteorsbws consensus timestamp updates incorrectly use the current timeThere is a race condition in the sbws relay consensus timestamp update code.
sbws uses the current timestamp (now) when the same consensus is retrieved twice. Instead, it should just keep the same (valid-after) timestamp.There is a race condition in the sbws relay consensus timestamp update code.
sbws uses the current timestamp (now) when the same consensus is retrieved twice. Instead, it should just keep the same (valid-after) timestamp.sbws: 1.1.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/30820Show the correct macOS tor versions in chutney's CI2020-06-13T13:31:06ZteorShow the correct macOS tor versions in chutney's CII left out some environmental variables in #29729.I left out some environmental variables in #29729.teorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/30781Stop crashing when encountering an unknown router annotation2020-06-13T15:42:13ZteorStop crashing when encountering an unknown router annotationI think this bug can only be triggered by modifying a local file.
This bug was introduced in commit b5c8a8ae53 in 0.2.0.8-alpha.I think this bug can only be triggered by modifying a local file.
This bug was introduced in commit b5c8a8ae53 in 0.2.0.8-alpha.Tor: 0.2.9.x-finalteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/30747Unclear check for skipping scaling due to missing bandwidths or missing descr...2020-06-13T16:16:12ZteorUnclear check for skipping scaling due to missing bandwidths or missing descriptorsWe skip old results when scaling, but there are a few things wrong with this check:
1. It is hard to tell what this line does, because it mixes "and" and "or" without brackets: l.desc_bw_obs_last or l.desc_bw_obs_mean and l.desc_bw_avg
2...We skip old results when scaling, but there are a few things wrong with this check:
1. It is hard to tell what this line does, because it mixes "and" and "or" without brackets: l.desc_bw_obs_last or l.desc_bw_obs_mean and l.desc_bw_avg
2. We skip scaling if any input is missing, but then we check desc_bw_obs_type and ignore some inputs
3. If we are missing a descriptor for long enough, we stop generating results for a relay. We could use a substitute value instead.
```
if not(l.desc_bw_obs_last or l.desc_bw_obs_mean and l.desc_bw_avg):
log.debug("Skipping %s from scaling, because there were not "
"descriptor bandwidths.", l.nick)
continue
if desc_bw_obs_type == TORFLOW_OBS_LAST:
desc_bw_obs = l.desc_bw_obs_last
elif desc_bw_obs_type == TORFLOW_OBS_MEAN:
desc_bw_obs = l.desc_bw_obs_mean
```
https://github.com/torproject/sbws/blob/9065848247e49330560a2f73b044fb8c02338b48/sbws/lib/v3bwfile.py#L1244sbws: 1.1.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/30744Allow failures in the Travis test-stem job2020-06-13T15:42:04ZteorAllow failures in the Travis test-stem jobTor: 0.3.5.x-finalteorteor