Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2020-06-13T15:53:45Zhttps://gitlab.torproject.org/legacy/trac/-/issues/34384AppVeyor builds are failing2020-06-13T15:53:45ZAlexander Færøyahf@torproject.orgAppVeyor builds are failingOur AppVeyor builds are failing. It looks like the issue is related to us not updating Pacman before we install our dependencies.Our AppVeyor builds are failing. It looks like the issue is related to us not updating Pacman before we install our dependencies.Tor: unspecifiedhttps://gitlab.torproject.org/legacy/trac/-/issues/30902Stop comparing file_created key in test2020-06-13T16:16:13ZjugaStop comparing file_created key in testIn concrete tests/unit/lib/v3bwfile.py::test_from_results_read.
Because some times it files with the second: https://travis-ci.org/juga0/sbws/jobs/546378459#L1339.In concrete tests/unit/lib/v3bwfile.py::test_from_results_read.
Because some times it files with the second: https://travis-ci.org/juga0/sbws/jobs/546378459#L1339.sbws: unspecifiedhttps://gitlab.torproject.org/legacy/trac/-/issues/30698Should we add TRACE to stem's CI?2020-06-13T10:52:31ZteorShould we add TRACE to stem's CI?Like #30591, adding TRACE to stem's CI could help us diagnose issues. But we might need TRACE-to-file to make it work in Travis (#30675).Like #30591, adding TRACE to stem's CI could help us diagnose issues. But we might need TRACE-to-file to make it work in Travis (#30675).Damian JohnsonDamian Johnsonhttps://gitlab.torproject.org/legacy/trac/-/issues/30697test_get_hidden_service_descriptor fails with an unexpected response code2020-06-13T15:41:59Zteortest_get_hidden_service_descriptor fails with an unexpected response code```
======================================================================
ERROR: test_get_hidden_service_descriptor
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/...```
======================================================================
ERROR: test_get_hidden_service_descriptor
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/travis/build/torproject/stem/test/require.py", line 57, in wrapped
return func(self, *args, **kwargs)
File "/home/travis/build/torproject/stem/test/require.py", line 57, in wrapped
return func(self, *args, **kwargs)
File "/home/travis/build/torproject/stem/test/require.py", line 57, in wrapped
return func(self, *args, **kwargs)
File "/home/travis/build/torproject/stem/test/integ/control/controller.py", line 1292, in test_get_hidden_service_descriptor
desc = controller.get_hidden_service_descriptor('3g2upl4pq6kufc4m.onion')
File "/home/travis/build/torproject/stem/stem/control.py", line 487, in wrapped
return func(self, *args, **kwargs)
File "/home/travis/build/torproject/stem/stem/control.py", line 2186, in get_hidden_service_descriptor
raise stem.ProtocolError('HSFETCH returned unexpected response code: %s' % response.code)
ProtocolError: HSFETCH returned unexpected response code: 512
----------------------------------------------------------------------
```
https://travis-ci.org/torproject/stem/jobs/539138294#L1832
I think this might have been a recent tor change?Damian JohnsonDamian Johnsonhttps://gitlab.torproject.org/legacy/trac/-/issues/30696stem's test_close_stream fails with an extra stream in --target ONLINE mode2020-06-13T10:52:31Zteorstem's test_close_stream fails with an extra stream in --target ONLINE mode```
======================================================================
FAIL: test_close_stream
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/travis/build/torp...```
======================================================================
FAIL: test_close_stream
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/travis/build/torproject/stem/test/require.py", line 57, in wrapped
return func(self, *args, **kwargs)
File "/Users/travis/build/torproject/stem/test/require.py", line 57, in wrapped
return func(self, *args, **kwargs)
File "/Users/travis/build/torproject/stem/test/integ/control/controller.py", line 1072, in test_close_stream
self.assertEqual([built_stream.id], [stream.id for stream in controller.get_streams()])
AssertionError: Lists differ: ['109'] != ['109', '441']
Second list contains 1 additional elements.
First extra element 1:
'441'
- ['109']
+ ['109', '441']
----------------------------------------------------------------------
Ran 48 tests in 42.095s
FAILED (failures=1, skipped=6)
```
https://travis-ci.org/torproject/stem/jobs/539138288#L536Damian JohnsonDamian Johnsonhttps://gitlab.torproject.org/legacy/trac/-/issues/30653Add stem CI for --target ONLINE2020-06-13T10:52:29ZteorAdd stem CI for --target ONLINEFrom https://trac.torproject.org/projects/tor/ticket/28170#comment:14
```
Run 'run_tests.py --all' with python 2.6.
Run 'run_tests.py --all' with python 2.7.
Run 'run_tests.py --all' with python 3.x.
Run 'run_tests.py --...From https://trac.torproject.org/projects/tor/ticket/28170#comment:14
```
Run 'run_tests.py --all' with python 2.6.
Run 'run_tests.py --all' with python 2.7.
Run 'run_tests.py --all' with python 3.x.
Run 'run_tests.py --all --target ONLINE' with python 2.7.
```
Here's what I need to do:
* check to see if Travis supports python 2.6, and add a job with 2.6
* make the 2.7 job --target ONLINE
* assuming that ONLINE is a superset of offline
* make the latest python 3.x job --target ONLINE
* assuming that ONLINE is a superset of offline
I'm modifying existing jobs to save build time: we could create separate jobs for ONLINE, but that would add ~5 minutes to every CI run.teorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/30652configure Stem's Travis CI to email atagar and the committer when there are f...2020-06-13T10:52:28Zteorconfigure Stem's Travis CI to email atagar and the committer when there are failuresI need to:
1. check stem's Travis CI github.com/torproject/stem site config to make sure we haven't disabled emails
2. configure emails to the committer and atagar on github.com/torproject/stem, or if that's not possible, in .travis.yml
...I need to:
1. check stem's Travis CI github.com/torproject/stem site config to make sure we haven't disabled emails
2. configure emails to the committer and atagar on github.com/torproject/stem, or if that's not possible, in .travis.yml
* the difference is that the site will always be running stem master, but other people's repositories can have old stem versionsteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/30651Make stem's Travis jobs log controller messages from stem and tor2020-06-13T10:52:28ZteorMake stem's Travis jobs log controller messages from stem and torLike #30591, but in stem's CI.Like #30591, but in stem's CI.https://gitlab.torproject.org/legacy/trac/-/issues/30650Remove shellcheck from Stem's travis2020-06-13T10:52:28ZteorRemove shellcheck from Stem's travisTo cleanup after #30593, we need to remove the shellcheck install and test step from Stem's Travis CI.To cleanup after #30593, we need to remove the shellcheck install and test step from Stem's Travis CI.teorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/30598test_relay_cell fails on pypy 3.52020-06-13T10:52:27Zteortest_relay_cell fails on pypy 3.5```
test_relay_cell [FAILURE]
test_unimplemented_cell_methods 1 ms [SUCCESS]
test_unpack_for_new_link 3 ms [SUCCESS]
test_versions_cell ...```
test_relay_cell [FAILURE]
test_unimplemented_cell_methods 1 ms [SUCCESS]
test_unpack_for_new_link 3 ms [SUCCESS]
test_versions_cell 3 ms [SUCCESS]
test_vpadding_cell 3 ms [SUCCESS]
======================================================================
ERROR: test_relay_cell
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/travis/build/teor2345/stem/test/unit/client/cell.py", line 212, in test_relay_cell
self.assertEqual(3257622417, RelayCell(5, 'RELAY_BEGIN_DIR', '', digest, 564346860).digest)
File "/home/travis/build/teor2345/stem/stem/client/cell.py", line 363, in __init__
raise ValueError('RELAY cell digest must be a hash, string, or int but was a %s' % type(digest).__name__)
ValueError: RELAY cell digest must be a hash, string, or int but was a Hash
----------------------------------------------------------------------
Ran 16 tests in 0.056s
FAILED (errors=1)
```
https://travis-ci.org/teor2345/stem/jobs/536613181#L1526
It looks like hash and Hash are different classes in pypy.
Maybe they're the same in C python?Damian JohnsonDamian Johnsonhttps://gitlab.torproject.org/legacy/trac/-/issues/30597bandwidth_file test_version_position fails on python 32020-06-13T10:52:27Zteorbandwidth_file test_version_position fails on python 3```
descriptor.bandwidth_file... failed (0.02s)
test_content_example 0 ms [SUCCESS]
test_format_v1_0 3 ms [SUCCESS]
test_format_v1_2 ...```
descriptor.bandwidth_file... failed (0.02s)
test_content_example 0 ms [SUCCESS]
test_format_v1_0 3 ms [SUCCESS]
test_format_v1_2 3 ms [SUCCESS]
test_from_str 0 ms [SUCCESS]
test_header_alternate_div 2 ms [SUCCESS]
test_header_for_v1 0 ms [SUCCESS]
test_invalid_timestamp 1 ms [SUCCESS]
test_minimal_bandwidth_file 0 ms [SUCCESS]
test_new_header_attribute 0 ms [SUCCESS]
test_version_position [FAILURE]
======================================================================
FAIL: test_version_position
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/travis/build/teor2345/stem/test/unit/descriptor/bandwidth_file.py", line 215, in test_version_position
self.assertEqual(RIGHT_VERSION_POSITION, content)
AssertionError: '1410723598\nversion=1.1.0\nfile_created=2019-01-14T05:35:06\n=====' != b'1410723598\nversion=1.1.0\nfile_created=2019-01-14T05:35:06\n====='
----------------------------------------------------------------------
Ran 10 tests in 0.014s
FAILED (failures=1)
```
https://travis-ci.org/teor2345/stem/jobs/536613177#L1463
Looks like bytes/string confusion to me.
This error happens on python 3.6 and 3.7, and pypy 3.5.
The python 3.8 builds fail before this test.Damian JohnsonDamian Johnsonhttps://gitlab.torproject.org/legacy/trac/-/issues/30596stem tests expect platform.linux_distribution, which does not exist in python...2020-06-13T10:52:27Zteorstem tests expect platform.linux_distribution, which does not exist in python 3.8```
python version... 3.8.0a3+
operating system... failed
module 'platform' has no attribute 'linux_distribution'
The command "./run_tests.py --unit" exited with 1.
```
https://travis-c...```
python version... 3.8.0a3+
operating system... failed
module 'platform' has no attribute 'linux_distribution'
The command "./run_tests.py --unit" exited with 1.
```
https://travis-ci.org/teor2345/stem/jobs/536613179#L1529Damian JohnsonDamian Johnsonhttps://gitlab.torproject.org/legacy/trac/-/issues/30595Stem unit tests hang after doctest on macOS2020-06-13T10:52:26ZteorStem unit tests hang after doctest on macOS```
doctest... success (0.08s)
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to ad...```
doctest... success (0.08s)
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated
```
https://travis-ci.org/teor2345/stem/jobs/536613170#L364Damian JohnsonDamian Johnsonhttps://gitlab.torproject.org/legacy/trac/-/issues/30594stem unit tests fail on Tor 0.2.9, which is still supported until 1 January 20202020-06-13T10:52:26Zteorstem unit tests fail on Tor 0.2.9, which is still supported until 1 January 2020```
client.connection... failed (0.05s)
test_connection_time 25 ms [SUCCESS]
test_established [FAILURE]
test_invalid_argument...```
client.connection... failed (0.05s)
test_connection_time 25 ms [SUCCESS]
test_established [FAILURE]
test_invalid_arguments 1 ms [SUCCESS]
test_no_common_link_protocol 9 ms [SUCCESS]
test_not_orport 1 ms [SUCCESS]
======================================================================
FAIL: test_established
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/travis/build/teor2345/stem/test/integ/client/connection.py", line 66, in test_established
self.assertEqual(5, int(conn.link_protocol))
AssertionError: 5 != 4
----------------------------------------------------------------------
Ran 5 tests in 0.042s
FAILED (failures=1)
```
https://travis-ci.org/teor2345/stem/jobs/536613171#L1865
Link protocol 4 is supported by 0.2.9, and 5 is supported by 0.3.1.1-alpha and later:
https://gitweb.torproject.org/torspec.git/tree/tor-spec.txt#n1984Damian JohnsonDamian Johnsonhttps://gitlab.torproject.org/legacy/trac/-/issues/30593Fix argument passing in docs/republish2020-06-13T10:52:26ZteorFix argument passing in docs/republishshellcheck complains of quoting issues with `$*`.shellcheck complains of quoting issues with `$*`.teorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/30021Do not cache cipher list classification if cipher list is not yet available.2020-06-13T15:40:15ZNick MathewsonDo not cache cipher list classification if cipher list is not yet available.See #29437 for motivation.See #29437 for motivation.Tor: 0.2.9.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/legacy/trac/-/issues/28659Appveyor CI: error removing temporary directories - permission denied2020-06-13T15:34:54Zrl1987Appveyor CI: error removing temporary directories - permission deniedhttps://ci.appveyor.com/project/rl1987/tor/builds/20640384/job/3lk0nnv48m6vc5ni
```
consdiffmgr/cleanup_old_diffs: [forking] Error removing C:\Users\appveyor\AppData\Local\Temp\1\tor_test_1340_oylvawto\datadir_cdm_uj2f3yo3\diff-cache\10...https://ci.appveyor.com/project/rl1987/tor/builds/20640384/job/3lk0nnv48m6vc5ni
```
consdiffmgr/cleanup_old_diffs: [forking] Error removing C:\Users\appveyor\AppData\Local\Temp\1\tor_test_1340_oylvawto\datadir_cdm_uj2f3yo3\diff-cache\1000: Permission denied
Error removing C:\Users\appveyor\AppData\Local\Temp\1\tor_test_1340_oylvawto\datadir_cdm_uj2f3yo3\diff-cache\1003: Permission denied
Error removing C:\Users\appveyor\AppData\Local\Temp\1\tor_test_1340_oylvawto\datadir_cdm_uj2f3yo3\diff-cache\1006: Permission denied
Error removing C:\Users\appveyor\AppData\Local\Temp\1\tor_test_1340_oylvawto\datadir_cdm_uj2f3yo3\diff-cache\1013: Permission denied
Error removing directory C:\Users\appveyor\AppData\Local\Temp\1\tor_test_1340_oylvawto\datadir_cdm_uj2f3yo3\diff-cache: Directory not empty
Error removing directory C:\Users\appveyor\AppData\Local\Temp\1\tor_test_1340_oylvawto\datadir_cdm_uj2f3yo3: Directory not empty
Error removing directory C:\Users\appveyor\AppData\Local\Temp\1\tor_test_1340_oylvawto: Directory not empty
OK
consdiffmgr/validate: [forking] OK
```Tor: unspecifiedhttps://gitlab.torproject.org/legacy/trac/-/issues/28170Test stem pull requests against all supported tor versions, and tor nightly b...2020-06-13T10:53:23ZteorTest stem pull requests against all supported tor versions, and tor nightly buildsIn #27913, we want to test stem against all supported tor versions, and tor nightly.In #27913, we want to test stem against all supported tor versions, and tor nightly.https://gitlab.torproject.org/legacy/trac/-/issues/28024tell us where that mystery core file came from2020-06-13T15:32:48ZTaylor Yutell us where that mystery core file came fromWhen running `make distcheck`, run `file` on the mystery core file that sometimes appears, so we can better diagnose it.When running `make distcheck`, run `file` on the mystery core file that sometimes appears, so we can better diagnose it.Tor: 0.3.5.x-finalTaylor YuTaylor Yuhttps://gitlab.torproject.org/legacy/trac/-/issues/27968SIGNAL HALT race condition in test-rebind.py2020-06-13T15:32:31ZteorSIGNAL HALT race condition in test-rebind.pyIf tor exits due to SIGNAL HALT, before the python subprocess module terminates it, then test-rebind.py can fail with OSError 3 (no such process).
This race condition causes make check failures on my laptop running Windows Subsystem for...If tor exits due to SIGNAL HALT, before the python subprocess module terminates it, then test-rebind.py can fail with OSError 3 (no such process).
This race condition causes make check failures on my laptop running Windows Subsystem for Linux. It could potentially cause CI failures on busy machines.
I have a patch that rewrites test-rebind.py to be more reliable.Tor: 0.3.5.x-finalteorteor