Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2018-03-02T19:52:57Zhttps://gitlab.torproject.org/legacy/trac/-/issues/25314Build error during Windows (32- and 64-bit builds) of Thunderbird2018-03-02T19:52:57ZSukhbir SinghBuild error during Windows (32- and 64-bit builds) of ThunderbirdWhen building Thunderbird for Windows (32- and 64-bit builds), we get the following error:
```
20:38.34 /var/tmp/build/thunderbird-48f960ae7db5/mailnews/base/search/src/nsMsgImapSearch.cpp: In static member function 'static nsresult nsM...When building Thunderbird for Windows (32- and 64-bit builds), we get the following error:
```
20:38.34 /var/tmp/build/thunderbird-48f960ae7db5/mailnews/base/search/src/nsMsgImapSearch.cpp: In static member function 'static nsresult nsMsgSearchOnlineMail::Encode(nsCString&, nsISupportsArray*, const char16_t*)':
20:38.34 /var/tmp/build/thunderbird-48f960ae7db5/mailnews/base/search/src/nsMsgImapSearch.cpp:122:43: error: call of overloaded 'NS_IsAscii(char16ptr_t)' is ambiguous
20:38.34 asciiOnly = NS_IsAscii(pchar.get());
20:38.34 ^
20:38.34 In file included from /var/tmp/build/thunderbird-48f960ae7db5/obj-mingw/dist/include/msgCore.h:15:0,
20:38.35 from /var/tmp/build/thunderbird-48f960ae7db5/mailnews/base/search/src/nsMsgImapSearch.cpp:5:
20:38.35 /var/tmp/build/thunderbird-48f960ae7db5/obj-mingw/dist/include/nsCRTGlue.h:101:6: note: candidate: bool NS_IsAscii(char16_t)
20:38.35 bool NS_IsAscii(char16_t aChar);
20:38.35 ^
20:38.35 /var/tmp/build/thunderbird-48f960ae7db5/obj-mingw/dist/include/nsCRTGlue.h:102:6: note: candidate: bool NS_IsAscii(const char16_t*)
20:38.35 bool NS_IsAscii(const char16_t* aString);
20:38.35 ^
20:38.35 /var/tmp/build/thunderbird-48f960ae7db5/mailnews/base/search/src/nsMsgImapSearch.cpp:131:48: error: operands to ?: have different types 'char16ptr_t' and 'const char16_t*'
20:38.35 char *csname = GetImapCharsetParam(asciiOnly ? usAsciiCharSet.get() : destCharset);
20:38.35 ^
20:38.35 /var/tmp/build/thunderbird-48f960ae7db5/mailnews/base/search/src/nsMsgImapSearch.cpp:131:48: note: and each type can be converted to the other
20:38.35 /var/tmp/build/thunderbird-48f960ae7db5/mailnews/base/search/src/nsMsgImapSearch.cpp:136:15: error: operands to ?: have different types 'char16ptr_t' and 'const char16_t*'
20:38.35 asciiOnly ? usAsciiCharSet.get(): destCharset,
20:38.35 ^
20:38.35 /var/tmp/build/thunderbird-48f960ae7db5/mailnews/base/search/src/nsMsgImapSearch.cpp:136:15: note: and each type can be converted to the other
20:38.35 /var/tmp/build/thunderbird-48f960ae7db5/mailnews/base/search/src/nsMsgImapSearch.cpp:137:15: error: operands to ?: have different types 'char16ptr_t' and 'const char16_t*'
20:38.35 asciiOnly ? usAsciiCharSet.get(): destCharset, false);
20:38.35 ^
20:38.35 /var/tmp/build/thunderbird-48f960ae7db5/mailnews/base/search/src/nsMsgImapSearch.cpp:137:15: note: and each type can be converted to the other
20:38.40
20:38.40 In the directory /var/tmp/build/thunderbird-48f960ae7db5/obj-mingw/mailnews/base/search/src
20:38.40 The following command failed to execute properly:
20:38.40 /var/tmp/dist/mingw-w64/helpers/x86_64-w64-mingw32-g++ -std=gnu++11 -mwindows -o nsMsgImapSearch.o -c -DNDEBUG=1 -DTRIMMED=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/var/tmp/build/thunderbird-48f960ae7db5/mailnews/base/search/src -I/var/tmp/build/thunderbird-48f960ae7db5/obj-mingw/mailnews/base/search/src -I/var/tmp/build/thunderbird-48f960ae7db5/obj-mingw/dist/include -I/var/tmp/build/thunderbird-48f960ae7db5/obj-mingw/dist/include/nspr -I/var/tmp/build/thunderbird-48f960ae7db5/obj-mingw/dist/include/nss -DMOZILLA_CLIENT -include /var/tmp/build/thunderbird-48f960ae7db5/obj-mingw/mozilla-config.h -MD -MP -MF .deps/nsMsgImapSearch.o.pp -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wc++14-compat -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-format -fno-lifetime-dse -fno-exceptions -fno-strict-aliasing -mms-bitfields -fno-rtti -fno-exceptions -fno-math-errno -pipe -g -O -fomit-frame-pointer /var/tmp/build/thunderbird-48f960ae7db5/mailnews/base/search/src/nsMsgImapSearch.cpp
20:38.40 /var/tmp/build/thunderbird-48f960ae7db5/mozilla/config/rules.mk:951: recipe for target 'nsMsgImapSearch.o' failed
20:38.40 make[4]: *** [nsMsgImapSearch.o] Error 1
20:38.40 /var/tmp/build/thunderbird-48f960ae7db5/mozilla/config/recurse.mk:71: recipe for target 'mailnews/base/search/src/target' failed
20:38.40 make[3]: *** [mailnews/base/search/src/target] Error 2
20:38.40 make[3]: *** Waiting for unfinished jobs....
20:46.65 libmsgbsutl_s.a.desc
20:46.71 /var/tmp/build/thunderbird-48f960ae7db5/mozilla/config/recurse.mk:32: recipe for target 'compile' failed
20:46.71 make[2]: *** [compile] Error 2
20:46.71 /var/tmp/build/thunderbird-48f960ae7db5/mozilla/config/rules.mk:523: recipe for target 'default' failed
20:46.71 make[1]: *** [default] Error 2
20:46.71 client.mk:397: recipe for target 'build' failed
20:46.71 make: *** [build] Error 2
```https://gitlab.torproject.org/legacy/trac/-/issues/15389Add option for skipping Tor Launcher during Tor Mail startup2015-03-23T09:13:35ZSukhbir SinghAdd option for skipping Tor Launcher during Tor Mail startupThe default behaviour of the Tor Mail bundle is to first start Tor Launcher (which starts Tor) and then start Thunderbird. This is similar to the order of operation in the Tor Browser Bundle.
However, unlike TBB, users may want to start...The default behaviour of the Tor Mail bundle is to first start Tor Launcher (which starts Tor) and then start Thunderbird. This is similar to the order of operation in the Tor Browser Bundle.
However, unlike TBB, users may want to start Thunderbird _without_ launching Tor Launcher (and Tor), so that they can use it in offline mode to read/compose emails. Currently, this can be achieved by setting the environment variable `TOR_SKIP_LAUNCH` to 1, after which Tor Launcher will skip starting Tor and will just start Thunderbird.
We should find a better way of doing this so that users can start Thunderbird without Tor and without setting variables. Perhaps we can have a dialog that prompts the users? Or an option in Tor Launcher?Sukhbir SinghSukhbir Singh