Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2020-06-13T16:46:58Zhttps://gitlab.torproject.org/legacy/trac/-/issues/9620No "download link" for attachments2020-06-13T16:46:58ZNick MathewsonNo "download link" for attachmentsGo to a ticket with an attachment (Try #1922). There used to be a link to click to download the attachment, I think. Now you can only see it in the viewer, without an obvious way to get the original file. Any tips?Go to a ticket with an attachment (Try #1922). There used to be a link to click to download the attachment, I think. Now you can only see it in the viewer, without an obvious way to get the original file. Any tips?Erinn ClarkErinn Clarkhttps://gitlab.torproject.org/legacy/trac/-/issues/9706Missing "To" header triggers Spamassassin2020-06-13T16:46:59ZSteven MurdochMissing "To" header triggers SpamassassinWith the new Trac, mails sent do not have a "To" header. This triggers the MISSING_HEADERS and REPLYTO_WITHOUT_TO_CC Spamassassin rules and got the messages classified as spam. Previously mails had the header "To: undisclosed-recipients:;".With the new Trac, mails sent do not have a "To" header. This triggers the MISSING_HEADERS and REPLYTO_WITHOUT_TO_CC Spamassassin rules and got the messages classified as spam. Previously mails had the header "To: undisclosed-recipients:;".Erinn ClarkErinn Clarkhttps://gitlab.torproject.org/legacy/trac/-/issues/9749Include Link to Gitweb in MainNav again2020-06-13T16:47:02ZbastikInclude Link to Gitweb in MainNav againBefore the update/upgrade to the new Trac version there was a link in the MainNav linking to gitweb.torproject.org
Apparently there's a single line of code
```
<li><a href="gitweb.torproject.org">Git</a></li>
```
that has to be added t...Before the update/upgrade to the new Trac version there was a link in the MainNav linking to gitweb.torproject.org
Apparently there's a single line of code
```
<li><a href="gitweb.torproject.org">Git</a></li>
```
that has to be added to be like this:
```
<ul> <li class="first"><a href="/projects/tor/report">View Tickets</a></li><li><a href="/projects/tor/browser">Browse Source</a></li><li><a href="gitweb.torproject.org">Git</a></li><a href="/projects/tor/roadmap">Roadmap</a></li><li><a href="/projects/tor/timeline">Timeline</a></li><li class="active"><a href="/projects/tor/wiki">Wiki</a></li><li><a href="/projects/tor/search">Search</a></li><li class="last"><a href="/projects/tor/tags">Tags</a></li> </ul>
```
To show you what it looks like I'll attack a partial screen shot. You can place the link somewhere else in the MainNav bar if you like, of course.
(I'm unable to apply these changes locally as it seems, if there's a way, maybe it will work out for me, though it would be nice to have the link back for anyone)Erinn ClarkErinn Clarkhttps://gitlab.torproject.org/legacy/trac/-/issues/10010Make infinity0 a ‘developer’ in Trac2020-06-13T16:47:11ZRobert RansomMake infinity0 a ‘developer’ in TracSee [ticket:10008#comment:2].See [ticket:10008#comment:2].Erinn ClarkErinn Clarkhttps://gitlab.torproject.org/legacy/trac/-/issues/10018Create a Trac component for DocTor2020-06-13T16:47:11ZKarsten LoesingCreate a Trac component for DocTorDamian, should we create a Trac component for your consensus-health checker DocTor? I'd like to move #8164, #8797, and #9103 to it. Any preference how to spell the component (like, is "DocTor" okay)? Want to become the component owner?Damian, should we create a Trac component for your consensus-health checker DocTor? I'd like to move #8164, #8797, and #9103 to it. Any preference how to spell the component (like, is "DocTor" okay)? Want to become the component owner?Karsten LoesingKarsten Loesinghttps://gitlab.torproject.org/legacy/trac/-/issues/10075Make an outreach component for new trac tickets2020-06-13T16:47:13ZMatt PaganMake an outreach component for new trac ticketsThis will become especially useful as tackle more of the SponsorOtter deliverables.This will become especially useful as tackle more of the SponsorOtter deliverables.Erinn ClarkErinn Clarkhttps://gitlab.torproject.org/legacy/trac/-/issues/10132Trac Timeline broken2020-06-13T16:47:15ZbastikTrac Timeline brokenhttps://trac.torproject.org/projects/tor/timeline
Shows the following Trac Error:
> Event provider ChangesetModule failed for filters "Changesets in all repositories", " - arm", " - torbutton", " - stem", " - pluggable-transports/o...https://trac.torproject.org/projects/tor/timeline
Shows the following Trac Error:
> Event provider ChangesetModule failed for filters "Changesets in all repositories", " - arm", " - torbutton", " - stem", " - pluggable-transports/obfsproxy", " - tor", " - torbrowser", " - builders/tor-browser-bundle": ValueError: need more than 0 values to unpack
https://trac.torproject.org/projects/tor/timeline?wiki=on&ticket=on&milestone=on works (changesets are not enabled here)Erinn ClarkErinn Clarkhttps://gitlab.torproject.org/legacy/trac/-/issues/10253Date cut-off in Timeline "input#fromdate"2020-06-13T16:47:19ZbastikDate cut-off in Timeline "input#fromdate"The default time setting displays the current date as "Nov 29, 2013", where the "3" is cut off.
The trick seems to be to increase the width for the input fields via css.
>#prefs input, #prefs select {
> font-size: 9px;vertical-align: ...The default time setting displays the current date as "Nov 29, 2013", where the "3" is cut off.
The trick seems to be to increase the width for the input fields via css.
>#prefs input, #prefs select {
> font-size: 9px;vertical-align: middle;**width: 65px**;
The bold indicates what I added to the trac.css, 60px worked fine for me, but I thought it to be safer to use some higher value. Note that this increases all input fields of the right selection menu, but not the search bar. This change is untested, so it could have very well impacts on other input fields, also it shifts the descriptions of the check-boxes farther away from them.
Alternatively the default way of displaying all dates on trac is to use the ISO thingy, to make dates appear like 2013-11-29. (Logged in users can override it)https://gitlab.torproject.org/legacy/trac/-/issues/10294Give Yan Zhu trac admin access2020-06-13T16:47:21ZPeter EckersleyGive Yan Zhu trac admin accessYan Zhu (trac.tpo username zyan) should have trac admin access so that she can create HTTPS Everywhere milestones and versions.Yan Zhu (trac.tpo username zyan) should have trac admin access so that she can create HTTPS Everywhere milestones and versions.https://gitlab.torproject.org/legacy/trac/-/issues/10321Add new Trac component for ExoneraTor2020-06-13T16:47:23ZKarsten LoesingAdd new Trac component for ExoneraTorSee summary. I'm going to do this myself, this ticket is just here to document this.See summary. I'm going to do this myself, this ticket is just here to document this.Karsten LoesingKarsten Loesinghttps://gitlab.torproject.org/legacy/trac/-/issues/10359Create a new Trac component for Globe and make rndm the component owner2020-06-13T16:47:29ZKarsten LoesingCreate a new Trac component for Globe and make rndm the component ownerKarsten LoesingKarsten Loesinghttps://gitlab.torproject.org/legacy/trac/-/issues/10373Remove pyonionoo component and close all its tickets as wontfix2020-06-13T16:47:30ZKarsten LoesingRemove pyonionoo component and close all its tickets as wontfixThere are seven open tickets in the pyonionoo component, all of which haven't been touched in the past 14 months:
https://trac.torproject.org/projects/tor/query?status=!closed&component=pyonionoo
Is it safe to assume that the Onionoo r...There are seven open tickets in the pyonionoo component, all of which haven't been touched in the past 14 months:
https://trac.torproject.org/projects/tor/query?status=!closed&component=pyonionoo
Is it safe to assume that the Onionoo rewrite in Python won't happen, and can we remove the pyonionoo component and close all its tickets as wontfix?
Happy to do that, but I'd like to hear gsathya's opinion on it first.Karsten LoesingKarsten Loesinghttps://gitlab.torproject.org/legacy/trac/-/issues/10375Remove blockfinder Trac component2020-06-13T16:47:30ZKarsten LoesingRemove blockfinder Trac componentBlockfinder is hosted on GitHub and has actively discussed issues there. No need to have a component for it in our Trac. There are no tickets in the blockfinder component (anymore). I'm going to remove the component.Blockfinder is hosted on GitHub and has actively discussed issues there. No need to have a component for it in our Trac. There are no tickets in the blockfinder component (anymore). I'm going to remove the component.https://gitlab.torproject.org/legacy/trac/-/issues/10376Bugs in Trac don't get a default owner anymore2020-06-13T16:47:30ZGeorg KoppenBugs in Trac don't get a default owner anymoreBugs in Trac used to have a default owner. When creating bugs they don't get owned by anyone by default anymore, now.Bugs in Trac used to have a default owner. When creating bugs they don't get owned by anyone by default anymore, now.https://gitlab.torproject.org/legacy/trac/-/issues/10377testing component owner to see if it's fixed2020-06-13T16:47:31ZErinn Clarktesting component owner to see if it's fixedfor #10376for #10376Erinn ClarkErinn Clarkhttps://gitlab.torproject.org/legacy/trac/-/issues/10404Trac permission for CCing users2020-06-13T16:47:31ZSukhbir SinghTrac permission for CCing usersI had like to have the necessary permissions to add people to tickets (CC) for the TorBirdy component. Thank you!I had like to have the necessary permissions to add people to tickets (CC) for the TorBirdy component. Thank you!Erinn ClarkErinn Clarkhttps://gitlab.torproject.org/legacy/trac/-/issues/10590Give mttp developer privileges on trac2020-06-13T16:47:38ZMatt PaganGive mttp developer privileges on tracI promise not to ruin everything.I promise not to ruin everything.https://gitlab.torproject.org/legacy/trac/-/issues/10690Trac error on password change2020-06-13T16:47:41ZTracTrac error on password changeTrac causes this error when trying to change my password:
```
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/trac/web/api.py", line 514, in send_error
data, 'text/html')
File "/usr/lib/python2.7/dist-p...Trac causes this error when trying to change my password:
```
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/trac/web/api.py", line 514, in send_error
data, 'text/html')
File "/usr/lib/python2.7/dist-packages/trac/web/chrome.py", line 976, in render_template
data = self.populate_data(req, data)
File "/usr/lib/python2.7/dist-packages/trac/web/chrome.py", line 882, in populate_data
'context': web_context(req) if req else None,
File "/usr/lib/python2.7/dist-packages/trac/web/chrome.py", line 292, in web_context
perm = req.perm
File "/usr/lib/python2.7/dist-packages/trac/web/api.py", line 316, in __getattr__
value = self.callbacks[name](self)
File "/usr/lib/python2.7/dist-packages/trac/web/main.py", line 264, in _get_perm
return PermissionCache(self.env, self.authenticate(req))
File "/usr/lib/python2.7/dist-packages/trac/web/main.py", line 135, in authenticate
authname = authenticator.authenticate(req)
File "build/bdist.linux-x86_64/egg/acct_mgr/util.py", line 82, in wrap
return func(self, *args, **kwds)
File "build/bdist.linux-x86_64/egg/acct_mgr/web_ui.py", line 374, in authenticate
return auth.LoginModule.authenticate(self, req)
File "/usr/lib/python2.7/dist-packages/trac/web/auth.py", line 91, in authenticate
req.incookie['trac_auth'])
File "build/bdist.linux-x86_64/egg/acct_mgr/web_ui.py", line 448, in _get_name_for_cookie
name = auth.LoginModule._get_name_for_cookie(self, req, cookie)
File "/usr/lib/python2.7/dist-packages/trac/web/auth.py", line 238, in _get_name_for_cookie
name = self._cookie_to_name(req, cookie)
File "/usr/lib/python2.7/dist-packages/trac/web/auth.py", line 234, in _cookie_to_name
for name, in self.env.db_query(sql, args):
File "/usr/lib/python2.7/dist-packages/trac/db/api.py", line 122, in execute
return db.execute(query, params)
File "/usr/lib/python2.7/dist-packages/trac/db/util.py", line 121, in execute
cursor.execute(query, params)
File "/usr/lib/python2.7/dist-packages/trac/db/util.py", line 65, in execute
return self.cursor.execute(sql_escape_percent(sql), args)
InternalError: current transaction is aborted, commands ignored until end of transaction block
```
Supposedly, some characters in the new password are trickling down to the SQL level where the SQL statement responsible for setting the password has not been authored correctly. This may pose a potential **security** hole.
**Trac**:
**Username**: GITNEErinn ClarkErinn Clarkhttps://gitlab.torproject.org/legacy/trac/-/issues/10956Please create a component for deb.tpo2020-06-13T16:47:45ZLunarPlease create a component for deb.tpoIt's the second time that I wanted to report an issue about deb.tpo and I had no proper component to use. I think that's a sign we need one.
weasel, what do you think of adding one? Would you be fine owning that component?It's the second time that I wanted to report an issue about deb.tpo and I had no proper component to use. I think that's a sign we need one.
weasel, what do you think of adding one? Would you be fine owning that component?Jens KubiezielJens Kubiezielhttps://gitlab.torproject.org/legacy/trac/-/issues/10961Create a TIMB and a PCPHS component2020-06-13T16:47:46ZKarsten LoesingCreate a TIMB and a PCPHS componentWe need two new components for two products that will come out of Sponsor O. One is the Tor Instant Messaging Bundle (TIMB), and another is Point-click-publish Hidden Services which I'm going to abbreviate with PCPHS. We can still rena...We need two new components for two products that will come out of Sponsor O. One is the Tor Instant Messaging Bundle (TIMB), and another is Point-click-publish Hidden Services which I'm going to abbreviate with PCPHS. We can still rename components later if we want better names. I'm creating these components myself. This ticket is only for documentation purposes.Karsten LoesingKarsten Loesing