Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2020-06-13T16:06:51Zhttps://gitlab.torproject.org/legacy/trac/-/issues/32699Rename the fallback input list to an "offer list"2020-06-13T16:06:51ZteorRename the fallback input list to an "offer list"In #24839, we want to replace the list of relay operators who have offered their relays as fallbacks, with signed statements in descriptors via a torrc option.
As part of that transition, we should rename the internal variables in the s...In #24839, we want to replace the list of relay operators who have offered their relays as fallbacks, with signed statements in descriptors via a torrc option.
As part of that transition, we should rename the internal variables in the script, and the file in the repository. I suggest we use "fallback offer list".
We should also delete any remaining references to the blacklist, because it is obsolete, and the actual list was removed from the repository some time ago.
This change also has the benefit of avoiding the "white = good" metaphor, which can be confusing and problematic. For more details, see:
https://tools.ietf.org/id/draft-knodel-terminology-00.htmlteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/31305Add more useful logging to fallback scripts variable config2020-06-13T16:06:49ZteorAdd more useful logging to fallback scripts variable configIn #29100, nickm says:
> As a followup, I suggest changing the definition of getvar_conf() so that on error, it gives a more useful explaining what the problem is, and changing the definition of opt() so that it turns the empty string an...In #29100, nickm says:
> As a followup, I suggest changing the definition of getvar_conf() so that on error, it gives a more useful explaining what the problem is, and changing the definition of opt() so that it turns the empty string and/or a missing option into None, but reports errors otherwise.teorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/31021Add fallback CI for the check_existing and OUTPUT_CANDIDATES modes2020-06-13T16:06:49ZteorAdd fallback CI for the check_existing and OUTPUT_CANDIDATES modesWe should test these modes, because they run some different code to the default mode.We should test these modes, because they run some different code to the default mode.https://gitlab.torproject.org/legacy/trac/-/issues/31020Validate the fallback scripts CI output using grep and stem2020-06-13T16:06:48ZteorValidate the fallback scripts CI output using grep and stemOr we could write a test python script that runs the other scripts and checks their output.Or we could write a test python script that runs the other scripts and checks their output.Tor: 0.4.5.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/309744-5. Announce the new fallback list, and tell downstream maintainers that it ...2020-06-13T16:06:48Zteor4-5. Announce the new fallback list, and tell downstream maintainers that it has changedHere are the instructions for running a rebuild:
https://trac.torproject.org/projects/tor/wiki/doc/UpdatingFallbackDirectoryMirrors
This ticket covers steps 4 and 5.Here are the instructions for running a rebuild:
https://trac.torproject.org/projects/tor/wiki/doc/UpdatingFallbackDirectoryMirrors
This ticket covers steps 4 and 5.https://gitlab.torproject.org/legacy/trac/-/issues/309732-3. Generate a new fallback list in 2019-2020 and backport it to all support...2020-06-13T16:06:47Zteor2-3. Generate a new fallback list in 2019-2020 and backport it to all supported Tor versionsHere are the instructions for running a rebuild:
https://trac.torproject.org/projects/tor/wiki/doc/UpdatingFallbackDirectoryMirrors
This ticket covers steps 2 and 3.Here are the instructions for running a rebuild:
https://trac.torproject.org/projects/tor/wiki/doc/UpdatingFallbackDirectoryMirrors
This ticket covers steps 2 and 3.https://gitlab.torproject.org/legacy/trac/-/issues/309720-1. Run an opt-in process for relay operators to become fallbacks in 2019-20202020-06-13T16:06:47Zteor0-1. Run an opt-in process for relay operators to become fallbacks in 2019-2020Here are the instructions for running a rebuild:
https://trac.torproject.org/projects/tor/wiki/doc/UpdatingFallbackDirectoryMirrors
This ticket covers steps 0 and 1.Here are the instructions for running a rebuild:
https://trac.torproject.org/projects/tor/wiki/doc/UpdatingFallbackDirectoryMirrors
This ticket covers steps 0 and 1.https://gitlab.torproject.org/legacy/trac/-/issues/30971Rebuild the fallback list in late 2019 or early 20202020-06-13T16:06:46ZteorRebuild the fallback list in late 2019 or early 2020Late in 2019, or early in 2020, we should rebuild the fallback list again.
We usually do this when 25% or more go down.
(When 25% of fallbacks are down, a warning is logged daily in #tor-bots on IRC, and via email to the fallback mainta...Late in 2019, or early in 2020, we should rebuild the fallback list again.
We usually do this when 25% or more go down.
(When 25% of fallbacks are down, a warning is logged daily in #tor-bots on IRC, and via email to the fallback maintainers.)
Here are the instructions for running a rebuild:
https://trac.torproject.org/projects/tor/wiki/doc/UpdatingFallbackDirectoryMirrors
See the child tickets for each step.Tor: 0.4.4.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/30969Add timestamp, country, and commit keys to the directory list header and log2020-06-13T16:06:45ZteorAdd timestamp, country, and commit keys to the directory list header and logAt the moment, I'm including them in the filename, which isn't ideal.
We should copy the spec from sbws for timestamp and country, and maybe commit if sbws adds it first.At the moment, I'm including them in the filename, which isn't ideal.
We should copy the spec from sbws for timestamp and country, and maybe commit if sbws adds it first.https://gitlab.torproject.org/legacy/trac/-/issues/30955Update the fallback entry in the man page2020-06-13T15:42:52ZteorUpdate the fallback entry in the man page"FallbackDir ipv4address:port"
"FallbackDir ipv4address:dirport"
"DirAuthority [nickname] [flags] ipv4address:port"
"DirAuthority [nickname] [flags] ipv4address:dirport"
And similarly for orport.
"The provided port value is a dirport;..."FallbackDir ipv4address:port"
"FallbackDir ipv4address:dirport"
"DirAuthority [nickname] [flags] ipv4address:port"
"DirAuthority [nickname] [flags] ipv4address:dirport"
And similarly for orport.
"The provided port value is a dirport; clients ignore this in favor of the specified "orport=" value."
"Clients always use the orport. Relays prefer the dirport, but will use the orport in some circumstances."
Add something to the FallbackDir entry talking about how the DirPort is used by the checking script?Tor: 0.4.2.x-finalteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/30952Work out why the latest fallback list only has 127 entries2020-06-13T16:06:45ZteorWork out why the latest fallback list only has 127 entriesWe seem to have dropped 25 since last time, which isn't great.
I should also look at the long-term number of fallbacks.We seem to have dropped 25 since last time, which isn't great.
I should also look at the long-term number of fallbacks.teorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/30951Follow up broken relays from fallback opt-ins2020-06-13T16:06:45ZteorFollow up broken relays from fallback opt-insThese relays couldn't be added to the fallback whitelist:
```
## Relays that need follow up ##
# https://lists.torproject.org/pipermail/tor-relays/2019-May/017325.html
# 2206C72ECC0D55593BC7B698F982533F1E141DD2 not found in recent descr...These relays couldn't be added to the fallback whitelist:
```
## Relays that need follow up ##
# https://lists.torproject.org/pipermail/tor-relays/2019-May/017325.html
# 2206C72ECC0D55593BC7B698F982533F1E141DD2 not found in recent descriptors
# Email sent directly to gus
# AFD1E28D6BFDFF03E715AF06259167ADA0E0CB1D not found in recent descriptors
# https://lists.torproject.org/pipermail/tor-relays/2019-June/017393.html
# A85FF376759C994A8A1168D8D8219C8C43F6C5E1 not found in recent descriptors
# https://lists.torproject.org/pipermail/tor-relays/2019-June/017394.html
# A850B6A31ED83FB92B34FB3AE0513902D053A1C8 needs a DirPort
# https://lists.torproject.org/pipermail/tor-relays/2019-June/017395.html
# E8D114B3C78D8E6E7FEB1004650DD632C2143C9E needs a DirPort
# https://lists.torproject.org/pipermail/tor-relays/2019-June/017398.html
# C6B656BA6BC16E31115A1B2D56396A53165F3408 needs a DirPort
```teorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/30949Add the source= line to the dir list spec2020-06-13T15:42:50ZteorAdd the source= line to the dir list specIn #30947, we added a source line to the fallback file header.
Now we need to update the spec.In #30947, we added a source line to the fallback file header.
Now we need to update the spec.Tor: 0.4.2.x-finalteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/30948Copy the relevant parts of .gitignore to fallback-scripts2020-06-13T16:06:44ZteorCopy the relevant parts of .gitignore to fallback-scriptsteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/30947Add a source line to the header, because type must always be fallback2020-06-13T16:06:44ZteorAdd a source line to the header, because type must always be fallbackThe dir list spec says that fallback files start with:
`/* type=fallback */`
https://gitweb.torproject.org/torspec.git/tree/dir-list-spec.txt#n140
But in #24953, we change type to whitelist by default. This might cause some parsers to b...The dir list spec says that fallback files start with:
`/* type=fallback */`
https://gitweb.torproject.org/torspec.git/tree/dir-list-spec.txt#n140
But in #24953, we change type to whitelist by default. This might cause some parsers to break.
Instead, we should add a new `/* source=whitelist|fallback*/` line.Tor: 0.4.1.x-finalteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/30785Give Gus access to the fallback-scripts repository2020-06-13T16:57:55ZteorGive Gus access to the fallback-scripts repository```
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Hi,
Please give gus push access to the fallback-scripts repository at:
https://gitweb.torproject.org/fallback-scripts.git
Thanks!
teor, Thu 6 Jun 2019 08:14:29 UTC
-----BEGIN PGP S...```
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Hi,
Please give gus push access to the fallback-scripts repository at:
https://gitweb.torproject.org/fallback-scripts.git
Thanks!
teor, Thu 6 Jun 2019 08:14:29 UTC
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEo9HIo7IdGQ1wBWG3EP6qDnB1ZyoFAlz4y4cACgkQEP6qDnB1
Zyp3Ag//R5/VzuzKAhOn5zlk9YNfUlVbgcD50NZqRqs73gYXAojAR+GrDMPQe/D+
RvY2qgR/4UQn4kdxt9zZahMn7iePwHADWsDyfdxAkdK9qsdPOL0P9OES5ahJITiA
dFMQiQfweR+b+oyYQTaYWKrDzj7hvWKAk+KxmRTbMyvMxpVfqFMtQZQg+xLsDxl2
xI0PXRs0wAxsNz5+WO0ySPHoc9yZo9Qm1Hw709O6wGgmQOeHh5LmyNjIcOzWsleO
MfCgeVPdE9xGHf5CRzM3Vej2JBeihGr+wDsQMS6myKrlXOjxVd/50vybyZsZAkaC
n43ObaYwvXuvuxARgQQcWc0ICNdJXr5z/0HH1PC9AWqxMNd/9whYKlXWySL1mKfh
aRVF9byoqL3kuAS9PXkpAAN1PrhOtLMHGOrLCeUHdDiHlu5foMq5YkxBOK5RNqHv
n7xl8aWorwwAwyHf7Qw5AytVof5xaDnvthV67W0D4AlgumVZNwRSA3IJWTxKHrGE
U5XZJa//U16yH5y/rBajMAWuVcPzzHm49msQao8vY+ZXWJs5OvccP8NfA4kMZdtB
z4qIb5iwCaZAb3pIIjwx9B7DKaydW/dmLsLpUsykA7H+joUKF+rTnYJiD5JjA48v
NaXBIBBIRPmc9A11OX1WJHK5H1YKtFCk9UYq7xlyMASITIgWNrs=
=RpNx
-----END PGP SIGNATURE-----
```https://gitlab.torproject.org/legacy/trac/-/issues/29103Add a licence, readme, and code of conduct to fallback-scripts2020-06-13T16:06:42ZteorAdd a licence, readme, and code of conduct to fallback-scriptsWe should use the Tor licence, because that's what the original code was committed under. Same with the code of conduct. The README might take more work.We should use the Tor licence, because that's what the original code was committed under. Same with the code of conduct. The README might take more work.teorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/29101Configure the push hook from git.tpo to github for fallback-scripts2020-06-13T16:56:17ZteorConfigure the push hook from git.tpo to github for fallback-scriptsWe need to:
* create a repository for fallback-scripts on https://github.com/torproject
* give phoul and teor and network-team and the pusher permissions
* configure the pusher on the git.torproject.org endWe need to:
* create a repository for fallback-scripts on https://github.com/torproject
* give phoul and teor and network-team and the pusher permissions
* configure the pusher on the git.torproject.org endTor: 0.4.0.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/29100Update src/app/config/fallback_dirs.inc to ../tor/src/app/config/fallback_dir...2020-06-13T16:06:41ZteorUpdate src/app/config/fallback_dirs.inc to ../tor/src/app/config/fallback_dirs.inc post-splitThere are a bunch of references to `src/app/config/fallback_dirs.inc` for check_existing mode, and in the comments.
We should update them to `../tor/src/app/config/fallback_dirs.inc` post-split.There are a bunch of references to `src/app/config/fallback_dirs.inc` for check_existing mode, and in the comments.
We should update them to `../tor/src/app/config/fallback_dirs.inc` post-split.https://gitlab.torproject.org/legacy/trac/-/issues/29093Announce the new fallback list, and tell downstream maintainers that it has c...2020-06-13T16:06:40ZteorAnnounce the new fallback list, and tell downstream maintainers that it has changedSteps 4 & 5 of:
https://trac.torproject.org/projects/tor/wiki/doc/UpdatingFallbackDirectoryMirrors#ATypicalReleaseSteps 4 & 5 of:
https://trac.torproject.org/projects/tor/wiki/doc/UpdatingFallbackDirectoryMirrors#ATypicalReleaseTor: 0.4.1.x-finalteorteor