Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2020-06-15T23:17:18Zhttps://gitlab.torproject.org/legacy/trac/-/issues/10353Cookie Protection dialog is empty in FF242020-06-15T23:17:18ZMike PerryCookie Protection dialog is empty in FF24The nsCookieService does not seem to expose the Private Browsing Mode cookie database to extensions in any substantial way. Unless I missed something, there does not appear to be a way to enumerate these cookies directly. This means that...The nsCookieService does not seem to expose the Private Browsing Mode cookie database to extensions in any substantial way. Unless I missed something, there does not appear to be a way to enumerate these cookies directly. This means that the Cookie Protections Dialog (and Firefox's own Cookie Dialog) are always empty in the default TBB configuration, unless the user selects to enable history.
We should either create APIs to export and manipulate the private cookie store, or alter the cookie protections dialog to inform the user that cookie protection and manipulation is only available if they are storing disk activity.https://gitlab.torproject.org/legacy/trac/-/issues/10352Private Browsing Mode data not properly cleared by New Identity2013-12-11T19:22:45ZMike PerryPrivate Browsing Mode data not properly cleared by New IdentityIt looks like the Mozilla documentation we used in #9570 was incomplete. It turns out that much of the private browsing mode context is not cleared upon all windows being closed on New Identity if you are using the default configuration ...It looks like the Mozilla documentation we used in #9570 was incomplete. It turns out that much of the private browsing mode context is not cleared upon all windows being closed on New Identity if you are using the default configuration ('browser.privatebrowsing.autostart' set to true). It is also not cleared by our existing usage of the cookie and cache clearing APIs are also leaving data from Private Browsing Mode sessions in tact.
All of this data does get cleared if you are storing history (which is why I missed this so far :/)
It also appears that the Torbutton Cookie Protections window is also always empty if you are using the default configuration ('browser.privatebrowsing.autostart' set to true).
Good test pages for verifying this are:
http://samy.pl/evercookie/
http://www.stevesouders.com/blog/2012/09/10/clearing-browser-data/https://gitlab.torproject.org/legacy/trac/-/issues/10285Write test pages for certain FF24 features2020-06-13T02:48:57ZMike PerryWrite test pages for certain FF24 featuresThere are a couple of new Firefox features that may behave in unacceptable ways on some platforms. In particular, the web notifications api (https://developer.mozilla.org/en-US/docs/WebAPI/Using_Web_Notifications) could potentially intro...There are a couple of new Firefox features that may behave in unacceptable ways on some platforms. In particular, the web notifications api (https://developer.mozilla.org/en-US/docs/WebAPI/Using_Web_Notifications) could potentially introduce proxy bypass similar to what we saw with drag and drop url sniffing by the OS Desktop.
Similarly, if https://developer.mozilla.org/en-US/docs/Web/API/ClipboardEvent.clipboardData is able to randomly inspect the clipboard, this could be very privacy invasive. We should ensure that the clipboard APIs either ask the user first, or otherwise only interact with clipboard data originating from that same page.
There were also some changes to the Download Manager in terms of how it executes helper apps, and to the external app launcher's threading behavior. We should verify that our external app blocker still asks the user for confirmation in these cases:
https://bugzilla.mozilla.org/show_bug.cgi?id=858234
https://bugzilla.mozilla.org/show_bug.cgi?id=789932
Finally, support for querying and inspecting font variants was introduced. Do our font limit counters still apply in that case? Should they?
https://bugzilla.mozilla.org/show_bug.cgi?id=549861Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/legacy/trac/-/issues/10252TBB based on ESR 24 is not working on Windows2020-06-13T03:20:46ZGeorg KoppenTBB based on ESR 24 is not working on WindowsTesting the patches in #9830 shows that TBB is starting but nothing happens and after a while the process is not visible on the Task Manager anymore.Testing the patches in #9830 shows that TBB is starting but nothing happens and after a while the process is not visible on the Task Manager anymore.https://gitlab.torproject.org/legacy/trac/-/issues/10235Packaging (JavaScript) resources into omni.ja files is non-deterministic in E...2013-12-02T09:48:39ZGeorg KoppenPackaging (JavaScript) resources into omni.ja files is non-deterministic in ESR24Comparing 3.5pre builds made by ln5 showed that at least packaging JavaScript resources into omni.ja files, as it is currently done by Mozilla, can lead to a non-deterministic bundle.Comparing 3.5pre builds made by ln5 showed that at least packaging JavaScript resources into omni.ja files, as it is currently done by Mozilla, can lead to a non-deterministic bundle.Erinn ClarkErinn Clarkhttps://gitlab.torproject.org/legacy/trac/-/issues/10166Gitian should not download Python packages bypassing the Ubuntu repository2020-06-13T03:17:30ZGeorg KoppenGitian should not download Python packages bypassing the Ubuntu repositoryIt turns out that compiling Python ourselves is not enough to build Firefox without downloading additional packages. We should make sure that we either ship the necessary packages ourselves or that they get downloaded from the distro (i....It turns out that compiling Python ourselves is not enough to build Firefox without downloading additional packages. We should make sure that we either ship the necessary packages ourselves or that they get downloaded from the distro (i.e. Ubuntu in our case) archive.Erinn ClarkErinn Clarkhttps://gitlab.torproject.org/legacy/trac/-/issues/10159omni.ja differs in ESR24 Gitian builds2020-06-13T03:20:46ZGeorg Koppenomni.ja differs in ESR24 Gitian buildsTesting two builds with the new OS X cross-compiler showed that browser/omni.ja differed. More exactly, only the contents of chrome.manifest showed some reordering.Testing two builds with the new OS X cross-compiler showed that browser/omni.ja differed. More exactly, only the contents of chrome.manifest showed some reordering.Erinn ClarkErinn Clarkhttps://gitlab.torproject.org/legacy/trac/-/issues/10143FF24's browser/omni.ja has strange archive format2013-11-12T07:43:12ZMike PerryFF24's browser/omni.ja has strange archive formatgitian-bundle.yml is choking on repacking the $LANG variable during localization because the omni.ja has a strange central directory format that unzip does not recognize. :/gitian-bundle.yml is choking on repacking the $LANG variable during localization because the omni.ja has a strange central directory format that unzip does not recognize. :/Erinn ClarkErinn Clarkhttps://gitlab.torproject.org/legacy/trac/-/issues/10139--enable-strip is broken in ESR24 builds for Mac OS X2020-06-13T03:20:46ZGeorg Koppen--enable-strip is broken in ESR24 builds for Mac OS Xhttps://bugzilla.mozilla.org/show_bug.cgi?id=809803 breaks our --enable-strip option. According to froydnj this is a real bug. It is "tracked" in https://bugzilla.mozilla.org/show_bug.cgi?id=841373.https://bugzilla.mozilla.org/show_bug.cgi?id=809803 breaks our --enable-strip option. According to froydnj this is a real bug. It is "tracked" in https://bugzilla.mozilla.org/show_bug.cgi?id=841373.Erinn ClarkErinn Clarkhttps://gitlab.torproject.org/legacy/trac/-/issues/10103Support building FF24 from Gitian2020-06-13T02:39:57ZMike PerrySupport building FF24 from GitianWe should add way to build the new alpha TBBs from a separate versions file from Gitian, so we can build both FF24 and FF17 from the same Gitian builder checkout.
gk also has some patches we should merge when this is ready.We should add way to build the new alpha TBBs from a separate versions file from Gitian, so we can build both FF24 and FF17 from the same Gitian builder checkout.
gk also has some patches we should merge when this is ready.Mike PerryMike Perryhttps://gitlab.torproject.org/legacy/trac/-/issues/10078Make sure torbutton_do_new_identity() is still working properly in ESR242013-12-11T11:43:52ZGeorg KoppenMake sure torbutton_do_new_identity() is still working properly in ESR24We should make sure that all mechanisms to clear state between to sessions are still doing their job. E.g. clearing the SSL session Id should not work anymore with the current code as logout() is gone in Fx 21 (https://bugzilla.mozilla.o...We should make sure that all mechanisms to clear state between to sessions are still doing their job. E.g. clearing the SSL session Id should not work anymore with the current code as logout() is gone in Fx 21 (https://bugzilla.mozilla.org/show_bug.cgi?id=683262) and "security.enable_ssl2" is gone long ago (even "security.enable_ssl3" is gone, in Fx 23).https://gitlab.torproject.org/legacy/trac/-/issues/9896DebugInfo files are not properly created with Firefox 24 ESR2014-02-27T23:48:00ZGeorg KoppenDebugInfo files are not properly created with Firefox 24 ESRFor some reason the debug zip archives are only around 10KByte big (compared to the over 100 MByte with ESR 17).For some reason the debug zip archives are only around 10KByte big (compared to the over 100 MByte with ESR 17).Erinn ClarkErinn Clarkhttps://gitlab.torproject.org/legacy/trac/-/issues/9858unzip breaks bundling TBBs based on Firefox 24 ESR2020-06-13T02:39:06ZGeorg Koppenunzip breaks bundling TBBs based on Firefox 24 ESRWhile un- and rezipping omni.ja is working fine with Firefox 17 ESR it breaks the last stage in creating the TBBs if Firefox 24 ESR is used due the following error:
```
+ unzip ../omni.ja defaults/preferences/000-tor-browser.js
Archive: ...While un- and rezipping omni.ja is working fine with Firefox 17 ESR it breaks the last stage in creating the TBBs if Firefox 24 ESR is used due the following error:
```
+ unzip ../omni.ja defaults/preferences/000-tor-browser.js
Archive: ../omni.ja
warning [../omni.ja]: 3496165 extra bytes at beginning or within zipfile
(attempting to process anyway)
error [../omni.ja]: reported length of central directory is
-3496165 bytes too long (Atari STZip zipfile? J.H.Holm ZIPSPLIT 1.1
zipfile?). Compensating...
inflating: defaults/preferences/000-tor-browser.js
```Erinn ClarkErinn Clarkhttps://gitlab.torproject.org/legacy/trac/-/issues/9837make package is broken for TBB 3.0 based on Firefox 24 ESR2020-06-13T04:58:20ZGeorg Koppenmake package is broken for TBB 3.0 based on Firefox 24 ESRThe output is:
```
+ make -C obj-mingw package INNER_MAKE_PACKAGE=true
make: Entering directory `/home/ubuntu/build/tor-browser/obj-mingw'
make[1]: Entering directory `/home/ubuntu/build/tor-browser/obj-mingw/browser/installer'
make expo...The output is:
```
+ make -C obj-mingw package INNER_MAKE_PACKAGE=true
make: Entering directory `/home/ubuntu/build/tor-browser/obj-mingw'
make[1]: Entering directory `/home/ubuntu/build/tor-browser/obj-mingw/browser/installer'
make export
make[2]: Entering directory `/home/ubuntu/build/tor-browser/obj-mingw/browser/installer'
make[2]: Nothing to be done for `export'.
make[2]: Leaving directory `/home/ubuntu/build/tor-browser/obj-mingw/browser/installer'
make libs
make[2]: Entering directory `/home/ubuntu/build/tor-browser/obj-mingw/browser/installer'
make make-package-internal
make[3]: Entering directory `/home/ubuntu/build/tor-browser/obj-mingw/browser/installer'
/home/ubuntu/build/tor-browser/obj-mingw/_virtualenv/bin/python /home/ubuntu/build/tor-browser/config/Preprocessor.py -DNO_NSPR_10_SUPPORT -DAB_CD=en-US -DMOZ_APP_NAME=firefox -DPREF_DIR=defaults/preferences -DJAREXT= -DMOZ_CHILD_PROCESS_NAME=plugin-container.exe -DMOZ_SHARED_MOZGLUE=1 -DMOZ_JSDEBUGGER -DNECKO_WIFI -DDLL_PREFIX= -DDLL_SUFFIX=.dll -DBIN_SUFFIX=.exe -DBINPATH=bin -DCROSS_COMPILE=1 -DWINVER=0x502 -D_WIN32_WINNT=0x502 -D_WIN32_IE=0x0603 -DMOZ_WINSDK_TARGETVER=0x06010000 -DMOZ_NTDDI_WIN7=0x06010000 -DMOZ_WINSDK_MAXVER=0x06020000 -DX_DISPLAY_MISSING=1 -DJSGC_INCREMENTAL=1 -DMOZ_ENABLE_PROFILER_SPS=1 -DMOZILLA_VERSION=\"24.0\" -DMOZILLA_VERSION_U=24.0 -DMOZILLA_UAVERSION=\"24.0\" -DHAVE_SNPRINTF=1 -D_WINDOWS=1 -DWIN32=1 -DXP_WIN=1 -DXP_WIN32=1 -DHW_THREADS=1 -DSTDC_HEADERS=1 -DWIN32_LEAN_AND_MEAN=1 -DNO_X11=1 -D_X86_=1 -DD_INO=d_ino -DSTDC_HEADERS=1 -DHAVE_STDCALL=1 -DHAVE_SSIZE_T=1 -DHAVE_DIRENT_H=1 -DHAVE_GETOPT_H=1 -DHAVE_MEMORY_H=1 -DHAVE_UNISTD_H=1 -DHAVE_MALLOC_H=1 -DHAVE_IO_H=1 -DHAVE_CPUID_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_CDEFS_H=1 -DNO_X11=1 -DHAVE_STRERROR=1 -DHAVE_SNPRINTF=1 -DHAVE_MEMMOVE=1 -DHAVE_RINT=1 -DHAVE_TRUNCATE64=1 -DHAVE_SETBUF=1 -DHAVE_ISATTY=1 -DHAVE_THREAD_TLS_KEYWORD=1 -DMALLOC_H=\<malloc.h\> -DHAVE_LOCALECONV=1 -DNS_ATTR_MALLOC=__attribute__\(\(malloc\)\) -DNS_WARN_UNUSED_RESULT=__attribute__\(\(warn_unused_result\)\) -DRELEASE_BUILD=1 -DNS_ENABLE_TSF=1 -DMOZ_UPDATE_CHANNEL=default -DMOZ_GOOGLE_API_KEY=no-google-api-key -DEARLY_BETA_OR_EARLIER=1 -DMOZ_PHOENIX=1 -DMOZ_BUILD_APP=browser -DMOZ_PDF_PRINTING=1 -DMOZ_INSTRUMENT_EVENT_LOOP=1 -DMOZ_OFFICIAL_BRANDING=1 -DMOZ_DISTRIBUTION_ID=\"org.mozilla\" -DIBMBIDI=1 -DNS_PRINTING=1 -DNS_PRINT_PREVIEW=1 -DMOZ_SAMPLE_TYPE_FLOAT32=1 -DMOZ_WEBSPEECH=1 -DMOZ_OGG=1 -DATTRIBUTE_ALIGNED_MAX=64 -DMOZ_WEBM=1 -DMOZ_WMF=1 -DMOZ_MEDIA_NAVIGATOR=1 -DMOZ_VP8=1 -DVPX_X86_ASM=1 -DMOZ_WAVE=1 -DMOZ_SPEEX_RESAMPLER=1 -DMOZ_SOUNDTOUCH=1 -DMOZ_CUBEB=1 -DMOZ_VORBIS=1 -DMOZ_OPUS=1 -DENABLE_SYSTEM_EXTENSION_DIRS=1 -DMOZ_GAMEPAD=1 -DBREAKPAD_CUSTOM_STDINT_H=\"mozilla/StandardInteger.h\" -DMOZ_CRASHREPORTER_ENABLE_PERCENT=100 -DLIBJPEG_TURBO_X86_ASM=1 -DMOZ_VERIFY_MAR_SIGNATURE=1 -DMOZ_FEEDS=1 -DMOZ_SAFE_BROWSING=1 -DMOZ_URL_CLASSIFIER=1 -DGL_PROVIDER_=1 -DMOZ_DEBUG_SYMBOLS=1 -DMOZ_LOGGING=1 -DJSGC_INCREMENTAL=1 -DHAVE___CXA_DEMANGLE=1 -DHAVE__UNWIND_BACKTRACE=1 -DJS_DEFAULT_JITREPORT_GRANULARITY=3 -DMOZ_OMNIJAR=1 -DMOZ_USER_DIR=\"Mozilla\" -DMOZ_TREE_PIXMAN=1 -DHAVE_STDINT_H=1 -DHAVE_INTTYPES_H=1 -DMOZ_TREE_CAIRO=1 -DHAVE_UINT64_T=1 -DMOZ_ENABLE_SKIA=1 -DUSE_SKIA=1 -DSKIA_DLL=1 -DGR_DLL=1 -DUSE_SKIA_GPU=1 -DMOZ_XUL=1 -DMOZ_PROFILELOCKING=1 -DBUILD_CTYPES=1 -DMOZ_PLACES=1 -DMOZ_SOCIAL=1 -DMOZ_SERVICES_COMMON=1 -DMOZ_SERVICES_CRYPTO=1 -DMOZ_SERVICES_HEALTHREPORT=1 -DMOZ_SERVICES_METRICS=1 -DMOZ_SERVICES_SYNC=1 -DMOZ_MACBUNDLE_ID=org.mozilla.torbrowser -DMOZ_B2G_VERSION=\"1.0.0\" -DMOZ_B2G_OS_NAME=\"\" -DMOZ_APP_UA_NAME=\"\" -DMOZ_APP_UA_VERSION=\"24.0\" -DFIREFOX_VERSION=24.0 -DMOZ_UA_BUILDID=\"20100101\" -DMOZ_TELEMETRY_DISPLAY_REV=2 -DMOZ_DATA_REPORTING=1 -DMOZ_DLL_SUFFIX=\".dll\" /home/ubuntu/build/tor-browser/browser/installer/package-manifest.in > package-manifest
OMNIJAR_NAME=omni.ja \
/home/ubuntu/build/tor-browser/obj-mingw/_virtualenv/bin/python /home/ubuntu/build/tor-browser/toolkit/mozapps/installer/packager.py -DNO_NSPR_10_SUPPORT -DAB_CD=en-US -DMOZ_APP_NAME=firefox -DPREF_DIR=defaults/preferences -DJAREXT= -DMOZ_CHILD_PROCESS_NAME=plugin-container.exe -DMOZ_SHARED_MOZGLUE=1 -DMOZ_JSDEBUGGER -DNECKO_WIFI -DDLL_PREFIX= -DDLL_SUFFIX=.dll -DBIN_SUFFIX=.exe -DBINPATH=bin \
--format omni \
--removals /home/ubuntu/build/tor-browser/browser/installer/removed-files.in \
\
\
\
--optimizejars \
\
package-manifest ../../dist ../../dist/firefox \
Error: /home/ubuntu/build/tor-browser/obj-mingw/browser/installer/package-manifest:35: Missing file(s): bin/uninstall/helper.exe
Error: /home/ubuntu/build/tor-browser/obj-mingw/browser/installer/package-manifest:397: Missing file(s): bin/defaults/preferences/000-tor-browser.js
Traceback (most recent call last):
File "/home/ubuntu/build/tor-browser/toolkit/mozapps/installer/packager.py", line 375, in <module>
main()
File "/home/ubuntu/build/tor-browser/toolkit/mozapps/installer/packager.py", line 328, in main
copier.add(mozpack.path.join(binpath, 'removed-files'), removals)
File "/usr/lib/python2.7/contextlib.py", line 24, in __exit__
self.gen.next()
File "/home/ubuntu/build/tor-browser/python/mozbuild/mozpack/errors.py", line 129, in accumulate
raise AccumulatedErrors()
mozpack.errors.AccumulatedErrors
make[3]: *** [stage-package] Error 1
make[3]: Leaving directory `/home/ubuntu/build/tor-browser/obj-mingw/browser/installer'
make[2]: *** [make-package] Error 2
make[2]: Leaving directory `/home/ubuntu/build/tor-browser/obj-mingw/browser/installer'
make[1]: *** [default] Error 2
make[1]: Leaving directory `/home/ubuntu/build/tor-browser/obj-mingw/browser/installer'
make: *** [package] Error 2
make: Leaving directory `/home/ubuntu/build/tor-browser/obj-mingw'
```Erinn ClarkErinn Clarkhttps://gitlab.torproject.org/legacy/trac/-/issues/9830mingw-w64 compilation of Firefox 24 ESR is broken2020-06-13T03:40:56ZGeorg Koppenmingw-w64 compilation of Firefox 24 ESR is brokenmingw-w64 compilation of Firefox 24 ESR with the current rev (5830) is broken.mingw-w64 compilation of Firefox 24 ESR with the current rev (5830) is broken.Erinn ClarkErinn Clarkhttps://gitlab.torproject.org/legacy/trac/-/issues/9829Firefox ESR 24 does need a newer compiler than gcc 4.22020-06-15T23:16:59ZGeorg KoppenFirefox ESR 24 does need a newer compiler than gcc 4.2Our current Mac toolchain is using gcc 4.2 to cross-compile Firefox for Mac OS X. That is not working anymore without patching.Our current Mac toolchain is using gcc 4.2 to cross-compile Firefox for Mac OS X. That is not working anymore without patching.Erinn ClarkErinn Clarkhttps://gitlab.torproject.org/legacy/trac/-/issues/9828Firefox 24 ESR needs at least Python 2.7 and libgstreamer dev packages on the...2020-06-13T02:39:22ZGeorg KoppenFirefox 24 ESR needs at least Python 2.7 and libgstreamer dev packages on the 10.04 VMUbuntu 10.04, which we use to build the TBB3.0 for Linux, does not ship with Python 2.7, yet Firefox ESR 24 needs it in order to get built.Ubuntu 10.04, which we use to build the TBB3.0 for Linux, does not ship with Python 2.7, yet Firefox ESR 24 needs it in order to get built.Erinn ClarkErinn Clarkhttps://gitlab.torproject.org/legacy/trac/-/issues/9827Get gitian based build process to build TBBs based on Firefox ESR242020-06-13T02:34:46ZGeorg KoppenGet gitian based build process to build TBBs based on Firefox ESR24Currently gitian + Firefox ESR 24 is broken on all supported OSes. This parent ticket keeps track of the related child tickets.Currently gitian + Firefox ESR 24 is broken on all supported OSes. This parent ticket keeps track of the related child tickets.Erinn ClarkErinn Clarkhttps://gitlab.torproject.org/legacy/trac/-/issues/9609Rebase TBB patches to Firefox 242013-10-24T00:27:04ZMike PerryRebase TBB patches to Firefox 24As early as possible, we should begin rebasing our patches to Firefox 24 or maybe even an early beta, so we can understand the scope of the work that will be involved in updating them.As early as possible, we should begin rebasing our patches to Firefox 24 or maybe even an early beta, so we can understand the scope of the work that will be involved in updating them.Mike PerryMike Perryhttps://gitlab.torproject.org/legacy/trac/-/issues/9608Review and audit Firefox changes since Firefox 172020-06-15T23:16:27ZMike PerryReview and audit Firefox changes since Firefox 17As the first step in the the switch to Firefox 24 in November, we'll need to review all of the Firefox for Developers pages, the undocumented bugs, and scan the source code for the appearance of new networking system calls.
Here's the f...As the first step in the the switch to Firefox 24 in November, we'll need to review all of the Firefox for Developers pages, the undocumented bugs, and scan the source code for the appearance of new networking system calls.
Here's the first link:
https://developer.mozilla.org/en-US/Firefox_18_for_developers