Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2020-06-15T23:01:19Zhttps://gitlab.torproject.org/legacy/trac/-/issues/33594Fenix Use of Glean2020-06-15T23:01:19ZShane IsbellFenix Use of GleanGlean is the telemetry library that Fenix uses, which I think we don't want to add to the final apk.
There two ways to handle this
1. Create a TBB project for glean and include it as a compile time dependency in android-components. Th...Glean is the telemetry library that Fenix uses, which I think we don't want to add to the final apk.
There two ways to handle this
1. Create a TBB project for glean and include it as a compile time dependency in android-components. Then we just don't include the aar in the final project, which disables the feature.
2. Patch the Fenix project to not use glean
I'm not that keen on (1) since we have to pull in and configure rust. (2) also seems a bit of a pain because the android-components is going through heavy development would require redoing the patches each time.
I have pref for (2). Thoughts?
Remark from components/browser/engine-gecko-nightly/build.gradle
```
// We only compile against Glean. It's up to the app to add those dependencies
// if it wants to collect GeckoView telemetry through the Glean SDK.
```
Project: https://github.com/mozilla/gleanhttps://gitlab.torproject.org/legacy/trac/-/issues/33683Fenix fingerprinting2020-06-15T23:01:20ZThorinFenix fingerprintingAs I come across Fenix-only items I will add them here for consideration: sysrqb & gk know how to get hold of me if you need a PoC
- toolbar location can be detected
- Settings > Customize > Toolbar > Top/Bottom
- font inflation can ...As I come across Fenix-only items I will add them here for consideration: sysrqb & gk know how to get hold of me if you need a PoC
- toolbar location can be detected
- Settings > Customize > Toolbar > Top/Bottom
- font inflation can be detected
- Settings > Accessibility > Automatic Font Sizing
Feel free to add more itemshttps://gitlab.torproject.org/legacy/trac/-/issues/34066Implement 28005 (https-everywhere onions) in mobile2020-06-15T23:01:23ZAlex CatarineuImplement 28005 (https-everywhere onions) in mobileFor feature parity, consider porting the #28005 patch for mobile.For feature parity, consider porting the #28005 patch for mobile.https://gitlab.torproject.org/legacy/trac/-/issues/34177Audit Fenix code for tracking, fingerprintability, and safety features2020-07-19T04:47:38ZMatthew FinkelAudit Fenix code for tracking, fingerprintability, and safety featuresAudit Fenix code for tracking, fingerprintability, and Tor safety features in relation to various known attacks.
- Audit code changes since last audit for proxy bypass bugs, following our audit procedure.Audit Fenix code for tracking, fingerprintability, and Tor safety features in relation to various known attacks.
- Audit code changes since last audit for proxy bypass bugs, following our audit procedure.https://gitlab.torproject.org/legacy/trac/-/issues/34179Test migration logic from Fennec to Fenix2020-06-15T23:01:24ZMatthew FinkelTest migration logic from Fennec to FenixImplement and test migration logic to allow users to seamlessly upgrade from Tor Browser for Android based on Gecko to Tor Browser for Android based on Fenix.Implement and test migration logic to allow users to seamlessly upgrade from Tor Browser for Android based on Gecko to Tor Browser for Android based on Fenix.https://gitlab.torproject.org/legacy/trac/-/issues/34181Fix broken Fenix tests2020-06-15T23:01:25ZMatthew FinkelFix broken Fenix testshttps://gitlab.torproject.org/legacy/trac/-/issues/34378Port external helper app prompting before opening to Fenix2020-06-15T23:01:25ZGeorg KoppenPort external helper app prompting before opening to FenixIn #26529 we ported the desktop capability to prompt before opening external apps to mobile. We need to redo that proxy-bypass-protection part for Fenix.In #26529 we ported the desktop capability to prompt before opening external apps to mobile. We need to redo that proxy-bypass-protection part for Fenix.https://gitlab.torproject.org/legacy/trac/-/issues/34401Re-design Connect screen on Android2020-06-15T23:01:26ZMatthew FinkelRe-design Connect screen on AndroidFennec has an initial Connect screen (with a gear/cog for accessing Network Settings).
Maybe we skip this with #29590.Fennec has an initial Connect screen (with a gear/cog for accessing Network Settings).
Maybe we skip this with #29590.https://gitlab.torproject.org/legacy/trac/-/issues/34402Re-design Network Settings Screen on Android2020-06-15T23:01:26ZMatthew FinkelRe-design Network Settings Screen on Android- Enable Bridges
- Select a built-in transport type
- Configure custom bridges- Enable Bridges
- Select a built-in transport type
- Configure custom bridgeshttps://gitlab.torproject.org/legacy/trac/-/issues/34403UI changes for "Only Private Browsing Mode" on Android2020-06-15T23:01:27ZMatthew FinkelUI changes for "Only Private Browsing Mode" on AndroidWhen Tor Browser starts, it should only allow private browsing. Do we need to change anything in the UI?When Tor Browser starts, it should only allow private browsing. Do we need to change anything in the UI?https://gitlab.torproject.org/legacy/trac/-/issues/34405Re-design about:tor on Android2020-06-15T23:01:27ZMatthew FinkelRe-design about:tor on AndroidMaybe it "just works", but maybe we need to redesign and reimplement it.Maybe it "just works", but maybe we need to redesign and reimplement it.https://gitlab.torproject.org/legacy/trac/-/issues/34406Re-design onion indicators for Android2020-06-15T23:01:28ZMatthew FinkelRe-design onion indicators for AndroidReimplement security indicators for .onion addresses.Reimplement security indicators for .onion addresses.https://gitlab.torproject.org/legacy/trac/-/issues/34407Review all Fenix menu items2020-06-15T23:01:28ZMatthew FinkelReview all Fenix menu itemsReview all menu items. Can we hide/delete some? Can we repurpose any?Review all menu items. Can we hide/delete some? Can we repurpose any?https://gitlab.torproject.org/legacy/trac/-/issues/34408Re-design New Identity on Android2020-06-15T23:01:28ZMatthew FinkelRe-design New Identity on AndroidCurrently, "New Identity" for Android Tor Browser only changes tor circuits, it does not clear browser state (cookies, storage, cached data).
We should get the current implementation "for free".
See also #28800Currently, "New Identity" for Android Tor Browser only changes tor circuits, it does not clear browser state (cookies, storage, cached data).
We should get the current implementation "for free".
See also #28800https://gitlab.torproject.org/legacy/trac/-/issues/34409Implement Onion Location UI on Android2020-06-15T23:01:29ZMatthew FinkelImplement Onion Location UI on Android".onion available"".onion available"https://gitlab.torproject.org/legacy/trac/-/issues/34410Implement Moat on Android2020-06-15T23:01:29ZMatthew FinkelImplement Moat on AndroidMaybe this will be invisible in the background for #34401, but it will be useful as another option in #34402.Maybe this will be invisible in the background for #34401, but it will be useful as another option in #34402.https://gitlab.torproject.org/legacy/trac/-/issues/34421Clear clipboard at exit on Android2020-06-15T23:01:30ZMatthew FinkelClear clipboard at exit on AndroidWe received a request to clear the clipboard when the app exits.
On Desktop, usually the clipboard is maintained by the source application, so the clipboard is "cleared" when the browser exits.We received a request to clear the clipboard when the app exits.
On Desktop, usually the clipboard is maintained by the source application, so the clipboard is "cleared" when the browser exits.https://gitlab.torproject.org/legacy/trac/-/issues/34427Make sure SessionStorage is not used in PBM on Android2020-07-19T04:47:38ZMatthew FinkelMake sure SessionStorage is not used in PBM on AndroidIn Android-Components:
`components/browser/session/src/main/java/mozilla/components/browser/session/storage/SessionStorage.kt`
Make sure Fenix doesn't use it in PBM.In Android-Components:
`components/browser/session/src/main/java/mozilla/components/browser/session/storage/SessionStorage.kt`
Make sure Fenix doesn't use it in PBM.https://gitlab.torproject.org/legacy/trac/-/issues/34428Handle CustomTabs safely on Android2020-07-19T04:47:39ZMatthew FinkelHandle CustomTabs safely on AndroidMake sure this is safe in Fenix
https://github.com/mozilla-mobile/android-components/blob/v44.0.1/components/feature/customtabs/src/main/java/mozilla/components/feature/customtabs/CustomTabWindowFeature.kt#L86
And PendingIntent
https:/...Make sure this is safe in Fenix
https://github.com/mozilla-mobile/android-components/blob/v44.0.1/components/feature/customtabs/src/main/java/mozilla/components/feature/customtabs/CustomTabWindowFeature.kt#L86
And PendingIntent
https://github.com/mozilla-mobile/android-components/blob/v44.0.1/components/feature/customtabs/src/main/java/mozilla/components/feature/customtabs/CustomTabsToolbarFeature.kt#L260https://gitlab.torproject.org/legacy/trac/-/issues/34429Check the DigitalAssetLinksHandler's use of the Fetch client is FPI2020-07-19T04:47:39ZMatthew FinkelCheck the DigitalAssetLinksHandler's use of the Fetch client is FPIhttps://github.com/mozilla-mobile/android-components/blob/v44.0.1/components/feature/customtabs/src/main/java/mozilla/components/feature/customtabs/verify/DigitalAssetLinksHandler.kt#L50https://github.com/mozilla-mobile/android-components/blob/v44.0.1/components/feature/customtabs/src/main/java/mozilla/components/feature/customtabs/verify/DigitalAssetLinksHandler.kt#L50https://gitlab.torproject.org/legacy/trac/-/issues/34430Understand how the FilePicker launches external apps2020-06-15T23:01:31ZMatthew FinkelUnderstand how the FilePicker launches external appshttps://github.com/mozilla-mobile/android-components/blob/v44.0.1/components/feature/prompts/src/main/java/mozilla/components/feature/prompts/file/FilePicker.kt#L62https://github.com/mozilla-mobile/android-components/blob/v44.0.1/components/feature/prompts/src/main/java/mozilla/components/feature/prompts/file/FilePicker.kt#L62https://gitlab.torproject.org/legacy/trac/-/issues/34431Make sure Fenix doesn't save history on disk2020-06-15T23:01:31ZMatthew FinkelMake sure Fenix doesn't save history on diskhttps://github.com/mozilla-mobile/android-components/blob/v44.0.1/components/feature/session/src/main/java/mozilla/components/feature/session/HistoryDelegate.kthttps://github.com/mozilla-mobile/android-components/blob/v44.0.1/components/feature/session/src/main/java/mozilla/components/feature/session/HistoryDelegate.kthttps://gitlab.torproject.org/legacy/trac/-/issues/34440Audit AndroidX libraries?2020-07-19T04:50:58ZMatthew FinkelAudit AndroidX libraries?#33939
> {{{
> > # More AndroidX com...#33939
> {{{
> > # More AndroidX compatibility libraries
> > androidx_legacy -> androidx.legacy:legacy-support-v4
> > androidx_paging -> androidx.paging:paging-runtime-ktx
> > androidx_preference -> androidx.preference:preference-ktx
> > androidx_fragment -> androidx.fragment:fragment-ktx
> > androidx_navigation_fragment -> androidx.navigation:navigation-fragment-ktx
> > androidx_navigation_ui -> androidx.navigation:navigation-ui
> > androidx_recyclerview -> androidx.recyclerview:recyclerview
> > androidx_lifecycle_livedata -> androidx.lifecycle:lifecycle-livedata-ktx
> > androidx_lifecycle_runtime -> androidx.lifecycle:lifecycle-runtime-ktx
> > androidx_lifecycle_viewmodel -> androidx.lifecycle:lifecycle-viewmodel-ktx
> > androidx_core -> androidx.core:core
> > androidx_core_ktx -> androidx.core:core-ktx
> > androidx_transition -> androidx.transition:transition
> > androidx_work_ktx -> androidx.work:work-runtime-ktx
> }}}https://gitlab.torproject.org/legacy/trac/-/issues/34441Audit Material Components library?2020-07-19T04:50:58ZMatthew FinkelAudit Material Components library?https://github.com/material-components/material-components-android/tree/1.1.0
`com.google.android.material.snackbar.Snackbar`
`com.google.android.material.appbar.AppBarLayout`https://github.com/material-components/material-components-android/tree/1.1.0
`com.google.android.material.snackbar.Snackbar`
`com.google.android.material.appbar.AppBarLayout`https://gitlab.torproject.org/legacy/trac/-/issues/34442Audit Flexbox?2020-07-19T04:50:58ZMatthew FinkelAudit Flexbox?https://github.com/google/flexbox-layout/tree/2.0.1
`com.google.android.flexbox.FlexboxLayoutManager`https://github.com/google/flexbox-layout/tree/2.0.1
`com.google.android.flexbox.FlexboxLayoutManager`https://gitlab.torproject.org/legacy/trac/-/issues/34443Audit Lottie?2020-07-19T04:50:58ZMatthew FinkelAudit Lottie?https://github.com/airbnb/lottie-androidhttps://github.com/airbnb/lottie-androidhttps://gitlab.torproject.org/legacy/trac/-/issues/34450Warn about proxy-bypass when opening external apps on Android2020-06-15T23:01:33ZMatthew FinkelWarn about proxy-bypass when opening external apps on AndroidFollow up from #26529 for FenixFollow up from #26529 for Fenix