Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2020-10-02T06:25:04Zhttps://gitlab.torproject.org/legacy/trac/-/issues/33626Add TBB project for GeckoView2020-10-02T06:25:04ZShane IsbellAdd TBB project for GeckoViewFenix and android-components have dependencies on GeckoView. Need to setup environment to build this for production, beta and nightly. Involves rust and clang setup.Fenix and android-components have dependencies on GeckoView. Need to setup environment to build this for production, beta and nightly. Involves rust and clang setup.Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/legacy/trac/-/issues/34451Include Tor Browser Manual in packages during build2020-06-16T01:26:35ZMatthew FinkelInclude Tor Browser Manual in packages during buildhttps://gitlab.torproject.org/legacy/trac/-/issues/34434Remove unused $var: 1 declarations in rbm.conf2020-06-16T01:26:35ZGeorg KoppenRemove unused $var: 1 declarations in rbm.confThere are a bunch of unused $var: 1 declarations in `rbm.conf` (that is they don't have a matching `[% c("var/$var") %]` check). We should clean that up and keep things tidy so that it is obvious where things need to get added and where ...There are a bunch of unused $var: 1 declarations in `rbm.conf` (that is they don't have a matching `[% c("var/$var") %]` check). We should clean that up and keep things tidy so that it is obvious where things need to get added and where they are not needed.https://gitlab.torproject.org/legacy/trac/-/issues/34432Integrate fenix toolchain into tor-browser-build's master2020-06-16T01:26:35ZGeorg KoppenIntegrate fenix toolchain into tor-browser-build's masterWe decided to not create a new branch to take care of the Fenix toolchain while continuing to build nightly builds with the ESR 68 toolchains (and later ESR 78 toolchains for desktop builds). Rather, we'll follow boklm's idea of namespac...We decided to not create a new branch to take care of the Fenix toolchain while continuing to build nightly builds with the ESR 68 toolchains (and later ESR 78 toolchains for desktop builds). Rather, we'll follow boklm's idea of namespacing the projects to fenix-$project if there are Fenix specific needs and keep everything on `master`. This should avoid diverging branches and a tricky merge at the end.Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/legacy/trac/-/issues/34399Electrum-NMC can't make outgoing connections on Python 3.8+2020-06-16T01:26:34ZJeremyRandElectrum-NMC can't make outgoing connections on Python 3.8+The Electrum-NMC version in Tor Browser is affected by this bug: https://github.com/kyuupichan/aiorpcX/pull/32 . The gist is that Electrum-NMC fails to properly initialize random SOCKS authentication when on Python 3.8+, which causes al...The Electrum-NMC version in Tor Browser is affected by this bug: https://github.com/kyuupichan/aiorpcX/pull/32 . The gist is that Electrum-NMC fails to properly initialize random SOCKS authentication when on Python 3.8+, which causes all outgoing connections to ElectrumX servers to fail with a Python exception. Thus, no Namecoin resolution is possible with those Python versions.
The `master-3.3.11` branch of Electrum-NMC contains a backported fix, which should be usable for Tor Browser. I'll submit a patch for `tor-browser-build` that bumps the Electrum-NMC dependency shortly.
Thanks to yanmaani for reporting the bug.https://gitlab.torproject.org/legacy/trac/-/issues/34398Harden our code signing on macOS for ESR 782020-06-16T01:26:34ZGeorg KoppenHarden our code signing on macOS for ESR 78While #32506 might be not doable during our transition to ESR 78 we might be able to pick up some improvements nevertheless, see:
https://hg.mozilla.org/releases/mozilla-beta/rev/497690887467ccf0709d71fdb1b20d0647388df9While #32506 might be not doable during our transition to ESR 78 we might be able to pick up some improvements nevertheless, see:
https://hg.mozilla.org/releases/mozilla-beta/rev/497690887467ccf0709d71fdb1b20d0647388df9https://gitlab.torproject.org/legacy/trac/-/issues/34391Remove --enable-signmar from .mozconfig files2020-06-16T01:26:33ZGeorg KoppenRemove --enable-signmar from .mozconfig filesSince https://bugzilla.mozilla.org/show_bug.cgi?id=1562952 landed there is no `--enable-signmar` anymore. We should remove it from our Linux .mozconfig files.Since https://bugzilla.mozilla.org/show_bug.cgi?id=1562952 landed there is no `--enable-signmar` anymore. We should remove it from our Linux .mozconfig files.https://gitlab.torproject.org/legacy/trac/-/issues/34390Update build script to remove copying libnssdbm3.so around2020-06-16T01:26:33ZGeorg KoppenUpdate build script to remove copying libnssdbm3.so aroundSince https://bugzilla.mozilla.org/show_bug.cgi?id=1594933 landed there is no `libnssdbm3.so` file built anymore by default.Since https://bugzilla.mozilla.org/show_bug.cgi?id=1594933 landed there is no `libnssdbm3.so` file built anymore by default.https://gitlab.torproject.org/legacy/trac/-/issues/34388Update lucetc and wasi-sdk projects to latest ESR 78 code2020-06-16T01:26:32ZGeorg KoppenUpdate lucetc and wasi-sdk projects to latest ESR 78 codeIn order to properly enable WASM sandboxing we should update our `lucetc` and `wasi-sdk` projects to what Mozilla ships in ESR 78.In order to properly enable WASM sandboxing we should update our `lucetc` and `wasi-sdk` projects to what Mozilla ships in ESR 78.https://gitlab.torproject.org/legacy/trac/-/issues/34387Fix Namecoin patches for ESR 782020-06-16T01:26:32ZGeorg KoppenFix Namecoin patches for ESR 78We need to adapt our Namecoin patches to ESR 78We need to adapt our Namecoin patches to ESR 78https://gitlab.torproject.org/legacy/trac/-/issues/34386Fixup clang compilation for Linux2020-06-16T01:26:32ZGeorg KoppenFixup clang compilation for LinuxWe need to fix up our clang compilation for Linux. Right now, with 9.0.1 we get:
```
/var/tmp/build/llvm/projects/compiler-rt/lib/crt/crtbegin.c:86:16: error: section type conflict with '__EH_FRAME_LIST__'
86 | used)) s...We need to fix up our clang compilation for Linux. Right now, with 9.0.1 we get:
```
/var/tmp/build/llvm/projects/compiler-rt/lib/crt/crtbegin.c:86:16: error: section type conflict with '__EH_FRAME_LIST__'
86 | used)) static void (*__fini)(void) = __do_fini;
| ^~~~
/var/tmp/build/llvm/projects/compiler-rt/lib/crt/crtbegin.c:13:28: note: '__EH_FRAME_LIST__' was declared here
13 | __extension__ static void *__EH_FRAME_LIST__[]
| ^~~~~~~~~~~~~~~~~
make[2]: *** [lib/clang/9.0.1/lib/linux/clang_rt.crtbegin-i386.o] Error 1
```https://gitlab.torproject.org/legacy/trac/-/issues/34367Use ossligncode's -readpass option2020-06-16T01:26:31ZGeorg KoppenUse ossligncode's -readpass optionI think we should switch to `osslsigncode`'s `-readpass` option to have a better setup when dealing with our passphrase for access to our signing key.I think we should switch to `osslsigncode`'s `-readpass` option to have a better setup when dealing with our passphrase for access to our signing key.https://gitlab.torproject.org/legacy/trac/-/issues/34360Bump binutils version to 2.342020-06-16T01:26:31ZGeorg KoppenBump binutils version to 2.34We are using a rather old binutils version. Let's bump it to the latest, 2.34.We are using a rather old binutils version. Let's bump it to the latest, 2.34.https://gitlab.torproject.org/legacy/trac/-/issues/34359Adapt abicheck.cc to deal with newer GCC version2020-06-16T01:26:30ZGeorg KoppenAdapt abicheck.cc to deal with newer GCC versionWe need to adapt our `abicheck.cc` to work as it is supposed to with GCC 9.We need to adapt our `abicheck.cc` to work as it is supposed to with GCC 9.https://gitlab.torproject.org/legacy/trac/-/issues/34356Consider bundling Python binary on GNU/Linux2020-06-16T01:26:30ZJeremyRandConsider bundling Python binary on GNU/LinuxNamecoin (specifically Electrum-NMC) currently requires Python 3.6+, which is not yet universally available. To avoid incompatibility issues on older GNU/Linux distros, it may be worth considering bundling a Python 3.6+ binary with Tor ...Namecoin (specifically Electrum-NMC) currently requires Python 3.6+, which is not yet universally available. To avoid incompatibility issues on older GNU/Linux distros, it may be worth considering bundling a Python 3.6+ binary with Tor Browser when building with Namecoin is enabled.
(This would have also avoided #33749.)https://gitlab.torproject.org/legacy/trac/-/issues/34355Update entitlement files and other signing related pieces for 9.5 changes and...2020-06-16T01:26:30ZGeorg KoppenUpdate entitlement files and other signing related pieces for 9.5 changes and include fixupsWe have a bunch of scripts in our `tor-browser-build` repo (in `tools/signing`) which show how we do currently a bunch of signing related jobs.
We should update the things that need update for 9.5/10.0a1 (probably both on `master` and, ...We have a bunch of scripts in our `tor-browser-build` repo (in `tools/signing`) which show how we do currently a bunch of signing related jobs.
We should update the things that need update for 9.5/10.0a1 (probably both on `master` and, where applicable, on `maint-9.5` for stable) and go over the `README` again (typo fixing).https://gitlab.torproject.org/legacy/trac/-/issues/34353Create a new subkey for our Tor Browser GPG key2020-06-16T01:26:29ZGeorg KoppenCreate a new subkey for our Tor Browser GPG keyThe currently used GPG subkey for signing our packages is expiring in a couple of weeks. We should create and deploy a new one.The currently used GPG subkey for signing our packages is expiring in a couple of weeks. We should create and deploy a new one.https://gitlab.torproject.org/legacy/trac/-/issues/34301Fix shellcheck issues in our tor-browser-build scripts2020-06-16T01:26:29ZGeorg KoppenFix shellcheck issues in our tor-browser-build scriptsWe add more and more shell scripts for different tasks into our `tor-browser-build` repo, which is great. We should go over the already existing ones and fix `shellcheck` issues.
This is the parent ticket for that effort.We add more and more shell scripts for different tasks into our `tor-browser-build` repo, which is great. We should go over the already existing ones and fix `shellcheck` issues.
This is the parent ticket for that effort.https://gitlab.torproject.org/legacy/trac/-/issues/34234Use Debian 10 for our https-everywhere container image2020-06-16T01:26:28ZboklmUse Debian 10 for our https-everywhere container imageWe are currently using Debian Stretch to build https-everywhere for any platform.
We can update that to Debian 10.
It looks like the https-everywhere build still requires python3.6 while Debian 10 provides version 3.7, so we still need...We are currently using Debian Stretch to build https-everywhere for any platform.
We can update that to Debian 10.
It looks like the https-everywhere build still requires python3.6 while Debian 10 provides version 3.7, so we still need our own build of python3.6. However the update to Debian 10 will allow us to share the python3.6 build with the osx64 and windows builds as they will be using Debian 10 too.https://gitlab.torproject.org/legacy/trac/-/issues/34230Update Windows toolchain for ESR 782020-06-16T01:26:28ZGeorg KoppenUpdate Windows toolchain for ESR 78We need to go over our Windows toolchain and update it wherever needed for ESR 78.We need to go over our Windows toolchain and update it wherever needed for ESR 78.