Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2020-06-13T15:22:20Zhttps://gitlab.torproject.org/legacy/trac/-/issues/25341Remove now-unnecessary Rust linking workaround2020-06-13T15:22:20ZIsis LovecruftRemove now-unnecessary Rust linking workaroundWe've got the following stanza in our `configure.ac`:
```
dnl This is a workaround for #46797
dnl (a.k.a https://github.com/rust-lang/rust/issues/46797 ). O...We've got the following stanza in our `configure.ac`:
```
dnl This is a workaround for #46797
dnl (a.k.a https://github.com/rust-lang/rust/issues/46797 ). Once the
dnl upstream bug is fixed, we can remove this workaround.
case "$host_os" in
darwin*)
TOR_RUST_EXTRA_LIBS="-lresolv"
;;
esac
```
It looks like https://github.com/rust-lang/rust/issues/46797 has been resolved as of 22 January 2018, so we can probably remove this workaround now! (Someone who is on MacOS should probably test this, I don't have access to any Macs right now.)Tor: 0.4.0.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/24000circuit_send_intermediate_onion_skin() and extend_cell_format() should check ...2020-06-13T15:16:19Zteorcircuit_send_intermediate_onion_skin() and extend_cell_format() should check for IPv6When circuit_send_intermediate_onion_skin() and extend_cell_format() handle tor_addr_t, they assume they are IPv4.
But in #23502, we almost wrote code that sent them an IPv6 address. In this case, they put 0.0.0.0 in the extend cell, bu...When circuit_send_intermediate_onion_skin() and extend_cell_format() handle tor_addr_t, they assume they are IPv4.
But in #23502, we almost wrote code that sent them an IPv6 address. In this case, they put 0.0.0.0 in the extend cell, but they could issue a BUG() warning and refuse to send the cell instead.
Or they could send a proper IPv6 link specifier where the extend cell allows it.Tor: unspecified