Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2020-06-13T17:48:43Zhttps://gitlab.torproject.org/legacy/trac/-/issues/33475Remove excessive logging from exitscan py2020-06-13T17:48:43ZirlRemove excessive logging from exitscan pyhttps://gitlab.torproject.org/legacy/trac/-/issues/33471Restart exit scanner service on changes that would need it2020-06-13T17:48:42ZirlRestart exit scanner service on changes that would need itNeeds to split the systemd task out to a handlerNeeds to split the systemd task out to a handlerhttps://gitlab.torproject.org/legacy/trac/-/issues/33467Add an ant task for updating the fallback directory list2020-06-13T18:15:33ZirlAdd an ant task for updating the fallback directory listThe python script fell out of the repository, and adding an ant task should help us get these updates out more quickly.The python script fell out of the repository, and adding an ant task should help us get these updates out more quickly.https://gitlab.torproject.org/legacy/trac/-/issues/33444Minor code cleanup2020-06-13T17:55:23ZTracMinor code cleanupMinor code cleanup including:
1. display meaningful warning if lock file cannot be deleted
2. use faster method calls
3. remove unused method parameters
These changes can be viewed at https://gitlab.com/743zpnpGUq27GgR/exonerator/-/comm...Minor code cleanup including:
1. display meaningful warning if lock file cannot be deleted
2. use faster method calls
3. remove unused method parameters
These changes can be viewed at https://gitlab.com/743zpnpGUq27GgR/exonerator/-/commits/small-cleanup
or cloned via
https://gitlab.com/743zpnpGUq27GgR/exonerator.git
using branch 'small-cleanup'
Feel free to use whatever makes sense and ignore the rest. Thanks! Josh
**Trac**:
**Username**: efgyirfe784https://gitlab.torproject.org/legacy/trac/-/issues/33438OnionPerf: Scalability, Performance, Establishing Baseline Metrics2020-06-13T18:04:27ZGabagaba@torproject.orgOnionPerf: Scalability, Performance, Establishing Baseline MetricsIn this project, the Tor Metrics and Tor Network teams will work together to improve OnionPerf so that it is a useful tool for all developers and researchers. As a result of this project, we will be able to conduct more meaningful experi...In this project, the Tor Metrics and Tor Network teams will work together to improve OnionPerf so that it is a useful tool for all developers and researchers. As a result of this project, we will be able to conduct more meaningful experiments on the Tor network. Enhancing OnionPerf is a critical foundational step in the work to scale the Tor network.
The goals of this project are to:
* Make operational improvements to existing OnionPerf deployments and make it easier to deploy new OnionPerf instances;
* Expand the kinds of measurements OnionPerf can take by making improvements to its codebase; and
* Make improvements to the way we analyze performance metrics.
Teams involved:
network health team
network team
metrics team
research director
More information in https://trac.torproject.org/projects/tor/wiki/org/sponsors/Sponsor59https://gitlab.torproject.org/legacy/trac/-/issues/33433Add error handling for older stem versions2020-06-13T18:04:25ZAna CusturaAdd error handling for older stem versionsCurrently OP fails if the python-stem version required for enabling v3 services is not found. Instead, it should warn the user and either continue with v2 services only, or exit and ask the user to manually exclude v3 services on the com...Currently OP fails if the python-stem version required for enabling v3 services is not found. Instead, it should warn the user and either continue with v2 services only, or exit and ask the user to manually exclude v3 services on the command line.https://gitlab.torproject.org/legacy/trac/-/issues/33424Ensure ExoneraTorDatabaseImporter closes all BufferedReader/Writer objects2020-06-13T17:55:22ZTracEnsure ExoneraTorDatabaseImporter closes all BufferedReader/Writer objectsIf Exceptions occur in ExoneraTorDatabaseImporter's readImportHistoryToMemory() and writeImportHistoryToDisk(), the BufferedReader/Writer object they each use may not be closed.
A proposed solution can be seen at
```
git@gitlab.com:743...If Exceptions occur in ExoneraTorDatabaseImporter's readImportHistoryToMemory() and writeImportHistoryToDisk(), the BufferedReader/Writer object they each use may not be closed.
A proposed solution can be seen at
```
git@gitlab.com:743zpnpGUq27GgR/exonerator.git
in the branch "close-open-bufferedreaders".
```
**Trac**:
**Username**: efgyirfe784https://gitlab.torproject.org/legacy/trac/-/issues/33422Include more events about CBT in results2020-06-13T18:04:24ZAna CusturaInclude more events about CBT in resultshttps://gitlab.torproject.org/legacy/trac/-/issues/33420Add CBT events to Onionperf result files2020-06-13T18:04:23ZAna CusturaAdd CBT events to Onionperf result filesAs I understand this, the results should record whether the CBT was set at the time of measurement. This could just be a CBT_SET True/False field in the tpf results file. The CBT resets in certain conditions, and this should be reflected...As I understand this, the results should record whether the CBT was set at the time of measurement. This could just be a CBT_SET True/False field in the tpf results file. The CBT resets in certain conditions, and this should be reflected in the results. The events should be parsed from the tor logs.
We should check with Mike if this meets the requirements.https://gitlab.torproject.org/legacy/trac/-/issues/33419Add analysis to support static guard measurements2020-06-13T18:04:22ZAna CusturaAdd analysis to support static guard measurementshttps://gitlab.torproject.org/legacy/trac/-/issues/33418Remove tgen submodule from Onionperf codebase2020-06-13T18:04:21ZAna CusturaRemove tgen submodule from Onionperf codebaseWe have a leftover tgen direcotry as part of the Onionperf codebase. This is an artefact from before tgen was moved to shadow, and should be removed since we don't use it in any of the ansible/cloud deployments.We have a leftover tgen direcotry as part of the Onionperf codebase. This is an artefact from before tgen was moved to shadow, and should be removed since we don't use it in any of the ansible/cloud deployments.https://gitlab.torproject.org/legacy/trac/-/issues/33397Update metrics-web to only plot "official" data2020-06-13T18:15:32ZAna CusturaUpdate metrics-web to only plot "official" dataUpdate metrics-web to only plot "official" data based on new metadata field for existing graphs. This depends on implementations described in #33323 and #33391 =>#33393Update metrics-web to only plot "official" data based on new metadata field for existing graphs. This depends on implementations described in #33323 and #33391 =>#33393https://gitlab.torproject.org/legacy/trac/-/issues/33396Automatically compress Onionperf logs2020-06-13T18:04:20ZAna CusturaAutomatically compress Onionperf logsAutomatically compress Onionperf logs to save space. This could be done as part of the log rotation at midnight or separately.Automatically compress Onionperf logs to save space. This could be done as part of the log rotation at midnight or separately.https://gitlab.torproject.org/legacy/trac/-/issues/33395Add option to replace the client and server torrc files2020-06-13T17:48:42ZAna CusturaAdd option to replace the client and server torrc filesAdd support for replacing the client and server torrc files on the command line when deploying an Onionperf measurement.Add support for replacing the client and server torrc files on the command line when deploying an Onionperf measurement.https://gitlab.torproject.org/legacy/trac/-/issues/33394Automatically build Onionperf documentation from Git2020-06-13T17:48:41ZAna CusturaAutomatically build Onionperf documentation from GitThe documentation for Onionperf (https://onionperf.torproject.org/) should be built automatically from the sources in git.The documentation for Onionperf (https://onionperf.torproject.org/) should be built automatically from the sources in git.https://gitlab.torproject.org/legacy/trac/-/issues/33393Add new metadata fields to tpf output.2020-06-13T18:15:33ZAna CusturaAdd new metadata fields to tpf output.Add new metadata fields for experimental measurements to the Onionperf tpf output.Add new metadata fields for experimental measurements to the Onionperf tpf output.https://gitlab.torproject.org/legacy/trac/-/issues/33392Add new metadata fields to json output2020-06-13T18:04:19ZAna CusturaAdd new metadata fields to json outputAdd new metadata fields for experimental measurements to the onionperf json output.Add new metadata fields for experimental measurements to the onionperf json output.https://gitlab.torproject.org/legacy/trac/-/issues/33391Add new metadata fields and definitions2020-06-13T18:15:33ZAna CusturaAdd new metadata fields and definitionsDefine the instance metadata fields to help us differentiate experimental measurements.Define the instance metadata fields to help us differentiate experimental measurements.https://gitlab.torproject.org/legacy/trac/-/issues/33382OnionPerf service file should be just a file2020-06-13T17:48:41ZirlOnionPerf service file should be just a fileI noticed that the systemd service file for the OnionPerf service doesn't actually contain any variables, so we can just copy this instead of rendering it with Jinja.I noticed that the systemd service file for the OnionPerf service doesn't actually contain any variables, so we can just copy this instead of rendering it with Jinja.https://gitlab.torproject.org/legacy/trac/-/issues/33360IntegerDistribution breaks when given negative values2020-06-13T18:03:04ZKarsten LoesingIntegerDistribution breaks when given negative valuesAs found in #27981, our unit tests fail when being run in 1990.
The reason is that we're using a hard-coded time for sending the request (2013-04-24 12:22:22) and the current system time for determining when we handled the request. We c...As found in #27981, our unit tests fail when being run in 1990.
The reason is that we're using a hard-coded time for sending the request (2013-04-24 12:22:22) and the current system time for determining when we handled the request. We compute the difference of the two timestamps as the time needed for handling the request. But `IntegerDistribution` does not accept negative values.
That's a bug. It should either reject negative values in its `addLong` method, or it should store them and include them in the result. I'd prefer the second variant, even though we're not using it for negative values under normal circumstances.
Not blocking the upcoming 8.0 protocol update.