Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2020-06-13T14:48:06Zhttps://gitlab.torproject.org/legacy/trac/-/issues/16800Raise tortls unit test coverage as high as possible2020-06-13T14:48:06ZNick MathewsonRaise tortls unit test coverage as high as possibleOur TLS wrappers really ought to be completely covered by unit tests of one kind or another. Right now, they're among the worst-covered functions in src/common:
```
x/tortls.c.gcov 593 355 37.45
TOTAL 593 355 37.45
```
It might also be...Our TLS wrappers really ought to be completely covered by unit tests of one kind or another. Right now, they're among the worst-covered functions in src/common:
```
x/tortls.c.gcov 593 355 37.45
TOTAL 593 355 37.45
```
It might also be a good idea to split up these functions into backend wrappers vs functions based on those wrappers for how tor uses TLSTor: 0.2.8.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/16796Raise coverage on containers, di_ops to 100%2020-06-13T14:48:04ZNick MathewsonRaise coverage on containers, di_ops to 100%These modules could be at 100% unit test coverage, and they should be.These modules could be at 100% unit test coverage, and they should be.Tor: 0.2.7.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/16794All cryptography unit test coverage should be over 95%; all should have test ...2020-06-13T14:57:00ZNick MathewsonAll cryptography unit test coverage should be over 95%; all should have test vectorsIt's high, but it's not there yet:
```
x/crypto.c.gcov 204 738 78.34
x/crypto_curve25519.c.gcov 8 74 90.24
x/crypto_ed25519.c.gcov 17 95 84.82
x/crypto_format.c.gcov 5 95 95.00
x/crypto_pwbox.c.gcov 2 59 96.72
x/crypto_s2k.c.gcov 14 152...It's high, but it's not there yet:
```
x/crypto.c.gcov 204 738 78.34
x/crypto_curve25519.c.gcov 8 74 90.24
x/crypto_ed25519.c.gcov 17 95 84.82
x/crypto_format.c.gcov 5 95 95.00
x/crypto_pwbox.c.gcov 2 59 96.72
x/crypto_s2k.c.gcov 14 152 91.57
x/aes.c.gcov 0 17 100.00
TOTAL 250 1230 83.11
```Tor: 0.2.9.x-finalNick MathewsonNick Mathewson