Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2020-06-13T15:10:13Zhttps://gitlab.torproject.org/legacy/trac/-/issues/22626Missing stream NULL check in tor_compress_impl2020-06-13T15:10:13ZteorMissing stream NULL check in tor_compress_implThe second time we create a stream in tor_compress_impl, we don't check if it's NULL.The second time we create a stream in tor_compress_impl, we don't check if it's NULL.Tor: 0.3.1.x-finalAlexander Færøyahf@torproject.orgAlexander Færøyahf@torproject.orghttps://gitlab.torproject.org/legacy/trac/-/issues/22628ZSTD_decompressStream doesn't ever say TOR_COMPRESS_BUFFER_FULL2020-06-13T15:10:13ZteorZSTD_decompressStream doesn't ever say TOR_COMPRESS_BUFFER_FULLInstead, it causes an error if it runs out of buffer space.Instead, it causes an error if it runs out of buffer space.Tor: 0.3.1.x-finalAlexander Færøyahf@torproject.orgAlexander Færøyahf@torproject.orghttps://gitlab.torproject.org/legacy/trac/-/issues/22629tor_compress_impl() ignores trailing input garbage when decompressing2020-06-13T15:10:14Zteortor_compress_impl() ignores trailing input garbage when decompressingIn `case TOR_COMPRESS_OK:`, it will happily report success when in_len is non-zero.In `case TOR_COMPRESS_OK:`, it will happily report success when in_len is non-zero.Tor: 0.3.1.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/legacy/trac/-/issues/22669When sending cached_dir_t objects compressed with zlib, do not claim zstd com...2020-06-13T15:10:22ZNick MathewsonWhen sending cached_dir_t objects compressed with zlib, do not claim zstd compression.Right now our code in handle_status_vote sends cached_dir_t objects in their deflated variant when compression is negotiated... but it claims to have compressed them with zstd when both sides support that.
This has been a bit of a heise...Right now our code in handle_status_vote sends cached_dir_t objects in their deflated variant when compression is negotiated... but it claims to have compressed them with zstd when both sides support that.
This has been a bit of a heisenbug, since it only happens when we're downloading votes, which doesn't happen with the usual timing on chutney.Tor: 0.3.1.x-finalNick MathewsonNick Mathewson