Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2020-06-13T15:29:14Zhttps://gitlab.torproject.org/legacy/trac/-/issues/27093Consistently use ${abs_top_srcdir:-../../..} in test_rust.sh2020-06-13T15:29:14ZteorConsistently use ${abs_top_srcdir:-../../..} in test_rust.shSometimes we just use ${abs_top_srcdir}Sometimes we just use ${abs_top_srcdir}Tor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/27091Configure jenkins with CARGO_HOME in a writeable directory2020-06-13T15:29:13ZteorConfigure jenkins with CARGO_HOME in a writeable directoryOr develop a workaround in the tor build scripts.Or develop a workaround in the tor build scripts.Tor: unspecifiedhttps://gitlab.torproject.org/legacy/trac/-/issues/27090Travis: enable lzma and zstd in configure, if available2020-06-13T15:32:11ZteorTravis: enable lzma and zstd in configure, if availableOtherwise, we can break lzma or zstd detection without knowing it.Otherwise, we can break lzma or zstd detection without knowing it.Tor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/27088Pass MODULES_OPTIONS in DISTCHECK_CONFIGURE_FLAGS2020-06-13T15:29:12ZteorPass MODULES_OPTIONS in DISTCHECK_CONFIGURE_FLAGSOops, it seems we missed this one.Oops, it seems we missed this one.Tor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/27087Run a single asciidoc build in Travis2020-06-13T15:29:12ZteorRun a single asciidoc build in TravisWe --disable-asciidoc on all our builds, and maybe we shouldn'tWe --disable-asciidoc on all our builds, and maybe we shouldn'tTor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/26972Create make target to ensure that all Rust files have been formatted with rus...2020-06-13T15:28:51ZChelsea KomloCreate make target to ensure that all Rust files have been formatted with rustfmtWe should have a CI task that ensures Rust files have been properly formatted- this will be helpful when reviewing PRs.
Other linting tooling can be added here in the future (for example, any clippy warnings we want to explicitly check...We should have a CI task that ensures Rust files have been properly formatted- this will be helpful when reviewing PRs.
Other linting tooling can be added here in the future (for example, any clippy warnings we want to explicitly check) but starting with rustfmt seems like a good first step.
It looks like running rustfmt with `--check` will be helpful here: https://github.com/rust-lang-nursery/rustfmt#runningTor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/26952Try enabling ccache on Travis2020-06-13T15:28:46ZteorTry enabling ccache on TravisBased on my branch in #24629.Based on my branch in #24629.Tor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/26497set CARGO_HOME correctly or stop using it2020-06-13T15:27:10ZTaylor Yuset CARGO_HOME correctly or stop using itIt looks like we set `CARGO_HOME` incorrectly for invocations of both `cargo build` and `cargo test`. The `cargo build` invocations work because we first `cd` to the directory containing the `.cargo` directory. The `cargo test` invocat...It looks like we set `CARGO_HOME` incorrectly for invocations of both `cargo build` and `cargo test`. The `cargo build` invocations work because we first `cd` to the directory containing the `.cargo` directory. The `cargo test` invocations don't work for out-of-source-tree builds. #26455 contains a more minimal fix.
The setting of `CARGO_HOME` is redundant if we `cd` to the correct directory first. Or we could stop changing directories and instead set `CARGO_HOME` correctly. We probably shouldn't do both because it's confusing and possibly inconsistent.Tor: 0.3.5.x-final