Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2020-06-16T01:05:06Zhttps://gitlab.torproject.org/legacy/trac/-/issues/30888Minimize torbutton globals exposed in browser window2020-06-16T01:05:06ZAlex CatarineuMinimize torbutton globals exposed in browser windowRight now there are a number of variables and functions that are exposed globally in the browser window, from `chrome/content/{tor-circuit-display.js,torbutton_util.js,torbutton.js}`. We should make sure the globally available symbols ar...Right now there are a number of variables and functions that are exposed globally in the browser window, from `chrome/content/{tor-circuit-display.js,torbutton_util.js,torbutton.js}`. We should make sure the globally available symbols are only the strictly necessary.https://gitlab.torproject.org/legacy/trac/-/issues/30851Move torbutton default prefs to 000-tor-browser.js2020-06-16T01:05:03ZAlex CatarineuMove torbutton default prefs to 000-tor-browser.jsNow they are loaded manually from several places in torbutton components and modules (via `torbutton/modules/default-prefs.js`). We should move these to tor-browser `000-tor-browser.js` prefs file.Now they are loaded manually from several places in torbutton components and modules (via `torbutton/modules/default-prefs.js`). We should move these to tor-browser `000-tor-browser.js` prefs file.https://gitlab.torproject.org/legacy/trac/-/issues/30850Move not UI-related torbutton.js code to XPCOM component/service2020-06-16T01:28:27ZAlex CatarineuMove not UI-related torbutton.js code to XPCOM component/service`torbutton_init()` is the entry point: we should start there, find out which code does not need to be loaded for every window and move it to a new or existing component.`torbutton_init()` is the entry point: we should start there, find out which code does not need to be loaded for every window and move it to a new or existing component.https://gitlab.torproject.org/legacy/trac/-/issues/28894Remove Torbutton parts of fix for #202442020-06-16T00:59:44ZGeorg KoppenRemove Torbutton parts of fix for #20244When rebasing our patches to esr60 in #25543 the tor-browser patches had been marked as obsolete and omitted as we thought we'd avoid users shooting themselves in their feet by exposing those important preferences on the `about:preferenc...When rebasing our patches to esr60 in #25543 the tor-browser patches had been marked as obsolete and omitted as we thought we'd avoid users shooting themselves in their feet by exposing those important preferences on the `about:preferences#privacy` pane. However, the Torbutton parts still live on in the repo.https://gitlab.torproject.org/legacy/trac/-/issues/28747Remove old NoScript related code (needed for dealing with the XPCOM version)2020-06-16T00:59:06ZGeorg KoppenRemove old NoScript related code (needed for dealing with the XPCOM version)After switching to the new, WebExtensions-based NoScript there is unused code left in Torbutton dealing with the old XPCOM version. We should remove that.After switching to the new, WebExtensions-based NoScript there is unused code left in Torbutton dealing with the old XPCOM version. We should remove that.https://gitlab.torproject.org/legacy/trac/-/issues/28746Remove torbutton_update_isolation_prefs() and torbutton_update_fingerprinting...2020-06-16T01:04:54ZGeorg KoppenRemove torbutton_update_isolation_prefs() and torbutton_update_fingerprinting_prefs()We should not mirror the isolation and fingerprinting prefs in Torbutton. Just set them in the browser and that's it. Those options are not exposed in the browser UI anymore and if a user wants to mess with them they should be on their own.We should not mirror the isolation and fingerprinting prefs in Torbutton. Just set them in the browser and that's it. Those options are not exposed in the browser UI anymore and if a user wants to mess with them they should be on their own.