Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2020-06-13T18:34:57Zhttps://gitlab.torproject.org/legacy/trac/-/issues/12190Pyptlib does not join args or optargs correctly in ClientTransportPlugin.repo...2020-06-13T18:34:57ZTracPyptlib does not join args or optargs correctly in ClientTransportPlugin.reportMethodSuccessIn ClientTransportPlugin.reportMethodSuccess, the code for joining the params args and optargs is wrong. The args and optargs params are defined as strings when they should be lists of strings.
Current code
{{{#!python
if ar...In ClientTransportPlugin.reportMethodSuccess, the code for joining the params args and optargs is wrong. The args and optargs params are defined as strings when they should be lists of strings.
Current code
{{{#!python
if args and len(args) > 0:
methodLine = methodLine + ' ARGS=' + args.join(',')
if optArgs and len(optArgs) > 0:
methodLine = methodLine + ' OPT-ARGS=' + args.join(',')
}}}
Fixed Code
{{{#!python
if args and len(args) > 0:
methodLine = methodLine + ' ARGS=' + ','.join(args)
if optArgs and len(optArgs) > 0:
methodLine = methodLine + ' OPT-ARGS=' + ','.join(optArgs)
}}}
Also the documentation for the types of args and optArgs should be changed to lists.
**Trac**:
**Username**: RushingWookie