Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2020-06-13T14:53:13Zhttps://gitlab.torproject.org/legacy/trac/-/issues/17983Build tor with -ftrapv by default2020-06-13T14:53:13ZteorBuild tor with -ftrapv by defaultIf the CFLAGS passed to tor don't contain -ftrapv (or the undefined behaviour sanitiser), let's build with -ftrapv.
This resolves #13538 non-intrusively, and prevents an entire class of integer safety bugs. (That said, wrapping can hide...If the CFLAGS passed to tor don't contain -ftrapv (or the undefined behaviour sanitiser), let's build with -ftrapv.
This resolves #13538 non-intrusively, and prevents an entire class of integer safety bugs. (That said, wrapping can hide some issues rather than resolving them.)Tor: 0.2.9.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/legacy/trac/-/issues/13753Validate is_canonical more thoroughly2020-06-13T14:40:17ZNick MathewsonValidate is_canonical more thoroughlyWe use is_canonical to tell whether we should extend a circuit over a channel... but we should also double-check it as we are extending that circuit, to make sure we didn't mess up.
Also, we should audit the code that sets is_canonical.We use is_canonical to tell whether we should extend a circuit over a channel... but we should also double-check it as we are extending that circuit, to make sure we didn't mess up.
Also, we should audit the code that sets is_canonical.Tor: unspecified