Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2020-06-13T14:05:59Zhttps://gitlab.torproject.org/legacy/trac/-/issues/1848many "warning: 'struct in_addr' declared inside parameter list" when compiled...2020-06-13T14:05:59ZTracmany "warning: 'struct in_addr' declared inside parameter list" when compiled on OpenBSD 4.8I see many "warning: 'struct in_addr' declared inside parameter list" when I compile Tor-0.2.2.15-alpha on OpenBSD 4.8 (that's -current at the moment). The binary that I get seems to work fine though. For comparision, I don't see these w...I see many "warning: 'struct in_addr' declared inside parameter list" when I compile Tor-0.2.2.15-alpha on OpenBSD 4.8 (that's -current at the moment). The binary that I get seems to work fine though. For comparision, I don't see these warnings on FreeBSD 8.1.
all output: http://pastebin.org/646438
and a part of the output:
[...]
Making all in or
gcc -DHAVE_CONFIG_H -I. -I../.. -DSHARE_DATADIR="\"/usr/local/share\"" -DLOCALSTATEDIR="\"/usr/local/var\"" -DBINDIR="\"/usr/local/bin\"" -I../../src/common -g -O2 -Wall -g -O2 -fno-strict-aliasing -MT buffers.o -MD -MP -MF .deps/buffers.Tpo -c -o buffers.o buffers.c
In file included from or.h:63,
from buffers.c:14:
/usr/include/arpa/inet.h:74: warning: 'struct in_addr' declared inside parameter list
/usr/include/arpa/inet.h:74: warning: its scope is only this definition or declaration, which is probably not what you want
/usr/include/arpa/inet.h:75: warning: 'struct in_addr' declared inside parameter list
mv -f .deps/buffers.Tpo .deps/buffers.Po
gcc -DHAVE_CONFIG_H -I. -I../.. -DSHARE_DATADIR="\"/usr/local/share\"" -DLOCALSTATEDIR="\"/usr/local/var\"" -DBINDIR="\"/usr/local/bin\"" -I../../src/common -g -O2 -Wall -g -O2 -fno-strict-aliasing -MT circuitbuild.o -MD -MP -MF .deps/circuitbuild.Tpo -c -o circuitbuild.o circuitbuild.c
In file included from or.h:63,
from circuitbuild.c:14:
/usr/include/arpa/inet.h:74: warning: 'struct in_addr' declared inside parameter list
/usr/include/arpa/inet.h:74: warning: its scope is only this definition or declaration, which is probably not what you want
/usr/include/arpa/inet.h:75: warning: 'struct in_addr' declared inside parameter list
mv -f .deps/circuitbuild.Tpo .deps/circuitbuild.Po
gcc -DHAVE_CONFIG_H -I. -I../.. -DSHARE_DATADIR="\"/usr/local/share\"" -DLOCALSTATEDIR="\"/usr/local/var\"" -DBINDIR="\"/usr/local/bin\"" -I../../src/common -g -O2 -Wall -g -O2 -fno-strict-aliasing -MT circuitlist.o -MD -MP -MF .deps/circuitlist.Tpo -c -o circuitlist.o circuitlist.c
In file included from or.h:63,
from circuitlist.c:12:
/usr/include/arpa/inet.h:74: warning: 'struct in_addr' declared inside parameter list
/usr/include/arpa/inet.h:74: warning: its scope is only this definition or declaration, which is probably not what you want
/usr/include/arpa/inet.h:75: warning: 'struct in_addr' declared inside parameter list
mv -f .deps/circuitlist.Tpo .deps/circuitlist.Po
gcc -DHAVE_CONFIG_H -I. -I../.. -DSHARE_DATADIR="\"/usr/local/share\"" -DLOCALSTATEDIR="\"/usr/local/var\"" -DBINDIR="\"/usr/local/bin\"" -I../../src/common -g -O2 -Wall -g -O2 -fno-strict-aliasing -MT circuituse.o -MD -MP -MF .deps/circuituse.Tpo -c -o circuituse.o circuituse.c
In file included from or.h:63,
from circuituse.c:12:
/usr/include/arpa/inet.h:74: warning: 'struct in_addr' declared inside parameter list
/usr/include/arpa/inet.h:74: warning: its scope is only this definition or declaration, which is probably not what you want
/usr/include/arpa/inet.h:75: warning: 'struct in_addr' declared inside parameter list
mv -f .deps/circuituse.Tpo .deps/circuituse.Po
[...]
**Trac**:
**Username**: TasTor: 0.2.2.x-finalRoger DingledineRoger Dingledinehttps://gitlab.torproject.org/legacy/trac/-/issues/1868Assertion n_to_skip + n_to_free == freelists[i].cur_length failed2020-06-13T14:06:08ZTracAssertion n_to_skip + n_to_free == freelists[i].cur_length failedAug 26 03:26:49.050 [Info] directory_send_command(): Downloading consensus from XXX.XXX.XXX.XXX:443 using /tor/status-vote/current/consensus/14C131+27B6B5+49015F+585769+805509+D586D1+E8A9C4+ED03BB.z
Aug 26 03:26:49.050 [Info] run_connect...Aug 26 03:26:49.050 [Info] directory_send_command(): Downloading consensus from XXX.XXX.XXX.XXX:443 using /tor/status-vote/current/consensus/14C131+27B6B5+49015F+585769+805509+D586D1+E8A9C4+ED03BB.z
Aug 26 03:26:49.050 [Info] run_connection_housekeeping(): Expiring non-used OR connection to fd 1048 (XXX.XXX.XXX.XXX:4160) [idle 622].
Aug 26 03:26:49.050 [Info] buf_shrink_freelists(): Cleaning freelist for 4096-byte chunks: length 9, keeping 8, dropping 1.
Aug 26 03:26:49.050 [Error] buf_shrink_freelists(): Bug: buffers.c:281: buf_shrink_freelists: Assertion n_to_skip + n_to_free == freelists[i].cur_length failed; aborting.
Win7x64 Limited Account, vidalia x15 alpha (tor error)
If someone can remind me where the dumps in Windows are thrown I can fetch that also.
**Trac**:
**Username**: funkstarTor: 0.2.2.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/1913Do new IP tests on HUP.2020-06-13T14:06:23ZcypherpunksDo new IP tests on HUP.I run some tor bridges on very dynamic IPs, I would like to send a HUP signal when I receive a new IP and have tor run the IP tests, otherwise takes about 10 or so minutes before the change of IP is discovered by tor.I run some tor bridges on very dynamic IPs, I would like to send a HUP signal when I receive a new IP and have tor run the IP tests, otherwise takes about 10 or so minutes before the change of IP is discovered by tor.https://gitlab.torproject.org/legacy/trac/-/issues/1921Cell statistics warn when being enabled while Tor is running2020-06-13T14:06:24ZKarsten LoesingCell statistics warn when being enabled while Tor is runningMoritz Bartl reports that enabling CellStatistics and sending Tor a HUP signal results in:
```
[warn] connection_or_flush_from_first_active_circuit(): Bug: Cannot
determine insertion time of cell.
```
It's not a bug that a cell was put...Moritz Bartl reports that enabling CellStatistics and sending Tor a HUP signal results in:
```
[warn] connection_or_flush_from_first_active_circuit(): Bug: Cannot
determine insertion time of cell.
```
It's not a bug that a cell was put in the queue when we didn't collect cell statistics and was removed from the queue when we did.Tor: 0.2.2.x-finalKarsten LoesingKarsten Loesinghttps://gitlab.torproject.org/legacy/trac/-/issues/1930Hidden service fails after getting new v2 descriptor2020-06-13T14:06:32ZRoger DingledineHidden service fails after getting new v2 descriptorTried to access a hidden service when my Tor didn't have any circuits ready (I hadn't used it for an hour), and my Tor refused:
{{{
Sep 10 15:12:48.558 [info] connection_ap_handshake_rewrite_and_attach(): Got a hidden service request fo...Tried to access a hidden service when my Tor didn't have any circuits ready (I hadn't used it for an hour), and my Tor refused:
{{{
Sep 10 15:12:48.558 [info] connection_ap_handshake_rewrite_and_attach(): Got a hidden service request for ID 'sw4...'
Sep 10 15:12:48.559 [info] connection_ap_handshake_rewrite_and_attach(): Descriptor is here. Great.
Sep 10 15:12:48.559 [debug] circuit_find_to_cannibalize(): Hunting for a circ to cannibalize: purpose 9, uptime 0, capacity 1, internal 1
Sep 10 15:12:48.559 [debug] new_route_len(): Chosen route length 3 (1934/2502 routers suitable).
^^^ that's the rendezvous circuit
...
Sep 10 15:12:48.571 [info] circuit_get_open_circ_or_launch(): Chose '$99C353AAA6C3BCEBDEA60C26F41A712F7EC444FF...' as intro point for 'sw4...'.
Sep 10 15:12:48.571 [debug] circuit_find_to_cannibalize(): Hunting for a circ to cannibalize: purpose 6, uptime 0, capacity 1, internal 1
Sep 10 15:12:48.571 [debug] new_route_len(): Chosen route length 4 (1934/2502 routers suitable).
^^^ that's the introduction circuit
...
Sep 10 15:12:51.054 [info] connection_ap_handshake_attach_circuit(): found open intro circ 39366 (rend 39365); sending introduction. (stream 3 sec old)
Sep 10 15:12:51.065 [info] rend_client_send_introduction(): Sending an INTRODUCE1 cell
...
Sep 10 15:12:52.280 [info] rend_client_remove_intro_point(): 2 options left for "sw4...".
Sep 10 15:12:52.280 [info] rend_client_introduction_acked(): Got nack for "sw4..." from $99C353AAA6C3BCEBDEA60C26F41A712F7EC444FF. Re-extending circ 39366, this time to $CF91FBA32FDAC4C500F3A3565591F144D5074820.
...
Sep 10 15:12:53.268 [info] rend_client_remove_intro_point(): 1 options left for "sw4...".
Sep 10 15:12:53.268 [info] rend_client_introduction_acked(): Got nack for "sw4..." from $CF91FBA32FDAC4C500F3A3565591F144D5074820. Re-extending circ 39366, this time to $550CC9724FA77C7F9260B93989D22A70654D3B92.
...
Sep 10 15:12:55.559 [info] rend_client_remove_intro_point(): No more intro points remain for "sw4...". Re-fetching descriptor.
Sep 10 15:12:55.559 [debug] rend_client_refetch_v2_renddesc(): Fetching v2 rendezvous descriptor for service sw4...
Sep 10 15:12:55.559 [debug] directory_initiate_command_rend(): anonymized 1, use_begindir 1.
Sep 10 15:12:55.559 [debug] directory_initiate_command_rend(): Initiating hidden-service v2 descriptor fetch
...
Sep 10 15:12:55.572 [info] directory_get_from_hs_dir(): Sending fetch request for v2 descriptor for service 'sw4...' with descriptor ID '22dnx...', auth type 0, and descriptor cookie '[none]' to hidden service directory 'hamakor' on port 80.
...
Sep 10 15:13:00.082 [debug] connection_dir_client_reached_eof(): Received response from directory server '82.80.248.177:443': 200 "OK"
Sep 10 15:13:00.082 [debug] connection_dir_client_reached_eof(): Time on received directory is within tolerance; we are -23 seconds skewed. (That's okay.)
Sep 10 15:13:00.082 [info] connection_dir_client_reached_eof(): Received rendezvous descriptor (size 3250, status 200 ("OK"))
Sep 10 15:13:00.084 [debug] rend_cache_store_v2_desc_as_client(): Successfully stored rend desc 'sw4...', len 3250.
Sep 10 15:13:00.084 [info] connection_dir_client_reached_eof(): Successfully fetched v2 rendezvous descriptor.
Sep 10 15:13:00.084 [info] rend_client_desc_trynow(): Rend desc is usable. Launching circuits.
Sep 10 15:13:00.084 [debug] circuit_get_open_circ_or_launch(): one on the way!
Sep 10 15:13:00.084 [debug] circuit_get_open_circ_or_launch(): one on the way!
Sep 10 15:13:00.084 [info] connection_ap_handshake_attach_circuit(): ready rend circ 39365 already here (no intro-ack yet on intro 39366). (stream 0 sec old)
Sep 10 15:13:00.084 [info] connection_ap_handshake_attach_circuit(): found open intro circ 39366 (rend 39365); sending introduction. (stream 0 sec old)
Sep 10 15:13:00.084 [info] rend_client_send_introduction(): Our introduction point knowledge changed in mid-connect! Could not find intro key; we only have a v2 rend desc with 3 intro points. Giving up.
Sep 10 15:13:00.084 [debug] connection_or_send_destroy(): Sending destroy (circID 39366).
Sep 10 15:13:00.084 [debug] connection_or_send_destroy(): Sending destroy (circID 39365).
Sep 10 15:13:00.084 [warn] Rendezvous attempt failed. Closing.Tor: 0.2.2.x-finalRobert RansomRobert Ransomhttps://gitlab.torproject.org/legacy/trac/-/issues/1956networkstatus_check_consensus_signature() prints wrong stats2020-06-13T14:06:41ZRoger Dingledinenetworkstatus_check_consensus_signature() prints wrong stats```
Sep 20 01:16:33.215 [info] A consensus needs 5 good signatures from recognized authorities for us to accept it. This one has 8. 2 of the authorities we know didn't sign it. It has 2 signatures from authorities we don't recognize.
```...```
Sep 20 01:16:33.215 [info] A consensus needs 5 good signatures from recognized authorities for us to accept it. This one has 8. 2 of the authorities we know didn't sign it. It has 2 signatures from authorities we don't recognize.
```
Wait, it has 8 signatures, and also 2 of the authorities we know didn't sign it? It turns out that second statement is false.
I instrumented my Tor to explain when it bumps various counters in this function, and got this output:
```
Sep 20 01:42:33.344 [notice] Bootstrapped 25%: Loading networkstatus consensus.
Sep 20 01:42:34.337 [notice] looking at new voter tor26: 14C131DFC5C6F93646BE72FA1401C02A8DF2E8B4
Sep 20 01:42:34.337 [notice] looking at new sig 14C131DFC5C6F93646BE72FA1401C02A8DF2E8B4: 0 0 1
Sep 20 01:42:34.338 [notice] ++good_here
Sep 20 01:42:34.338 [notice] ++n_good
Sep 20 01:42:34.338 [notice] looking at new voter ides: 27B6B5996C426270A5C95488AA5BCEB6BCC86956
Sep 20 01:42:34.339 [notice] looking at new sig 27B6B5996C426270A5C95488AA5BCEB6BCC86956: 0 0 1
Sep 20 01:42:34.339 [notice] ++good_here
Sep 20 01:42:34.339 [notice] ++n_good
Sep 20 01:42:34.340 [notice] looking at new voter maatuska: 49015F787433103580E3B66A1707A00E60F2D15B
Sep 20 01:42:34.342 [notice] looking at new sig 49015F787433103580E3B66A1707A00E60F2D15B: 0 0 1
Sep 20 01:42:34.343 [notice] ++good_here
Sep 20 01:42:34.343 [notice] ++n_good
Sep 20 01:42:34.343 [notice] looking at new voter dannenberg: 585769C78764D58426B8B52B6651A5A71137189A
Sep 20 01:42:34.343 [notice] looking at new sig 585769C78764D58426B8B52B6651A5A71137189A: 0 0 1
Sep 20 01:42:34.347 [notice] ++good_here
Sep 20 01:42:34.347 [notice] ++n_good
Sep 20 01:42:34.347 [notice] looking at new voter urras: 80550987E1D626E3EBA5E5E75A458DE0626D088C
Sep 20 01:42:34.347 [notice] looking at new sig 80550987E1D626E3EBA5E5E75A458DE0626D088C: 0 0 1
Sep 20 01:42:34.350 [notice] ++good_here
Sep 20 01:42:34.350 [notice] ++n_good
Sep 20 01:42:34.351 [notice] looking at new voter gabelmoo-legacy: 81349FC1F2DBA2C2C11B45CB9706637D480AB913
Sep 20 01:42:34.351 [notice] looking at new sig 81349FC1F2DBA2C2C11B45CB9706637D480AB913: 0 0 1
Sep 20 01:42:34.351 [notice] ++n_unknown
Sep 20 01:42:34.351 [notice] ++n_no_signature
Sep 20 01:42:34.351 [notice] looking at new voter moria1: D586D18309DED4CD6D57C18FDB97EFA96D330566
Sep 20 01:42:34.352 [notice] looking at new sig D586D18309DED4CD6D57C18FDB97EFA96D330566: 0 0 1
Sep 20 01:42:34.356 [notice] ++good_here
Sep 20 01:42:34.356 [notice] ++n_good
Sep 20 01:42:34.356 [notice] looking at new voter moria1-legacy: E2A2AF570166665D738736D0DD58169CC61D8A8B
Sep 20 01:42:34.356 [notice] looking at new sig E2A2AF570166665D738736D0DD58169CC61D8A8B: 0 0 1
Sep 20 01:42:34.356 [notice] ++n_unknown
Sep 20 01:42:34.357 [notice] ++n_no_signature
Sep 20 01:42:34.357 [notice] looking at new voter dizum: E8A9C45EDE6D711294FADF8E7951F4DE6CA56B58
Sep 20 01:42:34.357 [notice] looking at new sig E8A9C45EDE6D711294FADF8E7951F4DE6CA56B58: 0 0 1
Sep 20 01:42:34.358 [notice] ++good_here
Sep 20 01:42:34.358 [notice] ++n_good
Sep 20 01:42:34.358 [notice] looking at new voter gabelmoo: ED03BB616EB2F60BEC80151114BB25CEF515B226
Sep 20 01:42:34.358 [notice] looking at new sig ED03BB616EB2F60BEC80151114BB25CEF515B226: 0 0 1
Sep 20 01:42:34.359 [notice] ++good_here
Sep 20 01:42:34.359 [notice] ++n_good
Sep 20 01:42:34.360 [warn] Consensus includes unrecognized authority 'gabelmoo-legacy' at 80.190.246.100:8180 (contact n/a; identity 81349FC1F2DBA2C2C11B45CB9706637D480AB913)
Sep 20 01:42:34.360 [warn] Consensus includes unrecognized authority 'moria1-legacy' at 128.31.0.34:9131 (contact n/a; identity E2A2AF570166665D738736D0DD58169CC61D8A8B)
Sep 20 01:42:34.360 [warn] A consensus needs 5 good signatures from recognized authorities for us to accept it. This one has 8. 2 of the authorities we know didn't sign it. It has 2 signatures from authorities we don't recognize.
Sep 20 01:42:34.360 [notice] n_good 8, n_v3_authorities 8, n_required 5, n_missing_key 0
```
So it turns out we're bumping n_no_signature when we're bumping n_unknown. That happens because we end the
```
SMARTLIST_FOREACH_BEGIN(consensus->voters, networkstatus_voter_info_t *,
```
loop without having set good_here, bad_here, etc, so it falls to the bottom of the if statements:
```
} else
++n_no_signature;
```
Something is not right, here. Perhaps it is as simple as "we are mis-describing what n_no_signature means"?Tor: 0.2.2.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/legacy/trac/-/issues/1964Tor 0.2.2.16-alpha seg faults2020-06-13T14:06:43ZRoger DingledineTor 0.2.2.16-alpha seg faultsMy bridge, running git 85cad94221aa7, just seg faulted. I failed to get a core.
Its last words, at log-level info, were
```
Sep 21 02:12:08.038 [info] update_consensus_router_descriptor_downloads(): 0 router descriptors downloadable. 2...My bridge, running git 85cad94221aa7, just seg faulted. I failed to get a core.
Its last words, at log-level info, were
```
Sep 21 02:12:08.038 [info] update_consensus_router_descriptor_downloads(): 0 router descriptors downloadable. 21 delayed; 1837 present (0 of those were in old_routers); 0 would_reject; 0 wouldnt_use; 0 in progress.
Sep 21 02:12:08.039 [info] routerlist_remove_old_routers(): We have 2910 live routers and 3326 old router descriptors.
Sep 21 02:12:21.266 [info] tor_tls_read(): Got a TLS renegotiation from "<cn>"
Sep 21 02:12:21.266 [info] command_process_versions_cell(): Negotiated version 2 with <cn>:43120; sending NETINFO.
Sep 21 02:12:22.144 [info] command_process_netinfo_cell(): Got good NETINFO cell from <cn>:43120; OR connection is now open, using protocol version 2
Sep 21 02:12:23.222 [info] connection_exit_connect_dir(): Opening local connection for anonymized directory exit
Sep 21 02:12:23.429 [info] _connection_free(): Freeing linked Directory connection [writing] with 0 bytes on inbuf, 0 on outbuf.
Sep 21 02:12:23.429 [info] connection_edge_reached_eof(): conn (fd -1) reached eof. Closing.
Sep 21 02:12:23.429 [info] _connection_free(): Freeing linked Exit connection [open] with 0 bytes on inbuf, 0 on outbuf.
Sep 21 02:12:30.080 [info] rep_hist_downrate_old_runs(): Discounting all old stability info by a factor of 0.950000
```Tor: 0.2.2.x-finalSebastian HahnSebastian Hahnhttps://gitlab.torproject.org/legacy/trac/-/issues/1989Tor in OS X bundle uses wrong path for geoip file2020-06-12T23:55:02ZTracTor in OS X bundle uses wrong path for geoip fileSeems that Tor 0.2.2.16-alpha on OS X expects the geoip file in the wrong directory. When running as bridge I see in the log:
[Warning] Failed to open GEOIP file /Library/Tor/share/tor/geoip. We've been configured to see which countrie...Seems that Tor 0.2.2.16-alpha on OS X expects the geoip file in the wrong directory. When running as bridge I see in the log:
[Warning] Failed to open GEOIP file /Library/Tor/share/tor/geoip. We've been configured to see which countries can access us as a bridge, and we need GEOIP information to tell which countries clients are in.
But there is no /Library/Tor on my system. It seems the file woule be /Applications/Vidalia.app/Contents/Resources/geoip by default.
**Trac**:
**Username**: TasTor: 0.2.2.x-finalErinn ClarkErinn Clark