Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2020-06-13T15:34:34Zhttps://gitlab.torproject.org/legacy/trac/-/issues/28611Add `-mstack-protector-guard=global` to CFLAGS instead of `--disable-gcc-hard...2020-06-13T15:34:34ZTracAdd `-mstack-protector-guard=global` to CFLAGS instead of `--disable-gcc-hardening` configure option on Windows?workaround https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86832#c8
Tor compiles fine on Windows mingw gcc 8.2 without `--disable-gcc-hardening` if add `-mstack-protector-guard=global` to CFLAGS
**Trac**:
**Username**: grjworkaround https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86832#c8
Tor compiles fine on Windows mingw gcc 8.2 without `--disable-gcc-hardening` if add `-mstack-protector-guard=global` to CFLAGS
**Trac**:
**Username**: grjTor: unspecifiedhttps://gitlab.torproject.org/legacy/trac/-/issues/25787geoip_load_file() tests don't work on all window build environments2020-06-13T15:24:24ZNick Mathewsongeoip_load_file() tests don't work on all window build environmentsThese tests assume that when the test binary is run, it can see the contents of the builddir at the same location as the original build process. But that isn't always true for windows builds.These tests assume that when the test binary is run, it can see the contents of the builddir at the same location as the original build process. But that isn't always true for windows builds.Tor: 0.3.4.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/legacy/trac/-/issues/23081Tor relay crashes at consensus_diff_queue_diff_work() with assertion in_main_...2020-06-13T15:12:14ZTracTor relay crashes at consensus_diff_queue_diff_work() with assertion in_main_thread() failedWhen I start a relay with latest Tor version, it almost instantly crashes:
```
Aug 02 11:04:45.000 [err] tor_assertion_failed_(): Bug: consdiffmgr.c:1601: consensus_diff_queue_diff_work: Assertion in_main_thread() failed; aborting. (on ...When I start a relay with latest Tor version, it almost instantly crashes:
```
Aug 02 11:04:45.000 [err] tor_assertion_failed_(): Bug: consdiffmgr.c:1601: consensus_diff_queue_diff_work: Assertion in_main_thread() failed; aborting. (on Tor 0.3.1.5-alpha )
Aug 02 11:04:45.000 [err] Bug: Assertion in_main_thread() failed in consensus_diff_queue_diff_work at consdiffmgr.c:1601. (Stack trace not available) (on Tor 0.3.1.5-alpha )
```
OS: Windows 7 SP1 x64
Tor: 0.3.1.5-alpha x64 (custom MSYS2 build)
**Trac**:
**Username**: VortTor: 0.2.9.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/22972tor expert bundle only read the first letter from config2020-06-13T15:11:55ZTractor expert bundle only read the first letter from configif i set a config file with command line argument, its looks like tor read only the first letter.
torrc:
SOCKSPort 1234
Output:
Jul 19 02:28:41.488 [notice] Tor 0.3.0.9 (git-22b3bf094e327093) running on Windo
ws 8 [server] with Libeven...if i set a config file with command line argument, its looks like tor read only the first letter.
torrc:
SOCKSPort 1234
Output:
Jul 19 02:28:41.488 [notice] Tor 0.3.0.9 (git-22b3bf094e327093) running on Windo
ws 8 [server] with Libevent 2.0.22-stable, OpenSSL 1.0.2k and Zlib 1.2.8.
Jul 19 02:28:41.491 [notice] Tor can't help you if you use it wrong! Learn how t
o be safe at https://www.torproject.org/download/download#warning
Jul 19 02:28:41.511 [notice] Read configuration file "c:\users\administrator.ll-
dc02\documents\visual studio 2013\Projects\Lissy Cruuv\unbreakable non-server co
munication\bin\Debug\tor\data\torrc".
Jul 19 02:28:41.520 [warn] The abbreviation 'S' is deprecated. Please use 'Socks
SocketsGroupWritable' instead
Jul 19 02:28:41.520 [warn] Path for GeoIPFile (<default>) is relative and will r
esolve to C:\Users\Administrator.LL-DC02\<default>. Is this what you wanted?
Jul 19 02:28:41.520 [warn] Path for GeoIPv6File (<default>) is relative and will
resolve to C:\Users\Administrator.LL-DC02\<default>. Is this what you wanted?
Jul 19 02:28:41.523 [notice] Opening Socks listener on 127.0.0.1:9050
Jul 19 02:28:42.000 [notice] Bootstrapped 0%: Starting
Jul 19 02:28:43.000 [notice] Starting with guard context "default"
Jul 19 02:28:43.000 [notice] Bootstrapped 80%: Connecting to the Tor network
Jul 19 02:28:45.000 [notice] Bootstrapped 85%: Finishing handshake with first ho
p
Jul 19 02:28:45.000 [notice] Bootstrapped 90%: Establishing a Tor circuit
Jul 19 02:28:45.000 [notice] Tor has successfully opened a circuit. Looks like c
lient functionality is working.
Jul 19 02:28:45.000 [notice] Bootstrapped 100%: Done
**Trac**:
**Username**: lanealucyTor: unspecifiedErinn ClarkErinn Clarkhttps://gitlab.torproject.org/legacy/trac/-/issues/22848Increase default Tor buffer sizes on Windows2020-06-13T15:11:24ZteorIncrease default Tor buffer sizes on WindowsIn #22798, a Windows relay operator discovered that setting
```
ConstrainedSockSize 262144
```
made inbound connections to their relay much faster. (Outbound connections are fast regardless.)
They suspect this is because Tor's networkin...In #22798, a Windows relay operator discovered that setting
```
ConstrainedSockSize 262144
```
made inbound connections to their relay much faster. (Outbound connections are fast regardless.)
They suspect this is because Tor's networking calls turn Windows buffer auto-tuning off.
We should improve this default, because it will help Windows relays be faster. (It shouldn't affect Windows clients, because they only connect out.)
This might be an issue in Tor, or it might be in mingw-64.Tor: unspecifiedhttps://gitlab.torproject.org/legacy/trac/-/issues/22520Incorrect encoding for error message2020-06-13T15:10:04ZTracIncorrect encoding for error messageWhen you try to run "tor --service install" in russian Windows 7 x64 SP1 without administrative priviliges, you will get following error: "OpenSCManager() failed : ╬Єърчрэю т фюёЄєях."
But this is incorrect. Correct message should be "Op...When you try to run "tor --service install" in russian Windows 7 x64 SP1 without administrative priviliges, you will get following error: "OpenSCManager() failed : ╬Єърчрэю т фюёЄєях."
But this is incorrect. Correct message should be "OpenSCManager() failed : Отказано в доступе.".
**Trac**:
**Username**: VortTor: 0.3.1.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/22477Add -Wl,--large-address-aware to tor-for-Windows build chain2020-06-13T15:09:56ZTom Rittertom@ritter.vgAdd -Wl,--large-address-aware to tor-for-Windows build chainThis linker flag gives a 32 bit application the full 4GB address space, effectively doubling the randomization provided by ASLR and making heap spraying slightly more difficult.
See also:
- https://msdn.microsoft.com/en-us/library/wz22...This linker flag gives a 32 bit application the full 4GB address space, effectively doubling the randomization provided by ASLR and making heap spraying slightly more difficult.
See also:
- https://msdn.microsoft.com/en-us/library/wz223b1z.aspx
- https://sourceforge.net/p/mingw-w64/mailman/mingw-w64-public/thread/51DF8445.9050105@gmail.com/Tor: unspecifiedhttps://gitlab.torproject.org/legacy/trac/-/issues/22450Tor works in compatibility mode on Windows 7 and later2020-06-13T15:09:44ZcypherpunksTor works in compatibility mode on Windows 7 and laterThere are two things:
1. Tor.exe process runs in "Windows Vista" OS Context.
2. Tor.exe process runs with Virtualized UAC.There are two things:
1. Tor.exe process runs in "Windows Vista" OS Context.
2. Tor.exe process runs with Virtualized UAC.Tor: unspecifiedhttps://gitlab.torproject.org/legacy/trac/-/issues/22380Make windows log_from_handle() handle partial lines2020-06-13T15:09:26ZNick MathewsonMake windows log_from_handle() handle partial linesSee #2045 for a full description of the problem. With #21654, we fixed the unix case, but the windows case may remain.See #2045 for a full description of the problem. With #21654, we fixed the unix case, but the windows case may remain.Tor: unspecifiedhttps://gitlab.torproject.org/legacy/trac/-/issues/21081tor --service install -options does not work2020-06-13T15:04:58ZTractor --service install -options does not workHello, i use Expert Bundle 0.2.8.11 (git-31e7b47fbebe8caf) and when I try to add Tor service on Windows 10 x64 1607 14393.576 with this command:
c:\Tor>tor --service install -options -f C:\Tor\tor.conf
I got this:
Running on a Post-Win2...Hello, i use Expert Bundle 0.2.8.11 (git-31e7b47fbebe8caf) and when I try to add Tor service on Windows 10 x64 1607 14393.576 with this command:
c:\Tor>tor --service install -options -f C:\Tor\tor.conf
I got this:
Running on a Post-Win2K OS, so we'll assume that the LocalService account exists.
Done with CreateService.
Service installed successfully
Service failed to start : Error Service under the command processing.
In services app same error, but also i see this:
"c:\Tor\tor.exe" --nt-service **"-f" "C:\Tor\tor.conf"**
Maybe issue in quotes, but even if I manually edit this service in regedit to:
"c:\Tor\tor.exe" --nt-service -f C:\Tor\tor.conf
or
"c:\Tor\tor.exe" --nt-service -f tor.conf
I got another error:
Service did not respond to the request in a timely manner.
All other services running fine.
**Trac**:
**Username**: PekaFatTor: unspecifiedcypherpunkscypherpunkshttps://gitlab.torproject.org/legacy/trac/-/issues/18665Make test_util_time pieces pass on windows2020-06-13T14:55:49ZNick MathewsonMake test_util_time pieces pass on windowsThere are some pieces in test_util_time that I disabled to make the tests pass. Presumably these never worked on Windows; but we should re-enable them and make them work.There are some pieces in test_util_time that I disabled to make the tests pass. Presumably these never worked on Windows; but we should re-enable them and make them work.Tor: unspecifiedhttps://gitlab.torproject.org/legacy/trac/-/issues/18308Use a better pattern for "create mutex if not already initialized"2020-06-13T14:54:18ZcypherpunksUse a better pattern for "create mutex if not already initialized"Tor relies on double checked locking for various threading initializations. Double checked locking is not guaranteed to work.
For Posix: 4.11, Memory Synchronization:
http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap04.ht...Tor relies on double checked locking for various threading initializations. Double checked locking is not guaranteed to work.
For Posix: 4.11, Memory Synchronization:
http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap04.html
_Applications shall ensure that access to any memory location by more than one thread of control (threads or processes) is restricted such that no thread of control can read or modify a memory location while another thread of control may be modifying it._
Race conditions:
compat_pthreads.c:threads_initialized
log.c:log_mutex_initialized
Mutex static initialization is supported by pthreads via PTHREAD_MUTEX_INITIALIZER.Tor: unspecifiedhttps://gitlab.torproject.org/legacy/trac/-/issues/18124We never use interface names on Windows, avoid retrieving them2020-06-13T14:53:39ZteorWe never use interface names on Windows, avoid retrieving themWe're scanning local interfaces more often in the tor codebase, so it would be a good idea to optimise get_interface_addresses_win32().
We never use the interface names, so let's avoid retrieving them by passing GAA_FLAG_SKIP_FRIENDLY_N...We're scanning local interfaces more often in the tor codebase, so it would be a good idea to optimise get_interface_addresses_win32().
We never use the interface names, so let's avoid retrieving them by passing GAA_FLAG_SKIP_FRIENDLY_NAME in FLAGS.
Reference documentation:
https://msdn.microsoft.com/en-us/library/windows/desktop/aa365915%28v=vs.85%29.aspxTor: unspecifiedhttps://gitlab.torproject.org/legacy/trac/-/issues/17927Use SRWLock for non-recursive locks on vista and later2020-06-13T14:52:57ZNick MathewsonUse SRWLock for non-recursive locks on vista and laterAfter WinXP, Windows added the SRWLock type, which is generally much faster than CRITICAL_SECTION, and supports RW semantics. It doesn't support recursive usage, though it can be hacked in.
I'm calling this 0.2.??? since we have no evi...After WinXP, Windows added the SRWLock type, which is generally much faster than CRITICAL_SECTION, and supports RW semantics. It doesn't support recursive usage, though it can be hacked in.
I'm calling this 0.2.??? since we have no evidence that locking is anywhere close to our critical path. But who knows; perhaps it is? Or will be, once we do more things in workers?Tor: unspecifiedhttps://gitlab.torproject.org/legacy/trac/-/issues/17197Use CRLF for all text files written on Windows, accept either CRLF or LF on a...2020-06-13T14:49:43ZteorUse CRLF for all text files written on Windows, accept either CRLF or LF on all platformsIn #17501, stem becomes confused because some text files written on Windows use CRLF, and others use LF.
We could use CRLF for all text files written on Windows, and accept either CRLF or LF on all platforms.
Here is a list of files fr...In #17501, stem becomes confused because some text files written on Windows use CRLF, and others use LF.
We could use CRLF for all text files written on Windows, and accept either CRLF or LF on all platforms.
Here is a list of files from DataDirectory with their line endings on Windows:
```
CRLF cached-certs
CRLF cached-consensus
LF cached-descriptors
LF cached-descriptors.new
CRLF cached-microdesc-consensus
LF cached-microdescs
LF cached-microdescs.new
CRLF state
```
We might want to review all files written by tor, including those only written by hidden services and any other components.Tor: unspecifiedhttps://gitlab.torproject.org/legacy/trac/-/issues/17145<tor.exe --service install -options -f ...\torrc> returns Error 1064 on Windows2020-06-13T14:49:22ZTrac<tor.exe --service install -options -f ...\torrc> returns Error 1064 on Windows```
tor --service install -options -f C:\tor\torrc
```
from https://www.torproject.org/docs/faq#NTService failed to start the service (Error 1064: An exception occured in the service when handling the control request).
But other options...```
tor --service install -options -f C:\tor\torrc
```
from https://www.torproject.org/docs/faq#NTService failed to start the service (Error 1064: An exception occured in the service when handling the control request).
But other options works:
```
tor.exe --service install -options ControlPort 9051
```
start the Tor Win32 Service and creates the folder C:\Documents and Settings\LocalService\Application Data\tor - tor.exe works like a client only (no disk torrc file, no relay keys). This is useless because i can't use my torrc and run the relay.
The only way to create a running tor service for a relay is to use the "sc create..." in cmd command line as irc#tor<coderman_> suggested. So this is how it works:
```
sc create "Tor Win32 Service" binPath= "\"C:\tornou\Tor\tor.exe\" --nt-service -f \"C:/tornou/Data/Tor/torrc\""
```
returns ImagePath="C:\tornou\Tor\tor.exe" --nt-service -f "C:/tornou/Data/Tor/torrc" and the service is running.
From this point of view, if nobody will fix the related bug, the https://www.torproject.org/docs/faq#NTService may be updated with this "sc create... working option".
Regards,
torQUES
**Trac**:
**Username**: TORquesTor: unspecifiedhttps://gitlab.torproject.org/legacy/trac/-/issues/14209Implement SOCKSPort windows:path for named pipes2020-06-13T16:09:26ZTracImplement SOCKSPort windows:path for named pipesThis is identical to #12585 SocksSocket except for Windows users wishing to use Named Pipes in this same manner.
Firefox changes to use this (instead of SocksPort) unknown. See https://bugzilla.mozilla.org/show_bug.cgi?id=892114
**Trac...This is identical to #12585 SocksSocket except for Windows users wishing to use Named Pipes in this same manner.
Firefox changes to use this (instead of SocksPort) unknown. See https://bugzilla.mozilla.org/show_bug.cgi?id=892114
**Trac**:
**Username**: anonTor: unspecifiedhttps://gitlab.torproject.org/legacy/trac/-/issues/14137Make Tor tests pass under Wine2020-06-13T14:41:37ZNick MathewsonMake Tor tests pass under WineRight now, there are some failures and some weird warnings when you build Tor with mingw and try to run the unit tests under Wine.
Obviously, this isn't really supported or essential, but it would be nice for unix-based devs if it worked.Right now, there are some failures and some weird warnings when you build Tor with mingw and try to run the unit tests under Wine.
Obviously, this isn't really supported or essential, but it would be nice for unix-based devs if it worked.Tor: unspecifiedhttps://gitlab.torproject.org/legacy/trac/-/issues/13694Ship with native build instructions for windows2020-06-13T14:40:00ZNick MathewsonShip with native build instructions for windowsIn #4520, we removed our mingw native compilation instructions, since they were out-of-date, and out-of-sync with our actual process. We should replace them with something better.
It's not likely to be our exact build process, though: ...In #4520, we removed our mingw native compilation instructions, since they were out-of-date, and out-of-sync with our actual process. We should replace them with something better.
It's not likely to be our exact build process, though: our own binaries are cross-compiled using gitian in order to achieve reproducible builds. We should link to that, but also include a cleaned-up version for people who want to work natively on Windows.Tor: unspecifiedGeorg KoppenGeorg Koppenhttps://gitlab.torproject.org/legacy/trac/-/issues/13231Tor(Windows) don't close ports when killed from service control2020-06-13T14:39:02ZTracTor(Windows) don't close ports when killed from service controlReproduce steps:
1. Extract Tor Browser bundle, and copy "Tor" folder to any directory.
2. Install tor.exe as a service. Wait about 1 minute.
3. Open "services.msc". Restart "Tor Win32 service".
4. Tor failed to restart.
tor.exe was clo...Reproduce steps:
1. Extract Tor Browser bundle, and copy "Tor" folder to any directory.
2. Install tor.exe as a service. Wait about 1 minute.
3. Open "services.msc". Restart "Tor Win32 service".
4. Tor failed to restart.
tor.exe was closed, but these sockets are still opened. So Tor can't open its ports.
<unknown> PID:xxx Prot:TCP LocalP:9150
Expected result:
Tor should close its ports when services.msc order him to stop.
**Trac**:
**Username**: ikurua22Tor: unspecified