Logging of HW Engines is incomplete in crypto.c
Logging of algorithms, when HardwareAccel is used, is incomplete. Based on a brief discussion on tor-dev [1], I'm submitting the following patch to improve the logging features. The reason behind this patch is that I was trying to debug my OpenSSL engine (cryptodev) and was confused that it was only offering DH and RSA acceleration (because the current version didn't log all the algorithms).
I cross referenced the tor spec and I believe I've capture the list of algorithms that tor uses. I don't believe (and I very well could be wrong) that tor uses 3DES in ECB mode, but may use it CBC mode for TLS.
Lastly, I changed the cipher logging string to be more specific as just saying "AES" is ambiguous as to the mode.
For reference, see attached txt file on how the info logging looks with HardwareAccel turned on.
Josh
[1] https://lists.torproject.org/pipermail/tor-dev/2013-October/005677.html
Trac:
Username: jbdatko