Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #10053

Closed
Open
Created Oct 30, 2013 by Trac@tracbot

vidalia-0.2.20: 2 * bad if test ?

I just compiled vidalia-0.2.20 with extra gcc compiler flag -Wlogical-op

It said

vidalia-0.2.20/src/torcontrol/Circuit.cpp:82:17: warning: logical 'and' of mutually exclusive tests is always false [-Wlogical-op]

Source code is

if (c < '0' && c > '9' && c < 'A' && c > 'Z' && c < 'a' && c > 'z')

Suggest swap && for ||

vidalia-0.2.20/src/torcontrol/Stream.cpp:92:17: warning: logical 'and' of mutually exclusive tests is always false [-Wlogical-op]

Duplicate.

Trac:
Username: dcb

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking