make Circuit param a class attribute of Transport, instead of a per-method param
19:47:13 still one transport instance per incoming connection [..] 19:47:41 it's just having circuit as a separate parameter makes it look like you might have multiple 19:47:56 separate parameter of what? 19:48:03 of the received* methods [..] 19:48:14 you are right 19:48:20 also david415 mentioned that. 19:48:28 ah 19:48:38 i would accept a patch that makes circuit an element of the transport class
One of doing this would be, in BaseTransport, define
handshake to do
self.circuit = circuit. Possibly also rename
circuitConnected, since it is a callback and you don't necessarily need to do a handshake.