Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #10342

Closed
Open
Opened Dec 10, 2013 by Ximin Luo@infinity0

make Circuit param a class attribute of Transport, instead of a per-method param

19:47:13 still one transport instance per incoming connection [..] 19:47:41 it's just having circuit as a separate parameter makes it look like you might have multiple 19:47:56 separate parameter of what? 19:48:03 of the received* methods [..] 19:48:14 you are right 19:48:20 also david415 mentioned that. 19:48:28 ah 19:48:38 i would accept a patch that makes circuit an element of the transport class

One of doing this would be, in BaseTransport, define handshake to do self.circuit = circuit. Possibly also rename handshake to circuitConnected, since it is a callback and you don't necessarily need to do a handshake.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#10342