Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #10801

Closed (moved)
Open
Opened Feb 03, 2014 by Nick Mathewson@nickm🥄

parse_bridge_line() does tor_addr_port_lookup(). Perhaps it should parse, not lookup.

The tor_addr_port_lookup() function uses the DNS resolver if it receives a hostname. We don't want to support hostnames in bridge addresses, do we? Nothing in our spec says we do, does it?

Alternatively, if we do want to support hostnames, we should drop the test in test_config.c that does:

    bad_bridge_line_test("a.b.c.d");

Since being on a DNS-hijacking cafe wifi seems to make the test fail, when a.b.c.d does resolve to something.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.2.5.x-final
Milestone
Tor: 0.2.5.x-final
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#10801