Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #10928

Closed (moved)
Open
Opened Feb 17, 2014 by Trac@tracbot

Stat information is not obtained properly in test test_config_check_or_create_data_subdir

The test test_config_check_or_create_data_subdir makes a stat call that is asserted to fail, but then a successful stat call is not made at all. This means that the stat information st is not initialized, and can potentially contain garbage which would mean the permission information used by chmod would be invalid and the chmod call would fail.

The attached patch simply executes stat again (as well as changes test_fail_msg to tt_abort_perror, so information why a step has failed can be better communicated).

Trac:
Username: _x3j11

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.2.5.x-final
Milestone
Tor: 0.2.5.x-final
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#10928