Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #11577

Closed (moved)
Open
Opened Apr 21, 2014 by Karsten Loesing@karsten

Use Gson to format/parse documents rather than StringBuilder/Scanner

Except for unit tests, we're formatting and parsing JSON documents ourselves using classes like StringBuilder and Scanner. This was the quickest way for me to produce a running prototype back in 2011, and it scaled surprisingly well. But there are several reasons for finally switching to a JSON library: less code, fewer bugs, and potentially better performance. The most recent hack for #11350 (moved) made me think that we finally have to switch to Gson for formatting and parsing all our JSON documents.

The following classes should be (de-)serialized using Gson:

  • UptimeDocument
  • ClientsDocument
  • WeightsDocument
  • BandwidthDocument
  • DetailsDocument
  • DetailsStatus
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#11577