Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #11821

Closed (moved)
Open
Opened May 08, 2014 by Karsten Loesing@karsten

DescriptorReader gets confused by files containing multiple descriptors if they contain non-ASCII characters

When parsing a file containing multiple server descriptors with DescriptorReader, the file content is first separated into parts starting with "router ", and these chunks are then parsed. However, it seems we have an encoding problem there:

If a server descriptor contains non-ASCII characters, like in its platform or contact line, we don't cut off at the right character, so that the next descriptor seems to start with "\nrouter ". Empty lines are not allowed, so we don't accept that descriptor.

What's funny is that this problem only happens on the console, not when run in Eclipse. Probably related to different locale settings.

Not sure what the right fix is. Maybe we should split input strings as long as they're contained in byte[].

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#11821