>=0.2.1.3-alpha don't weight guard choice
Right now we're picking which guards we'll use uniformly at random from all nodes, and we're picking which of our guards we'll use uniformly at random from the nodes in our guard list that have the Guard flag.
We used to have this bad behavior, but we fixed it in 0.2.0.3-alpha and 0.1.2.17. See bug 440 for more details.
But then in 0.2.1.3-alpha (git ed781e69), we refactored how we called router_choose_random_node(), and we got it wrong. We end up never passing CRN_NEED_GUARD in the case where we're choosing a new entry guard (where state is NULL).
So a) we don't choose it by bandwidth, and b) we don't even see if it's got the Guard flag -- or even the Fast flag -- when selecting it.
The fix is to call router_choose_random_node() with the NEED_GUARD flag when state is NULL. The next piece of the fix is to modify remove_obsolete_entry_guards() so it discards guards chosen between 0.2.1.3-alpha and 0.2.1.21, and between 0.2.2.1-alpha and 0.2.2.6-alpha.
[Automatically added by flyspray2trac: Operating System: All]