Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #12647

Closed (moved)
Open
Opened Jul 17, 2014 by Mark Smith@mcs

updater needs to support use of symlinks

In #11429 (moved), the "second Tor Browser dock icon on Mac OS" problem was solved by using a different Info.plist for the browser app bundle that is used by meek. Symlinks are used to create the second app bundle (to avoid duplicating all of the browser binaries).

Unfortunately, based on code inspection, it looks like the Mozilla updater implementation does not support symlinks. I will confirm next week by doing some testing, but assuming I am correct we will need to either:

(1) Patch the updater code to handle symlinks.

or

(2) Avoid symlinks in the package (but I do not have a better idea for solving #11429 (moved)).

I have not yet scoped the work for (1); hopefully it will not be too much work. If we always remove symlinks before applying an update, it may be enough to add support for a "addsymlink" verb in the update manifest.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#12647