Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #12663

Closed
Open
Opened Jul 20, 2014 by cypherpunks@cypherpunks

Orbot, libevent and BSD sed ( includes patch )

Compilation of Orbot stops at libevent if using BSD sed rather than GNU sed.

The error is :

sed -i 's@(SUBDIRS = . include) sample test@\1@' libevent/Makefile.am sed: 1: "libevent/Makefile.am": extra characters at the end of l command

I have traced the problem to Orbot's external/Makefile.

There is a difference between BSD and GNU sed with regards to the inplace -i flag, both accept an argument for a file extension to backup to, if no extension is provided no backup is made, however BSD sed requires an argument even if it is empty, whereas GNU sed ignores it.

The attached patch adds an extension rather than provide an empty argument, this should work with both GNU and BSD sed, though I haven't tried it with the former.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#12663