Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #13066

Closed (moved)
(moved)
Open
Created Sep 05, 2014 by George Kadianakis@asn

smartlist_choose_node_by_bandwidth() does not consider bad exit

smartlist_choose_node_by_bandwidth() does not check for the bad exit flag, and can return badexited relays. The sister function smartlist_choose_node_by_bandwidth_weights correctly checks for the bad exit flag.

The good thing is that node_sl_choose_by_bandwidth() will only use the faulty function if the bandwidth weight system fails. This should not happen to the current network though. Hence, this does not seem to be a big issue.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking