Skip to content

GitLab

Trac
Trac

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

Closed (moved)
Opened by Nick Mathewson@nickm🥄

Stop using operators as macro arguments ?

The "coccinelle" semantic patch tool really gets confused when we use operators as macro arguments. It can't modify any function that does that. We use operators as macro arguments in two ways:

  1. We pass them to timercmp.

  2. We pass them as arguments to our tt_*_op() macros.

It's pretty trivial to make this change: We just need to add "#define LT <" and so forth, and then we can use a perl script ro replace "<," and "<)" with "LT". Then so on for GT, EQ, NEQ, GEQ, LEQ.

Is this worthwhile?

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information