Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #13936

Closed (moved)
(moved)
Open
Created Dec 10, 2014 by David Goulet@dgoulet🆘

circuit_has_opened() should be called for rendezvous circuit

In circuit_get_open_circ_or_launch(), for a rendezvous circuit, we directly called rend_client_rendcirc_has_opened() but I think circuit_has_opened() should be prefered here which then use a specialized function for each circuit purpose. Also, it fires a controller event where the former did not.

Side effect is that connection_ap_attach_pending() is called right after but I don't think it affects anything here but that needs review of course.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking