Toggle NetworkSettings menuitem visibility based on an environment variable

This is a feature requested by some linux distros, where the "Open Network Settings..." menuitem in TorButton is unneeded. A patch is to be made so this menuitem becomes hidden if a certain environment variable is set.

Trac:
Username: linostar

added GeorgKoppen201501 component::applications/tor browser owner::mcs priority::medium reporter::linostar resolution::fixed severity::normal status::closed tbb-4.5-alpha-3 tbb-torbutton tbb-usability type::enhancement labels

I made a patch that implement the solution described in the first post:

https://github.com/linostar/torbutton/commit/92d2ee890004baddf5d4da39664ed1ba14c665d2

Trac:
Username: linostar
Status: new to needs_review

Trac:
Component: Torbutton to Tor Browser

Patch was also tested by me and worked fine. Thanks linostar!

The older patch link is now obsolete. I made a small alteration to make the code cover all logical cases.

New patch: https://github.com/linostar/torbutton/commit/d33d7c7d7c74b7140240e6e1d17d72ae3808a6c3

Trac:
Username: linostar

Trac:
Cc: proper to proper, brade
Owner: N/A to mcs
Keywords: N/A deleted, tbb-usability, TorBrowserTeam201501R, tbb-torbutton added
Status: needs_review to assigned

Trac:
Status: assigned to needs_review

In which scenario is it a feature to prevent the user from switching to a pluggable transport easily from within the browser itself in case she just get blocked in some country?

Replying to gk:

In which scenario is it a feature to prevent the user from switching to a pluggable transport easily from within the browser itself in case she just get blocked in some country?

In any scenario, where Tor runs on a different system than the browser. Such as Whonix, where Tor is running on Whonix-Gateway, while Tor Browser is running in Whonix-Workstation. Or on systems, where the browser is by design not supposed to configure Tor/pluggable transports. Such as Tails, if I understand that right. They use tor-launcher in standalone mode and not the let user configure Tor/pluggable transports within the browser.

For easily configuring pluggable transports in such cases, we have in something else in mind: #14121 (moved): make TBB usable as "system Tor"

Just checking for the existence of the env variable should be enough. Could you adapt the patch accordingly?

Replying to gk:

Just checking for the existence of the env variable should be enough. Could you adapt the patch accordingly?

Sure. Here you go: https://github.com/linostar/torbutton/commit/748cb437c1189ed0ad4b65f69e9c0ac06c4a1914

Trac:
Username: linostar

Trac:
Keywords: N/A deleted, tbb-4.5-alpha-3 added

Trac:
Keywords: TorBrowserTeam201501R deleted, GeorgKoppen201501R added

Added as commit 765fee607af6fa88b99476dee10298e5db3b9eb1. I had to tweak the commit message a bit and removed the superfluous newline/whitespace. Thanks.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

Trac:
Keywords: GeorgKoppen201501R deleted, GeorgKoppen201501 added

I called #10632 (moved) a duplicate.

Trac:
Sponsor: N/A to N/A
Severity: N/A to Normal

closed

moved to tpo/applications/tor-browser#14100 (closed)