Torbutton menu does not open in non-en-US 4.5a3 Tor Browser
I just realized today that a click on the Torbutton onion in non-en-US Tor Browser versions (4.5a3) does nothing. No menu and no error message is showing up. The first commit that fails is 000d727a34a7256d993662ce848112c419520860. The strings did not get localized. This is strange as there should be at least en-US fallbacks if these are not translated yet. But nothing gets updated if I run
That got reported several times in our blog, see: https://blog.torproject.org/blog/tor-browser-45a3-released#comment-86496 for one example.
While we are at it: we should write a simple test that clicks on the Torbutton menubutton and on some buttons on the opening dialog to make sure such problems don't go unnoticed in the future.