torsocks's getaddrinfo() is broken.
torsocks's getaddrinfo() implementation does not respect AI_NUMERICHOST
.
This is wrong because it will do the resolution anyway, and things that expect to be able to use getaddrinfo()
as a super inet_pton()
break.
The correct thing to do is to check if the string is an address and return EAI_NONAME
if it's not, without doing the tor resolution.
With this, #15497
and #13294
all fixed, aria2c
actually works with torsocks again, as long as async dns is disabled. Yay.