Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #15652

Closed (moved)
(moved)
Open
Created Apr 10, 2015 by Yawning Angel@yawning

Base64 code cleanups.

The base64 encoder/decoder can use some love of the following sort:

  • The code gated by USE_OPENSSL_BASE64 should probably be removed, since we haven't used OpenSSL's base64 decoder since 2007, and enabling it will do weird and broken things (Eg: Inputs that aren't broken up into into lines that are < 80 characters will fail to decode correctly).
  • It would be really nice to have a Base64 encode that doesn't automatically add \n characters.
  • Having a routine to get the encoded output size makes for cleaner code.
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking