Trac:
Keywords: N/A deleted, tbb-crash added

Trac:
Status: new to assigned
Cc: N/A to tbb-team
Owner: tbb-team to sisbell

I'm thinking we just put a null check around

    Tabs.getInstance().getSelectedTab().doReload(true);

If this code is skipped due to a null tab (race condition), then worst case is it won't reload the view, leaving the tab content improperly formatted.

I wasn't able to do a full clone of the tor-browser repo on github due to 2GB repo size limitation on github. I took the branch tor-browser-68.2.0esr-9.5-1 (without history) and made the following commit.

https://github.com/sisbell/tor-browser/commit/170876b6516539fef0580eeec9ae7ac252863eaf

Trac:
Keywords: TorBrowserTeam201911 deleted, TorBrowserTeam201911R added
Points: N/A to .25
Status: assigned to needs_review

As a note, when I imported to github it flagged 4 security vulnerabilities in the tor-browser libraries. Github automatically created pull requests for them.

https://github.com/sisbell/tor-browser/pulls

Security Issues https://github.com/advisories/GHSA-rprw-h62v-c2w7 https://github.com/advisories/GHSA-3gx7-xhv7-5mx3 https://github.com/advisories/GHSA-x84v-xcm2-53pg https://github.com/advisories/GHSA-mh33-7rrq-662w

Replying to sisbell:

I wasn't able to do a full clone of the tor-browser repo on github due to 2GB repo size limitation on github. I took the branch tor-browser-68.2.0esr-9.5-1 (without history) and made the following commit.

https://github.com/sisbell/tor-browser/commit/170876b6516539fef0580eeec9ae7ac252863eaf

Thanks! Looks good to me. Picked as eb11dea87f544caa551c67530975c8765f598acd.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

Backported this to tor-browser-68.3.0esr-9.0-1 as commit 4eb56ec0936e03dcc5d7e83322961c986065dc5d.

Trac:
Keywords: N/A deleted, tbb-backport added

Tag as backported, too.

Trac:
Keywords: N/A deleted, tbb-backported added

The logic is to replace tbb-backport with tbb-backported.

+1 to follow (submitted this as dupe: https://trac.torproject.org/projects/tor/ticket/32693)

Trac:
Username: ilf

Trac:
Keywords: tbb-backport deleted, N/A added