Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #16433

Closed (moved)
Open
Opened Jun 24, 2015 by cypherpunks@cypherpunks

infinite recursion in torsocks log timestamps

If libc calls open and close in order to deal with time zones for localtime, the torsocks interception of close may lead to infinite recursion: torsocks close tries to print a log message, which needs a timestamp, which it formats with localtime, which opens the tz database and calls close when done, which tries to print a log message, which needs a timestamp...

(NetBSD's libc is an example of such a libc. Note gmtime has the same property.)

The attached patch changes timestamps to be seconds since epoch minus leap seconds, i.e. a standard POSIX clock, in order to avoid this recursion.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#16433