Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #16458

Closed (moved)
Open
Opened Jun 28, 2015 by teor@teor

torspec references UTC, but tor uses unix time (leap second handling)

When the various torspec documents specify time, they refer to UTC. But the implementations used by at least Linux, *BSD and OS X are based on the Unix time epoch.

This makes a difference to how leap seconds are handled: UTC includes leap seconds, but unix time excludes them.

We should:

  • ensure that none of the security properties of tor depend on leap seconds either being present or absent, either individually or in aggregate:
  • every minute is not 60 seconds long (and equivalently for hour, day, week)
  • some epoch times can repeat or be missing
  • UTC and Unix time differ by approximately 30 seconds
  • check how the current Linux, BSD, Windows and OS X implementations handle leap seconds (in roughly that order of priority)
  • consider and document tor's handling of leap seconds

See:

  • https://en.wikipedia.org/wiki/Leap_second
  • https://en.wikipedia.org/wiki/Unix_time
To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: unspecified
Milestone
Tor: unspecified
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#16458